[hibernate-issues] [JIRA] (HHH-15728) Consider parameter values in QueryKey hashCode but disregard firstResult/maxResults

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiOWMwNjdiZGY5... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15728?atlOrigin=eyJpIjoiOWMwNj... ) HHH-15728 ( https://hibernate.atlassian.net/browse/HHH-15728?atlOrigin=eyJpIjoiOWMwNj... ) Consider parameter values in QueryKey hashCode but disregard firstResult/maxResults ( https://hibernate.atlassian.net/browse/HHH-15728?atlOrigin=eyJpIjoiOWMwNj... ) Issue Type: Improvement Affects Versions: 6.1.5 Assignee: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hibernate-core Created: 16/Nov/2022 02:03 AM Fix Versions: 6.1.6 Priority: Major Reporter: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) In flame graphs we saw that not considering the parameter values of a query in the QueryKey#hashCode will lead to many hash collisions. It doesn’t seem to be very useful to include the firstResult / maxResults though IMO, as such queries probably aren’t cached often. Experiments with SpecJ showed that this improve performance and eliminate collisions in the benchmark scenario. ( https://hibernate.atlassian.net/browse/HHH-15728#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15728#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )