[JBoss JIRA] (ISPN-2651) Default useSynchronization and recovery value changes make tests fail
by Mircea Markus (JIRA)
[ https://issues.jboss.org/browse/ISPN-2651?page=com.atlassian.jira.plugin.... ]
Mircea Markus updated ISPN-2651:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Default useSynchronization and recovery value changes make tests fail
> ---------------------------------------------------------------------
>
> Key: ISPN-2651
> URL: https://issues.jboss.org/browse/ISPN-2651
> Project: Infinispan
> Issue Type: Bug
> Components: Configuration, Transactions
> Reporter: Galder Zamarreño
> Assignee: Mircea Markus
> Priority: Critical
> Fix For: 5.2.0.CR1, 5.2.0.Final
>
>
> While investigating ISPN-2054 I've found an important issue wrt default transaction configuration options.
> First of all, InvocationContextTest.testMishavingListenerResumesContext() is incorrectly coded. It misses the following line after the cache put call to make sure that only exceptional path makes the test pass:
> {code}fail("Should have failed with an exception");{code}
> With that in mind, and taking in account that this test uses old programmatic configuration:
> {code}
> Configuration cfg = TestCacheManagerFactory.getDefaultConfiguration(true);
> cfg.setSyncCommitPhase(true);
> cfg.setSyncRollbackPhase(true);
> cfg.fluent().transaction().lockingMode(LockingMode.PESSIMISTIC);
> createClusteredCaches(1, "timestamps", cfg);
> {code}
> We should be able to switch it to equivalent new configuration and testMishavingListenerResumesContext should pass:
> {code}
> ConfigurationBuilder builder = TestCacheManagerFactory.getDefaultCacheConfiguration(true);
> builder.transaction()
> .syncCommitPhase(true).syncRollbackPhase(true)
> .lockingMode(LockingMode.PESSIMISTIC);
> createClusteredCaches(1, "timestamps", builder);
> {code}
> The problem is that the test does not pass once you switch to equivalent new configuration. It fails with "Should have failed with an exception" message.
> After debugging, the reason is cos default values in old configuration have been changed for new configuration. To be more precise, in old configuration, defaults are:
> useSynchronization = false
> recovery enabled = false
> In new configuration, equivalent defaults are:
> useSynchronization = true
> recovery enabled = true
> In fact, once you change defaults in new configuration to be both false, the test passes.
> So, this JIRA must address the following:
> 1. Why have default values have changed? This is very risky since what should be equivalent configurations externally don't behave the same way.
> 2. When has these defaults changed and since when has the behaivour changed?
> 3a. If these new default values are reasonable, documentation must be provided in our upgrade guide section bearing in mind the major version in which the default values changed (see https://docs.jboss.org/author/display/ISPN/Upgrade+Guide). The code should also be documented to note down that some tests might fail which would not otherwise because of change of those default values
> 3b. If default values should not have changed, they must be reverted and it needs to be checked whether any major release has been out with the default values changed and document it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (ISPN-2534) Some tests are not picked up by Surefire
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-2534?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-2534:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Integrated. Thanks!
> Some tests are not picked up by Surefire
> ----------------------------------------
>
> Key: ISPN-2534
> URL: https://issues.jboss.org/browse/ISPN-2534
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite
> Affects Versions: 5.2.0.Beta4
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Fix For: 5.2.0.Final
>
>
> Surefire picks up tests named {{\*Test.java}} and {{Test*.java}}, but not {{\*Test\*.java}}.
> There are some tests that don't follow the {{*Test.java}} naming convention, and because of that they don't run in the test suite:
> ./query/src/test/java/org/infinispan/query/config/MultipleCachesTests.java
> ./query/src/test/java/org/infinispan/query/indexedembedded/BooksExampleTests.java
> ./cli/cli-server/src/test/java/org/infinispan/cli/interpreter/ClusteredCLITests.java
> ./cachestore/jdbc/src/test/java/org/infinispan/loaders/jdbc/stringbased/JdbcStringBasedCacheStoreTest2.java
> ./cachestore/jdbc/src/test/java/org/infinispan/loaders/jdbc/stringbased/JdbcStringBasedCacheStoreVamTest2.java
> ./cachestore/jdbc/src/test/java/org/infinispan/loaders/jdbc/mixed/JdbcMixedCacheStoreTest2.java
> ./cachestore/jdbc/src/test/java/org/infinispan/loaders/jdbc/mixed/JdbcMixedCacheStoreVamTest2.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (ISPN-2620) A segment can end up in two different InboutTransferTasks
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-2620?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-2620:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Integrated. Thanks!
> A segment can end up in two different InboutTransferTasks
> ---------------------------------------------------------
>
> Key: ISPN-2620
> URL: https://issues.jboss.org/browse/ISPN-2620
> Project: Infinispan
> Issue Type: Bug
> Components: State transfer
> Affects Versions: 5.2.0.Beta5
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Critical
> Fix For: 5.2.0.CR1
>
> Attachments: cnolt.log.gz
>
>
> ConcurrentNonOverlappingLeaveTest is de facto disabled because of RehashTestBase doesn't have the @Test annotation (see ISPN-2534).
> I tried to enable it, but rehash wouldn't finish because NodeA wouldn't confirm receiving segment 38 from NodeC (the initial cluster was [NodeA, NodeB, NodeC, NodeD]). I think this is because segment 38 appears in two InboundTransferTasks:
> {noformat}
> 17:12:37,211 TRACE (OOB-5,ISPN,NodeA-49710:dist) [StateConsumerImpl] Segments not received yet for cache dist: {NodeC-40582=[
> InboundTransferTask{segments=[38], finishedSegments=[], unfinishedSegments=[38], source=NodeC-40582, isCancelled=false, topologyId=7, timeout=240000, cacheName=dist},
> InboundTransferTask{segments=[38, 42, 43, 40, 41, 51, 50, 49, 55, 54, 53, 52, 59, 58, 57, 56], finishedSegments=[40], unfinishedSegments=[38, 42, 43, 41, 51, 50, 49, 55, 54, 53, 52, 59, 58, 57, 56], source=NodeC-40582, isCancelled=false, topologyId=9, timeout=240000, cacheName=dist}]}
> 17:12:37,211 DEBUG (OOB-5,ISPN,NodeA-49710:dist) [StateConsumerImpl] Applying new state for segment 38 of cache dist from node NodeC-40582: received 0 cache entries
> 17:12:37,211 TRACE (OOB-5,ISPN,NodeA-49710:dist) [StateConsumerImpl] Segments not received yet for cache dist: {NodeC-40582=[
> InboundTransferTask{segments=[38], finishedSegments=[], unfinishedSegments=[38], source=NodeC-40582, isCancelled=false, topologyId=7, timeout=240000, cacheName=dist},
> InboundTransferTask{segments=[38, 42, 43, 40, 41, 51, 50, 49, 55, 54, 53, 52, 59, 58, 57, 56], finishedSegments=[40, 57, 38], unfinishedSegments=[42, 43, 41, 51, 50, 49, 55, 54, 53, 52, 59, 58, 56], source=NodeC-40582, isCancelled=false, topologyId=9, timeout=240000, cacheName=dist}]}
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (ISPN-2666) StateTransferPessimisticTest.testStateTransfer fails randomly
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-2666?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-2666:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Integrated. Thanks!
> StateTransferPessimisticTest.testStateTransfer fails randomly
> -------------------------------------------------------------
>
> Key: ISPN-2666
> URL: https://issues.jboss.org/browse/ISPN-2666
> Project: Infinispan
> Issue Type: Bug
> Components: State transfer
> Reporter: Galder Zamarreño
> Assignee: Adrian Nistor
> Labels: testsuite_stability
> Fix For: 5.2.0.CR1
>
>
> {code}testStateTransfer(org.infinispan.statetransfer.StateTransferPessimisticTest) Time elapsed: 0.323 sec <<< FAILURE!
> java.lang.AssertionError: expected:<1> but was:<2>
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.failNotEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:128)
> at org.junit.Assert.assertEquals(Assert.java:472)
> at org.junit.Assert.assertEquals(Assert.java:456)
> at org.infinispan.statetransfer.StateTransferPessimisticTest.testStateTransfer(StateTransferPessimisticTest.java:104)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:715)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:680){code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (ISPN-2666) StateTransferPessimisticTest.testStateTransfer fails randomly
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-2666?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-2666:
--------------------------------
Affects Version/s: 5.2.0.Beta6
> StateTransferPessimisticTest.testStateTransfer fails randomly
> -------------------------------------------------------------
>
> Key: ISPN-2666
> URL: https://issues.jboss.org/browse/ISPN-2666
> Project: Infinispan
> Issue Type: Bug
> Components: State transfer
> Affects Versions: 5.2.0.Beta6
> Reporter: Galder Zamarreño
> Assignee: Adrian Nistor
> Labels: testsuite_stability
> Fix For: 5.2.0.CR1
>
>
> {code}testStateTransfer(org.infinispan.statetransfer.StateTransferPessimisticTest) Time elapsed: 0.323 sec <<< FAILURE!
> java.lang.AssertionError: expected:<1> but was:<2>
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.failNotEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:128)
> at org.junit.Assert.assertEquals(Assert.java:472)
> at org.junit.Assert.assertEquals(Assert.java:456)
> at org.infinispan.statetransfer.StateTransferPessimisticTest.testStateTransfer(StateTransferPessimisticTest.java:104)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:715)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:680){code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (ISPN-2666) StateTransferPessimisticTest.testStateTransfer fails randomly
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-2666?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-2666:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/1535
> StateTransferPessimisticTest.testStateTransfer fails randomly
> -------------------------------------------------------------
>
> Key: ISPN-2666
> URL: https://issues.jboss.org/browse/ISPN-2666
> Project: Infinispan
> Issue Type: Bug
> Components: State transfer
> Reporter: Galder Zamarreño
> Assignee: Adrian Nistor
> Labels: testsuite_stability
> Fix For: 5.2.0.CR1
>
>
> {code}testStateTransfer(org.infinispan.statetransfer.StateTransferPessimisticTest) Time elapsed: 0.323 sec <<< FAILURE!
> java.lang.AssertionError: expected:<1> but was:<2>
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.failNotEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:128)
> at org.junit.Assert.assertEquals(Assert.java:472)
> at org.junit.Assert.assertEquals(Assert.java:456)
> at org.infinispan.statetransfer.StateTransferPessimisticTest.testStateTransfer(StateTransferPessimisticTest.java:104)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:715)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:680){code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (ISPN-2613) Write performance slowed down by IndexReader warmup with indexing enabled in NRT mode
by Sanne Grinovero (JIRA)
[ https://issues.jboss.org/browse/ISPN-2613?page=com.atlassian.jira.plugin.... ]
Sanne Grinovero commented on ISPN-2613:
---------------------------------------
This issue is resolved by upgrading to Hibernate Search >=4.2.0.CR1 as it contains such an auto-adapting NRT ReaderProvider as described in this issue.
(No configuration changes are needed)
> Write performance slowed down by IndexReader warmup with indexing enabled in NRT mode
> -------------------------------------------------------------------------------------
>
> Key: ISPN-2613
> URL: https://issues.jboss.org/browse/ISPN-2613
> Project: Infinispan
> Issue Type: Enhancement
> Components: Querying
> Reporter: Sanne Grinovero
> Assignee: Sanne Grinovero
> Fix For: 5.2.0.CR1, 5.2.0.Final
>
>
> The indexing engine when configured with NRT is still very tuned for read-mostly performance, pre-warming readers at each non-batch write operation. This makes it not suited for write-mostly and analytic use cases.
> We should be able to detect the use case and have the NRT engine adapt to the workload.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months