[JBoss JIRA] (ISPN-4715) Resolve race condition in Lock promotion of IndexManager
by Sanne Grinovero (JIRA)
Sanne Grinovero created ISPN-4715:
-------------------------------------
Summary: Resolve race condition in Lock promotion of IndexManager
Key: ISPN-4715
URL: https://issues.jboss.org/browse/ISPN-4715
Project: Infinispan
Issue Type: Bug
Components: Embedded Querying
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 7.0.0.Beta2
Multiple incoming threads could hit the synchronization lock while the promotion is being upgraded, the non-first ones need to be allowed an early exit if the promotion already took place.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (ISPN-4712) Mutable SearchFactory needs to be passed new types exclusively
by Sanne Grinovero (JIRA)
Sanne Grinovero created ISPN-4712:
-------------------------------------
Summary: Mutable SearchFactory needs to be passed new types exclusively
Key: ISPN-4712
URL: https://issues.jboss.org/browse/ISPN-4712
Project: Infinispan
Issue Type: Bug
Components: Embedded Querying
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 7.0.0.Beta2
{{updateSearchFactory}} in {{updateSearchFactory}} need to be passed only new types which are not registered already nor *being registered concurrently*: the types need to be validated again while holding the mutation lock.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (ISPN-4706) Executing a GET during (another) node leaving throws "Failure to marshal argument(s)"
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-4706?page=com.atlassian.jira.plugin.... ]
Dan Berindei commented on ISPN-4706:
------------------------------------
[~sannegrinovero] from the stack trace it looks like the node that's sending the ClusteredGetCommand is shutting down, not another node.
> Executing a GET during (another) node leaving throws "Failure to marshal argument(s)"
> -------------------------------------------------------------------------------------
>
> Key: ISPN-4706
> URL: https://issues.jboss.org/browse/ISPN-4706
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 7.0.0.Beta1
> Reporter: Sanne Grinovero
> Assignee: Dan Berindei
> Priority: Critical
>
> Having a moderate load doing various GET operations, when *another* node is leaving all operations fail:
> {noformat}2014-09-10 01:31:19,963 ERROR [InvocationContextInterceptor] (testng-IndexManagerStressTest-3) ISPN000136: Execution error
> org.infinispan.commons.CacheException: java.lang.RuntimeException: Failure to marshal argument(s)
> at org.infinispan.commons.util.Util.rewrapAsCacheException(Util.java:655)
> at org.infinispan.remoting.transport.jgroups.CommandAwareRpcDispatcher.invokeRemoteCommands(CommandAwareRpcDispatcher.java:141)
> at org.infinispan.remoting.transport.jgroups.JGroupsTransport.invokeRemotely(JGroupsTransport.java:539)
> at org.infinispan.remoting.rpc.RpcManagerImpl.invokeRemotely(RpcManagerImpl.java:281)
> at org.infinispan.interceptors.distribution.BaseDistributionInterceptor.invokeClusterGetCommandRemotely(BaseDistributionInterceptor.java:158)
> at org.infinispan.interceptors.distribution.BaseDistributionInterceptor.retrieveFromRemoteSource(BaseDistributionInterceptor.java:146)
> at org.infinispan.interceptors.distribution.NonTxDistributionInterceptor.remoteGetCacheEntry(NonTxDistributionInterceptor.java:155)
> at org.infinispan.interceptors.distribution.NonTxDistributionInterceptor.visitGetKeyValueCommand(NonTxDistributionInterceptor.java:48)
> at org.infinispan.commands.read.GetKeyValueCommand.acceptVisitor(GetKeyValueCommand.java:44)
> at org.infinispan.interceptors.base.CommandInterceptor.invokeNextInterceptor(CommandInterceptor.java:98)
> at org.infinispan.interceptors.EntryWrappingInterceptor.visitGetKeyValueCommand(EntryWrappingInterceptor.java:129)
> at org.infinispan.commands.read.GetKeyValueCommand.acceptVisitor(GetKeyValueCommand.java:44)
> at org.infinispan.interceptors.base.CommandInterceptor.invokeNextInterceptor(CommandInterceptor.java:98)
> at org.infinispan.interceptors.locking.NonTransactionalLockingInterceptor.visitGetKeyValueCommand(NonTransactionalLockingInterceptor.java:32)
> at org.infinispan.commands.read.GetKeyValueCommand.acceptVisitor(GetKeyValueCommand.java:44)
> at org.infinispan.interceptors.base.CommandInterceptor.invokeNextInterceptor(CommandInterceptor.java:98)
> at org.infinispan.interceptors.base.CommandInterceptor.handleDefault(CommandInterceptor.java:112)
> at org.infinispan.commands.AbstractVisitor.visitGetKeyValueCommand(AbstractVisitor.java:75)
> at org.infinispan.commands.read.GetKeyValueCommand.acceptVisitor(GetKeyValueCommand.java:44)
> at org.infinispan.interceptors.base.CommandInterceptor.invokeNextInterceptor(CommandInterceptor.java:98)
> at org.infinispan.interceptors.base.CommandInterceptor.handleDefault(CommandInterceptor.java:112)
> at org.infinispan.commands.AbstractVisitor.visitGetKeyValueCommand(AbstractVisitor.java:75)
> at org.infinispan.commands.read.GetKeyValueCommand.acceptVisitor(GetKeyValueCommand.java:44)
> at org.infinispan.interceptors.base.CommandInterceptor.invokeNextInterceptor(CommandInterceptor.java:98)
> at org.infinispan.statetransfer.StateTransferInterceptor.handleTopologyAffectedCommand(StateTransferInterceptor.java:217)
> at org.infinispan.statetransfer.StateTransferInterceptor.handleDefault(StateTransferInterceptor.java:201)
> at org.infinispan.commands.AbstractVisitor.visitGetKeyValueCommand(AbstractVisitor.java:75)
> at org.infinispan.commands.read.GetKeyValueCommand.acceptVisitor(GetKeyValueCommand.java:44)
> at org.infinispan.interceptors.base.CommandInterceptor.invokeNextInterceptor(CommandInterceptor.java:98)
> at org.infinispan.interceptors.CacheMgmtInterceptor.visitGetKeyValueCommand(CacheMgmtInterceptor.java:92)
> at org.infinispan.commands.read.GetKeyValueCommand.acceptVisitor(GetKeyValueCommand.java:44)
> at org.infinispan.interceptors.base.CommandInterceptor.invokeNextInterceptor(CommandInterceptor.java:98)
> at org.infinispan.interceptors.InvocationContextInterceptor.handleAll(InvocationContextInterceptor.java:108)
> at org.infinispan.interceptors.InvocationContextInterceptor.handleDefault(InvocationContextInterceptor.java:71)
> at org.infinispan.commands.AbstractVisitor.visitGetKeyValueCommand(AbstractVisitor.java:75)
> at org.infinispan.commands.read.GetKeyValueCommand.acceptVisitor(GetKeyValueCommand.java:44)
> at org.infinispan.interceptors.InterceptorChain.invoke(InterceptorChain.java:333)
> at org.infinispan.cache.impl.CacheImpl.get(CacheImpl.java:392)
> at org.infinispan.cache.impl.DecoratedCache.get(DecoratedCache.java:400)
> at org.infinispan.lucene.impl.SingleChunkIndexInput.<init>(SingleChunkIndexInput.java:26)
> at org.infinispan.lucene.impl.DirectoryLuceneV4.openInput(DirectoryLuceneV4.java:98)
> at org.apache.lucene.store.Directory.openChecksumInput(Directory.java:114)
> at org.apache.lucene.index.SegmentInfos.read(SegmentInfos.java:329)
> at org.apache.lucene.index.SegmentInfos$1.doBody(SegmentInfos.java:416)
> at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:864)
> at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:710)
> at org.apache.lucene.index.SegmentInfos.read(SegmentInfos.java:412)
> at org.apache.lucene.index.StandardDirectoryReader.isCurrent(StandardDirectoryReader.java:347)
> at org.apache.lucene.index.StandardDirectoryReader.doOpenNoWriter(StandardDirectoryReader.java:301)
> at org.apache.lucene.index.StandardDirectoryReader.doOpenIfChanged(StandardDirectoryReader.java:264)
> at org.apache.lucene.index.StandardDirectoryReader.doOpenIfChanged(StandardDirectoryReader.java:252)
> at org.apache.lucene.index.DirectoryReader.openIfChanged(DirectoryReader.java:171)
> at org.hibernate.search.indexes.impl.SharingBufferReaderProvider$PerDirectoryLatestReader.refreshAndGet(SharingBufferReaderProvider.java:238)
> at org.hibernate.search.indexes.impl.SharingBufferReaderProvider.openIndexReader(SharingBufferReaderProvider.java:72)
> at org.hibernate.search.indexes.impl.SharingBufferReaderProvider.openIndexReader(SharingBufferReaderProvider.java:34)
> at org.hibernate.search.reader.impl.MultiReaderFactory.openReader(MultiReaderFactory.java:36)
> at org.hibernate.search.query.engine.impl.HSQueryImpl.buildSearcher(HSQueryImpl.java:617)
> at org.hibernate.search.query.engine.impl.HSQueryImpl.queryResultSize(HSQueryImpl.java:330)
> at org.infinispan.query.impl.CacheQueryImpl.getResultSize(CacheQueryImpl.java:86)
> at org.infinispan.query.distributed.IndexManagerStressTest.verifyQueryState(IndexManagerStressTest.java:270)
> at org.infinispan.query.distributed.IndexManagerStressTest.assertIndexStateIsEventuallyConsistent(IndexManagerStressTest.java:232)
> at org.infinispan.query.distributed.IndexManagerStressTest$UserThread.run(IndexManagerStressTest.java:152)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.RuntimeException: Failure to marshal argument(s)
> at org.infinispan.remoting.transport.jgroups.CommandAwareRpcDispatcher.marshallCall(CommandAwareRpcDispatcher.java:354)
> at org.infinispan.remoting.transport.jgroups.CommandAwareRpcDispatcher.processCalls(CommandAwareRpcDispatcher.java:421)
> at org.infinispan.remoting.transport.jgroups.CommandAwareRpcDispatcher.invokeRemoteCommands(CommandAwareRpcDispatcher.java:132)
> ... 65 more
> Caused by: java.lang.InterruptedException: ISPN000239: Cache manager is shutting down, so type write externalizer for type=java.lang.Boolean cannot be resolved. Interruption being pushed up.
> at org.infinispan.marshall.core.ExternalizerTable.getObjectWriter(ExternalizerTable.java:176)
> at org.infinispan.marshall.core.JBossMarshaller$ExternalizerTableProxy.getObjectWriter(JBossMarshaller.java:143)
> at org.jboss.marshalling.river.RiverMarshaller.doWriteObject(RiverMarshaller.java:138)
> at org.jboss.marshalling.AbstractObjectOutput.writeObject(AbstractObjectOutput.java:58)
> at org.jboss.marshalling.AbstractMarshaller.writeObject(AbstractMarshaller.java:111)
> at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:58)
> at org.infinispan.marshall.exts.CacheRpcCommandExternalizer.marshallParameters(CacheRpcCommandExternalizer.java:125)
> at org.infinispan.marshall.exts.CacheRpcCommandExternalizer.writeObject(CacheRpcCommandExternalizer.java:109)
> at org.infinispan.marshall.exts.CacheRpcCommandExternalizer.writeObject(CacheRpcCommandExternalizer.java:65)
> at org.infinispan.marshall.core.ExternalizerTable$ExternalizerAdapter.writeObject(ExternalizerTable.java:415)
> at org.jboss.marshalling.river.RiverMarshaller.doWriteObject(RiverMarshaller.java:144)
> at org.jboss.marshalling.AbstractObjectOutput.writeObject(AbstractObjectOutput.java:58)
> at org.jboss.marshalling.AbstractMarshaller.writeObject(AbstractMarshaller.java:111)
> at org.infinispan.commons.marshall.jboss.AbstractJBossMarshaller.objectToObjectStream(AbstractJBossMarshaller.java:73)
> at org.infinispan.marshall.core.VersionAwareMarshaller.objectToBuffer(VersionAwareMarshaller.java:77)
> at org.infinispan.commons.marshall.AbstractMarshaller.objectToBuffer(AbstractMarshaller.java:41)
> at org.infinispan.commons.marshall.AbstractDelegatingMarshaller.objectToBuffer(AbstractDelegatingMarshaller.java:85)
> at org.infinispan.remoting.transport.jgroups.MarshallerAdapter.objectToBuffer(MarshallerAdapter.java:23)
> at org.infinispan.remoting.transport.jgroups.CommandAwareRpcDispatcher.marshallCall(CommandAwareRpcDispatcher.java:352)
> ... 67 more
> Caused by: an exception which occurred:
> in object java.lang.Boolean@4d5
> in object org.infinispan.commands.remote.ClusteredGetCommand@20ef3c0f{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (ISPN-4699) Non indexed query fails when a cachestore is used
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-4699?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-4699:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Non indexed query fails when a cachestore is used
> -------------------------------------------------
>
> Key: ISPN-4699
> URL: https://issues.jboss.org/browse/ISPN-4699
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 7.0.0.Beta1
> Reporter: Adrian Nistor
> Assignee: Adrian Nistor
> Fix For: 7.0.0.Beta2
>
>
> {quote}
> 2014-05-08 16:32:05,586 WARN [LocalEntryRetriever] (transport-thread-NonIndexedClusteredDummyInMemoryStoreQueryDslConditionsTest-NodeA-p3871-t3) ISPN000300: There was an exception while processing retrieval of entry values
> java.lang.IllegalArgumentException: argument cannot be null
> at org.infinispan.objectfilter.impl.BaseMatcher$3.filter(BaseMatcher.java:152)
> at org.infinispan.query.dsl.embedded.impl.FilterAndConverter.filterAndConvert(FilterAndConverter.java:91)
> at org.infinispan.query.dsl.embedded.impl.FilterAndConverter.filterAndConvert(FilterAndConverter.java:28)
> at org.infinispan.filter.AbstractKeyValueFilterConverter.accept(AbstractKeyValueFilterConverter.java:23)
> at org.infinispan.filter.KeyValueFilterAsKeyFilter.accept(KeyValueFilterAsKeyFilter.java:17)
> at org.infinispan.filter.CompositeKeyFilter.accept(CompositeKeyFilter.java:19)
> at org.infinispan.persistence.dummy.DummyInMemoryStore.process(DummyInMemoryStore.java:158)
> at org.infinispan.persistence.manager.PersistenceManagerImpl.processOnAllStores(PersistenceManagerImpl.java:414)
> at org.infinispan.persistence.manager.PersistenceManagerImpl.processOnAllStores(PersistenceManagerImpl.java:399)
> at org.infinispan.iteration.impl.LocalEntryRetriever$1.run(LocalEntryRetriever.java:256)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (ISPN-4710) DistributedSegmentReadLocker should be allowed to skip ReadLocks on small files
by Sanne Grinovero (JIRA)
[ https://issues.jboss.org/browse/ISPN-4710?page=com.atlassian.jira.plugin.... ]
Sanne Grinovero updated ISPN-4710:
----------------------------------
Description:
Both of these methods:
- {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.deleteOrReleaseReadLock(String)}}
- {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.realFileDelete(FileReadLockKey, AdvancedCache<Object, Integer>, AdvancedCache<?, ?>, AdvancedCache<?, ?>, boolean)}}
Are performing a lot of unnecessary operations - potentially on synchronous clustered caches - as we know in advance that files which are not being chunked don't need a read lock, and are not being chunked in smaller pieces (which affects how we delete things).
The determining factor between the two styles is defined in:
{{org.infinispan.lucene.impl.DirectoryLuceneV4.openInput(String, IOContext)}}
{code} @Override
public IndexInput openInput(final String name, final IOContext context) throws IOException {
final IndexInputContext indexInputContext = impl.openInput(name);
if ( indexInputContext.readLocks == null ) {
return new SingleChunkIndexInput(indexInputContext);
}
else {
return new InfinispanIndexInput(indexInputContext);
}
}{code}
was:
Both of these methods:
- {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.deleteOrReleaseReadLock(String)}}
- {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.realFileDelete(FileReadLockKey, AdvancedCache<Object, Integer>, AdvancedCache<?, ?>, AdvancedCache<?, ?>, boolean)}}
Are performing a lot of unnecessary operations - potentially on synchronous clustered caches - as we know in advance that files which are not being chunked don't need a read lock, and are not being chunked in smaller pieces (which affects how we delete things).
The determining factor between the two styles is defined in:
{{org.infinispan.lucene.impl.DirectoryLuceneV4.openInput(String, IOContext)}}
{code}@Override
public IndexInput openInput(final String name, final IOContext context) throws IOException {
final IndexInputContext indexInputContext = impl.openInput(name);
if ( indexInputContext.readLocks == null ) {
return new SingleChunkIndexInput(indexInputContext);
}
else {
return new InfinispanIndexInput(indexInputContext);
}
}{code}
> DistributedSegmentReadLocker should be allowed to skip ReadLocks on small files
> -------------------------------------------------------------------------------
>
> Key: ISPN-4710
> URL: https://issues.jboss.org/browse/ISPN-4710
> Project: Infinispan
> Issue Type: Enhancement
> Components: Lucene Directory
> Reporter: Sanne Grinovero
> Assignee: Gustavo Fernandes
> Fix For: 7.0.0.Beta2
>
>
> Both of these methods:
> - {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.deleteOrReleaseReadLock(String)}}
> - {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.realFileDelete(FileReadLockKey, AdvancedCache<Object, Integer>, AdvancedCache<?, ?>, AdvancedCache<?, ?>, boolean)}}
> Are performing a lot of unnecessary operations - potentially on synchronous clustered caches - as we know in advance that files which are not being chunked don't need a read lock, and are not being chunked in smaller pieces (which affects how we delete things).
> The determining factor between the two styles is defined in:
> {{org.infinispan.lucene.impl.DirectoryLuceneV4.openInput(String, IOContext)}}
> {code} @Override
> public IndexInput openInput(final String name, final IOContext context) throws IOException {
> final IndexInputContext indexInputContext = impl.openInput(name);
> if ( indexInputContext.readLocks == null ) {
> return new SingleChunkIndexInput(indexInputContext);
> }
> else {
> return new InfinispanIndexInput(indexInputContext);
> }
> }{code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months