[JBoss JIRA] (ISPN-4710) DistributedSegmentReadLocker should be allowed to skip ReadLocks on small files
by Sanne Grinovero (JIRA)
Sanne Grinovero created ISPN-4710:
-------------------------------------
Summary: DistributedSegmentReadLocker should be allowed to skip ReadLocks on small files
Key: ISPN-4710
URL: https://issues.jboss.org/browse/ISPN-4710
Project: Infinispan
Issue Type: Enhancement
Components: Lucene Directory
Reporter: Sanne Grinovero
Assignee: Gustavo Fernandes
Fix For: 7.0.0.Beta2
Both of these methods:
- {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.deleteOrReleaseReadLock(String)}}
- {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.realFileDelete(FileReadLockKey, AdvancedCache<Object, Integer>, AdvancedCache<?, ?>, AdvancedCache<?, ?>, boolean)}}
Are performing a lot of unnecessary operations - potentially on synchronous clustered caches - as we know in advance that files which are not being chunked don't need a read lock, and are not being chunked in smaller pieces (which affects how we delete things).
The determining factor between the two styles is defined in:
{{org.infinispan.lucene.impl.DirectoryLuceneV4.openInput(String, IOContext)}}
{code}@Override
public IndexInput openInput(final String name, final IOContext context) throws IOException {
final IndexInputContext indexInputContext = impl.openInput(name);
if ( indexInputContext.readLocks == null ) {
return new SingleChunkIndexInput(indexInputContext);
}
else {
return new InfinispanIndexInput(indexInputContext);
}
}{code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (ISPN-4708) Make DirectoryImplementor#deleteFile apply changes asynchronously
by Sanne Grinovero (JIRA)
Sanne Grinovero created ISPN-4708:
-------------------------------------
Summary: Make DirectoryImplementor#deleteFile apply changes asynchronously
Key: ISPN-4708
URL: https://issues.jboss.org/browse/ISPN-4708
Project: Infinispan
Issue Type: Enhancement
Components: Lucene Directory
Reporter: Sanne Grinovero
Assignee: Gustavo Fernandes
Fix For: 7.0.0.Beta2
Looks like the {{deleteFile}} operation is the main responsible component for the latency generated by writing to the Lucene Directory, but this operation could be processed asynchronously by a background thread.
Configurtion API {{org.infinispan.lucene.directory.BuildContext}} could allow for an optional Executor to be passed for this purpose, and if there isn't we keep current behaviour for running it synchronously.
The tricky part I guess is making sure that the tests, which verify written consistency -including delete operations - are refactored to be able to deal with the fact that delete operations will happen eventually.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (ISPN-3223) HotRod 2.0 Client recieves stale toplogy view on instance leave
by Alan Field (JIRA)
[ https://issues.jboss.org/browse/ISPN-3223?page=com.atlassian.jira.plugin.... ]
Alan Field commented on ISPN-3223:
----------------------------------
Thanks, Galder
> HotRod 2.0 Client recieves stale toplogy view on instance leave
> ---------------------------------------------------------------
>
> Key: ISPN-3223
> URL: https://issues.jboss.org/browse/ISPN-3223
> Project: Infinispan
> Issue Type: Bug
> Components: Remote Protocols
> Affects Versions: 5.2.4.Final, 5.3.0.CR1, 7.0.0.Beta1
> Reporter: Takayoshi Kimura
> Assignee: Galder Zamarreño
> Fix For: 7.0.0.Beta2, 7.0.0.Final
>
> Attachments: hr-protocol-13.log, hr-protocol-20.log
>
>
> When killed a HotRod server node, HotRod Clinet sometimes recieves a stale toplogy view which includes the dead node and uses it as a latest view. In this case the client keeps trying to connect that node and keeps failing.
> Looks like the AbstractEncoder1x.generateTopologyResponse() takes care of node join but doesn't handle node leave:
> {noformat}
> if (!serverEndpointsMap.keySet.containsAll(cacheMembers)) {
> {noformat}
> For example, serverEndpointsMap.keySet is [A, B, C] and the actual cacheMembers is [A, B].
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (ISPN-4707) On leave, Hot Rod client ends up with old cluster formation
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-4707?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-4707:
-----------------------------------
Description: In spite of that, at least with version 2.0 of the protocol, the consistent hash works fine and sends requests to remaining nodes only, without failure. On version 1.3 of the protocol, the cluster formation is updated correctly. (was: In spite of that, at least with version 2.0 of the protocol, the consistent hash works fine and sends requests to remaining nodes only, without failure.)
> On leave, Hot Rod client ends up with old cluster formation
> -----------------------------------------------------------
>
> Key: ISPN-4707
> URL: https://issues.jboss.org/browse/ISPN-4707
> Project: Infinispan
> Issue Type: Bug
> Reporter: Galder Zamarreño
> Assignee: Galder Zamarreño
> Fix For: 7.0.0.Beta2
>
> Attachments: hr-protocol-13.log, hr-protocol-20.log
>
>
> In spite of that, at least with version 2.0 of the protocol, the consistent hash works fine and sends requests to remaining nodes only, without failure. On version 1.3 of the protocol, the cluster formation is updated correctly.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months