[infinispan-issues] [JBoss JIRA] Created: (ISPN-468) Wrap any log calls in Memcached/HotRod servers around if enabled calls

Wrap any log calls in Memcached/HotRod servers around if enabled calls ---------------------------------------------------------------------- Key: ISPN-468 URL: https://jira.jboss.org/browse/ISPN-468 Project: Infinispan Issue Type: Task Components: Cache Server Affects Versions: 4.1.0.BETA1 Reporter: Galder Zamarreno Assignee: Galder Zamarreno Fix For: 4.1.0.CR1 While profiling Hot Rod, I keep seeing time being spend in these: 2.3% - 25,569 ms - 140,862 inv. scala.LowPriorityImplicits.genericWrapArray (line\: 56) ... 2.2% - 24,713 ms - 140,862 inv. scala.LowPriorityImplicits.genericWrapArray (line\: 231) These appear to come from trying to create arrays when for log messages, i.e.: trace("Decoded header {0}", header) trace method definition: def trace(msg: => String, params: Any*) = if (log.isTraceEnabled) log.trace(msg, params.map(_.asInstanceOf[AnyRef]) : _*) So, change all trace calls to be protected by "if (log.isTraceEnabled)" to avoid wasteful creation of arrays. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira