[resteasy-commits] [resteasy/Resteasy] b2fa35: [RESTEASY-1341] (#937)

Branch: refs/heads/master Home: https://github.com/resteasy/Resteasy Commit: b2fa353bcc4fec641d6644f9980621fc5a1b0711 https://github.com/resteasy/Resteasy/commit/b2fa353bcc4fec641d6644f998062... Author: NicoNes <nicolas.nesmon(a)gmail.com&gt; Date: 2016-09-30 (Fri, 30 Sep 2016) Changed paths: A jaxrs/resteasy-client/src/test/java/org/jboss/resteasy/test/internal/ClientInvocationBuilderTest.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/AsynchronousInvoke.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/ClientInvocation.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/ClientInvocationBuilder.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/ClientWebTarget.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/proxy/ClientInvoker.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/proxy/processors/FormProcessor.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/proxy/processors/InvocationProcessor.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/proxy/processors/invocation/AbstractInvocationCollectionProcessor.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/proxy/processors/invocation/CookieParamProcessor.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/proxy/processors/invocation/FormParamProcessor.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/proxy/processors/invocation/HeaderParamProcessor.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/proxy/processors/invocation/MessageBodyParameterProcessor.java M resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/internal/proxy/processors/invocation/URIParamProcessor.java M resteasy-jaxrs/src/main/java/org/jboss/resteasy/specimpl/LinkBuilderImpl.java M resteasy-jaxrs/src/main/java/org/jboss/resteasy/specimpl/LinkImpl.java M resteasy-jaxrs/src/main/java/org/jboss/resteasy/specimpl/ResteasyUriBuilder.java A testsuite/integration-tests/src/test/java/org/jboss/resteasy/test/client/ClientInvocationBuilderTest.java Log Message: ----------- [RESTEASY-1341] (#937) * According to the documentation UriBuilder.resolveTemplateXXX(...) methods must return the updated builder instance not a new one. Signed-off-by: Nicolas NESMON <nicolas.nesmon(a)gmail.com&gt; * Make ClientInvocationBuilder consitent with common Builder pattern. * Make LinkBuilderImpl consitent with common Builder pattern Signed-off-by: Nicolas NESMON <nicolas.nesmon(a)gmail.com&gt; * According to the specification Link.getParams() must return an immutable map. Signed-off-by: Nicolas NESMON <nicolas.nesmon(a)gmail.com&gt; * Make deeper copy of headers map so that parent clientInvocation and it's child do not share any common list from the MultivaluedMap headers. Signed-off-by: Nicolas NESMON <nicolas.nesmon(a)gmail.com&gt; * Add unit tests for ClientInvocationBuilder Signed-off-by: Nicolas NESMON <nicolas.nesmon(a)gmail.com&gt; * Reset entity to null value on clientInvocation instance before using it. Signed-off-by: Nicolas NESMON <nicolas.nesmon(a)gmail.com&gt; * Remove useless call to uriBuilder.clone(). Add calls to it in all resolveTemplate(...) methods in order no to alter original uriBuilder. Signed-off-by: Nicolas NESMON <nicolas.nesmon(a)gmail.com&gt; * Migrate ClientInvocationBuilderTest to new testsuite/integration-tests Signed-off-by: Nicolas NESMON <nicolas.nesmon(a)gmail.com&gt; * Let InvocationProcessor process ClientInvocation instead of ClientInvocationBuilder since in almost all processors impl ClientInvocationBuilder is used to access ClientInvocation through ClientInvocationBuilder.getInvocation(). Further more, according to the way jaxrs Invocation.Builder is designed we can't built Invocation with entity in too steps contrary to what is done in ClientInvoker.createRequest(Object[]). If invocation need to be built with an entity it must be done in one step (see build(method,entity), method(method,entity)...). Fo all those reason let's use ClientInvocation instead of ClientInvocationBuilder. Signed-off-by: Nicolas NESMON <nicolas.nesmon(a)gmail.com&gt; * Internal ClientInvocation no longer needed to be exposed through getInvocation(). Signed-off-by: Nicolas NESMON <nicolas.nesmon(a)gmail.com&gt;