[resteasy-commits] [resteasy/resteasy] cdf0c1: Use getHostName over getHostString when setting RE...

Branch: refs/heads/main Home: https://github.com/resteasy/resteasy Commit: cdf0c131894433cb9ee3c48d146aa9c075ae0d64 https://github.com/resteasy/resteasy/commit/cdf0c131894433cb9ee3c48d146aa... Author: Samuel Cox <sacox(a)paypal.com&gt; Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M server-adapters/resteasy-reactor-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ReactorNettyJaxrsServer.java M server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/plugins/server/reactor/netty/UriInfoTest.java Log Message: ----------- Use getHostName over getHostString when setting RE's URI object. We want to make a greater effort at capturing the actual hostname used by the client. Commit: e095b1db434463b01763d86b1dd1a9d3ebc8d108 https://github.com/resteasy/resteasy/commit/e095b1db434463b01763d86b1dd1a... Author: Samuel Cox <crankydillo(a)gmail.com&gt; Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/test/NettyTest.java Log Message: ----------- Remove a stale comment. Commit: 08c3f7bdfff2e48e306ef738aa93ad7c128145a1 https://github.com/resteasy/resteasy/commit/08c3f7bdfff2e48e306ef738aa93a... Author: Samuel Cox <crankydillo(a)gmail.com&gt; Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M server-adapters/resteasy-reactor-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ReactorNettyJaxrsServer.java M server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/plugins/server/reactor/netty/UriInfoTest.java M server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/test/HeaderEmptyHostTest.java Log Message: ----------- The request URI should be governed by the client, which means we need to read it from the Host header. Not sure why we didn't just copy what the other adapters did. Honestly, some of that should probably be abstracted _if_ reading from Host header is truly the right thing to do. I _think_ we shied away from this because it felt wrong to return 'unknown'. While that still feels wrong, I'm not sure what is a better option, so copying. I briefly thought about returning the IP address, which is what was happening before this effort to _not_ return the IP address! Commit: 147846e9ca569fbe403adb1600a8c122c69de6ac https://github.com/resteasy/resteasy/commit/147846e9ca569fbe403adb1600a8c... Author: Samuel Cox <crankydillo(a)gmail.com&gt; Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M server-adapters/resteasy-reactor-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ReactorNettyJaxrsServer.java M server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/plugins/server/reactor/netty/UriInfoTest.java R server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/test/HeaderEmptyHostTest.java Log Message: ----------- Use the IP address if the Host header is invalid. Commit: 26630881f8a1572887a14dbe0edc16cc96e05724 https://github.com/resteasy/resteasy/commit/26630881f8a1572887a14dbe0edc1... Author: Samuel Cox <crankydillo(a)gmail.com&gt; Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M server-adapters/resteasy-reactor-netty/pom.xml M server-adapters/resteasy-reactor-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ReactorNettyJaxrsServer.java M server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/plugins/server/reactor/netty/UriInfoTest.java Log Message: ----------- Throw IllegalArgumentException if the host address cannot be extracted.. from the request. We discussed 'asserting' here. Maybe that is the best way. I just haven't seen anyone do that in quite a while. Commit: 946c998526fad2b121d0f7b64ec089e9eabeaebe https://github.com/resteasy/resteasy/commit/946c998526fad2b121d0f7b64ec08... Author: Samuel Cox <crankydillo(a)gmail.com&gt; Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/plugins/server/reactor/netty/UriInfoTest.java Log Message: ----------- Remove an empty comment. Commit: 8a226379884cefc9dcc23cc1258b6ad19eeb4d75 https://github.com/resteasy/resteasy/commit/8a226379884cefc9dcc23cc1258b6... Author: James R. Perkins <jperkins(a)redhat.com&gt; Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/plugins/server/reactor/netty/UriInfoTest.java Log Message: ----------- [RESTEASY-3261] Fix the UriInfoTest. https://issues.redhat.com/browse/RESTEASY-3261 Signed-off-by: James R. Perkins <jperkins(a)redhat.com&gt; Commit: 8583e25ac97129d8225f55b4af10b1fc9c1fd1a1 https://github.com/resteasy/resteasy/commit/8583e25ac97129d8225f55b4af10b... Author: James R. Perkins <jperkins(a)redhat.com&gt; Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M server-adapters/resteasy-reactor-netty/pom.xml M server-adapters/resteasy-reactor-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ReactorNettyJaxrsServer.java M server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/plugins/server/reactor/netty/UriInfoTest.java R server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/test/HeaderEmptyHostTest.java M server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/test/NettyTest.java Log Message: ----------- Merge pull request #3360 from jamezp/RESTEASY-3261 Use the request's Host header when setting RE's URI object. Compare: https://github.com/resteasy/resteasy/compare/9bf9c82885f6...8583e25ac971