Max and Min content size predicates are implemented backwards
by Brad Wood
These two predicates from undertow are named/implemented backwards. The
"max" should be ensuring the provided value is at least *as small or
smaller* and the "min" should be ensuring the provided value is at least *as
big or bigger*. But here are the descriptions of each one.
*MinContentSizePredicate*
> Predicate that returns true if the Content-Size of a request is below a
> given value.
*MaxContentSizePredicate*
> Predicate that returns true if the Content-Size of a request is above a
> given value.
So to spell it out, if someone uses the following predicate:
max-content-size(5)
That means they are saying the maximum content size is 5 bytes. So, here's
a quick truth table:
- If content length is *4 bytes *-> should return *true *(under the max)
- if content length is *5 bytes *-> should return *true *(at the max,
but not over)
- if content length is *6 bytes *-> should return *false *(over the max)
But this is the exact opposite of how these predicates have been
implemented. The javadoc matches the behavior, but not the name.
Can I get a quick confirmation this is, in fact, backwards before I enter a
ticket and/or pull request. Note, this will be a breaking change to fix.
Thanks!
~Brad
*Developer Advocate*
*Ortus Solutions, Corp *
E-mail: brad(a)coldbox.org
ColdBox Platform: http://www.coldbox.org
Blog: http://www.codersrevolution.com
5 years, 8 months
swagger in undertow
by David Robinson
Is there a way to add Swagger into an undertow based server? Here is how I
start my server now - standard stuff:
------
RoutingHandler rh0 = new RoutingHandler()
.post("/bb/{cohort}/{topictype}", new
UniversalPostHttpHandler(kep, kvemp))
.get("/bb/{cohort}/{topictype}/schema", new UniversalGetHttpHandler())
.get("/admin/healthcheck", new
UniversalHealthCheckHttpHandler())
.get("/admin/metrics", new
UndertowGetMetricHttpHelperHandler())
Undertow server = Undertow.builder().setIoThreads(undertowIoThreads
).addHttpListener(ipPort, ipAddress).setHandler(rh0).build();
------
Ideally, swagger could just be added as another handler of sorts.
I ran across this post, which is over a year old, which is unanswered:
https://stackoverflow.com/questions/54685819/swagger-undertow
Appreciate any advice on how to do this.
Thanks,
5 years, 8 months
Exchange complete listener doesn't fire if exchange is ended
by Brad Wood
I have a basic exchange listener configured for testing that simply logs at
the end of each request something like
exchange.addExchangeCompleteListener((httpServerExchange, nextListener) -> {
if (httpServerExchange.getStatusCode() > 399) {
CONTEXT_LOG.warnf("responded: Status Code %s (%s)",
httpServerExchange.getStatusCode(), fullExchangePath(httpServerExchange));
}
nextListener.proceed();
});
This works great, but if the exchange is ended-- for example using the
response-code handler-- then the exchange complete listener never fires.
Is this working as designed?
Thanks!
~Brad
*Developer Advocate*
*Ortus Solutions, Corp *
E-mail: brad(a)coldbox.org
ColdBox Platform: http://www.coldbox.org
Blog: http://www.codersrevolution.com
5 years, 8 months
