11:57 a.m.
Hello
With Java 11 Flight Recorder is now part of OpenJDK 11 [1], Open Source
and free to use. I hacked something together how Undertow could
integrate with this [2]. This can become quite powerful as you can track
down what events happened during processing of that HTTP exchange. It
becomes even more powerful once other components (database, caching)
also generate events and you can correlate them.
I wanted to ask whether it makes any sense to upstream this? Obviously
it will always have to be optional as it only works with OpenJDK 11+ and
there is a small runtime overhead.
I have to say that I am not super familiar with the Flight Recorder API.
For example I am not sure when an event is started in one thread but
completed in an other thread whether that needs to be handled specially.
I am not sure whether this could happen for async servlet.
Also I am not sure whether the ExchangeCompleteListener is called if
handleRequest on the next HttpHandler throws an exception.
[1] https://openjdk.java.net/jeps/328
[2] https://github.com/marschall/undertow-jfr
Cheers
Philippe
1:47 a.m.
On Sun, Dec 9, 2018 at 9:58 PM Philippe Marschall <kustos(a)gmx.net> wrote:
Hello
With Java 11 Flight Recorder is now part of OpenJDK 11 [1], Open Source
and free to use. I hacked something together how Undertow could
integrate with this [2]. This can become quite powerful as you can track
down what events happened during processing of that HTTP exchange. It
becomes even more powerful once other components (database, caching)
also generate events and you can correlate them.
I wanted to ask whether it makes any sense to upstream this? Obviously
it will always have to be optional as it only works with OpenJDK 11+ and
there is a small runtime overhead.
I don't know if this would be worth it at the moment, as this would mean
that Undertow would require JDK11 to build. It does look like a useful
handler though. The next major version of Undertow is likely to require
JDK11, so maybe we could consider it then.
The runtime overhead is not really an issue as handlers are all optional.
I have to say that I am not super familiar with the Flight Recorder API.
For example I am not sure when an event is started in one thread but
completed in an other thread whether that needs to be handled specially.
I am not sure whether this could happen for async servlet.
This can definitely happen, even for non-async servlet, as the request
starts in the IO thread and finishes in a worker thread.
Also I am not sure whether the ExchangeCompleteListener is called if
handleRequest on the next HttpHandler throws an exception.
ExchangeCompletionListener is always called.
Stuart
[1] https://openjdk.java.net/jeps/328
[2] https://github.com/marschall/undertow-jfr
Cheers
Philippe
_______________________________________________
undertow-dev mailing list
undertow-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/undertow-dev
10:21 p.m.
On 11.12.18 01:47, Stuart Douglas wrote:
On Sun, Dec 9, 2018 at 9:58 PM Philippe Marschall
<kustos(a)gmx.net> wrote:
....
I don't know if this would be worth it at the moment, as this would mean
that Undertow would require JDK11 to build.
Yes, it was a commercial feature on before 11 and the API changed from 8
to 9.
It does look like a useful
handler though. The next major version of Undertow is likely to require
JDK11, so maybe we could consider it then.
Sure, I just wanted to bring it up. It can be maintained outside of the
project without any issues.
...
This can definitely happen, even for non-async servlet, as the request
starts in the IO thread and finishes in a worker thread.
Is there a way to register a listener when a request gets scheduled and
unscheduled from a thread?
Cheers
Philippe
1:46 a.m.
On Wed, Dec 12, 2018 at 8:21 AM Philippe Marschall <kustos(a)gmx.net> wrote:
On 11.12.18 01:47, Stuart Douglas wrote:
> On Sun, Dec 9, 2018 at 9:58 PM Philippe Marschall <kustos(a)gmx.net>
wrote:
> ....
>
> I don't know if this would be worth it at the moment, as this would mean
> that Undertow would require JDK11 to build.
Yes, it was a commercial feature on before 11 and the API changed from 8
to 9.
> It does look like a useful
> handler though. The next major version of Undertow is likely to require
> JDK11, so maybe we could consider it then.
Sure, I just wanted to bring it up. It can be maintained outside of the
project without any issues.
> ...
>
> This can definitely happen, even for non-async servlet, as the request
> starts in the IO thread and finishes in a worker thread.
Is there a way to register a listener when a request gets scheduled and
unscheduled from a thread?
If you only care about Servlet you can
use io.undertow.servlet.api.ThreadSetupHandler, other that this we don't
really have the concept of dispatch listeners that you would need to
implement this for the general case.
Stuart
Cheers
Philippe
1960
days inactive
1964
days old
3 comments
2 participants
participants (2)
-
Philippe Marschall -
Stuart Douglas