August 2011 - weld-issues - Jboss List Archives

[JBoss JIRA] Created: (WELD-793) Make bootstrap more granular

by Pete Muir (JIRA)

Make bootstrap more granular ---------------------------- Key: WELD-793 URL: https://issues.jboss.org/browse/WELD-793 Project: Weld Issue Type: Feature Request Affects Versions: 1.1.0.CR1 Reporter: Pete Muir Priority: Blocker Fix For: 1.2.0.Beta1 Currently the bootstrap is fairly coarse grained, not allowing the container to "skip" parts of bootstrap if it can provide the information externally. The primary goal here is to allow the container to skip the the bootstrap up until after all ProcessAnnotatedType events have been sent, and the modified class metadata has been built. My proposal for this is to introduce a new method to bootstrap that passes in a map of BDA->AnnotatedType that Weld can use to boot. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 6 months

3
6
0 / 0

[JBoss JIRA] Created: (WELD-921) Incorrect handling of business interfaces for EJBs (where defining class of business method is not the Business interface of the EJBs)

by Sivakumar Thyagarajan (JIRA)

Incorrect handling of business interfaces for EJBs (where defining class of business method is not the Business interface of the EJBs) --------------------------------------------------------------------------------------------------------------------------------------- Key: WELD-921 URL: https://issues.jboss.org/browse/WELD-921 Project: Weld Issue Type: Bug Components: Weld SPI Affects Versions: 1.1.1.Final, 1.1.0.Final Reporter: Sivakumar Thyagarajan Fix For: 1.1.2.Final This is based on the scenario described in http://java.net/jira/browse/GLASSFISH-16186 - @Named @Stateless TimeProviderImpl extends SimpleTimeProvider implements LocalTimeProvider. - SimpleTimeProvider implements TimeProvider (the latter defining some methods, the former implementing them. No annotations.) - LocalTimeProvider is @Local and also extends TimeProvider and does nothing more. So the Local Business interface is LocalTimeProvider. The following injection is performed on a SessionScoped Bean @Inject private LocalTimeProvider timeProvider1; The Weld bean proxy for the SessionBean Object reference being injected(timeProvider1) tries to get [1] the BusinessObject when a method is invoked on it. Weld seems to use [2] the declaring class of the method being invoked to determine the business interface. Though the business interface of the Bean is set to com.dummy.time.LocalTimeProvider, the class that declares the method being invoked ("getThisMonth()") is com.dummy.time.TimeProvider. Therefore, the Weld implementation calls SessionObjectReferenceImpl.getBusinessObject("com.dummy.time.TimeProvider"), which fails, as TimeProvider is not a Business interface. As per [3], the businessInterfaceType must be a type of the business interface of the bean. Is Weld incorrect in mapping the method to its declaring interface. Weld must instead use the injected type as the business interface, while trying to get the business object. [1] https://github.com/weld/core/blob/76c31d311cf1ff449eb2d5c80943b913651bed9... [2]https://github.com/weld/core/blob/76c31d311cf1ff449eb2d5c80943b913651be... [3] https://github.com/weld/api/blob/master/weld-spi/src/main/java/org/jboss/... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 6 months

7
12
0 / 0

[JBoss JIRA] Created: (WELD-800) Add an initializationComplete() method to BeanManagerImpl

by Pete Muir (JIRA)

Add an initializationComplete() method to BeanManagerImpl --------------------------------------------------------- Key: WELD-800 URL: https://issues.jboss.org/browse/WELD-800 Project: Weld Issue Type: Feature Request Reporter: Pete Muir Fix For: 1.2.0.Beta1 BeanManagerImpl is mutable as we need to create the object early in bootstrap and then populate it with beans etc. Currently we don't make it immutable after bootstrap, but this would be good defensive programming, and also allow us to perhaps perform some optimizations on the data structures as we know they are then immutable. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 7 months

5
7
0 / 0

[JBoss JIRA] Created: (WELD-918) interceptor binding for java interfaces/methods

by Manuel Hartl (JIRA)

interceptor binding for java interfaces/methods ----------------------------------------------- Key: WELD-918 URL: https://issues.jboss.org/browse/WELD-918 Project: Weld Issue Type: Feature Request Components: Weld SPI Affects Versions: 1.1.0.Final Environment: tomcat6 Reporter: Manuel Hartl Priority: Minor - i created an interceptor and marked an java interface class with its binding (or a method of the interface) - interception does not work on methods of beans, that implement this interface. should this work? (interceptor binding to java interfaces?) if yes: it's a bug :) if no: please update weld documentation actually, i would like to use in interfaces -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 7 months

4
7
0 / 0

[JBoss JIRA] Created: (WELD-903) Shaded Weld SE artifact includes slf4j implementation

by Christian Bauer (JIRA)

Shaded Weld SE artifact includes slf4j implementation ----------------------------------------------------- Key: WELD-903 URL: https://issues.jboss.org/browse/WELD-903 Project: Weld Issue Type: Bug Components: Java SE Support Affects Versions: 1.1.1.Final Reporter: Christian Bauer Previously fixed but probably slipped through again. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

3
3
0 / 0

[JBoss JIRA] Created: (WELD-930) Producer is made an alternative if the declaring bean class is an alternative

by Alexey Kazakov (JIRA)

Producer is made an alternative if the declaring bean class is an alternative ----------------------------------------------------------------------------- Key: WELD-930 URL: https://issues.jboss.org/browse/WELD-930 Project: Weld Issue Type: Bug Components: Producers (Methods, Fields and Disposers) Affects Versions: 1.1.0.Final Reporter: Alexey Kazakov I'm looking at examples from https://github.com/pmuir/jboss-as-developer-guide/tree/master/quickstarts There is org.jboss.as.quickstarts.login.EJBUserManager: {code:title=org.jboss.as.quickstarts.login.EJBUserManager|borderStyle=solid} ... @Named("userManager") @RequestScoped @Alternative @Stateful public class EJBUserManager implements UserManager { ... @Produces @Named @RequestScoped public List<User> getUsers() throws Exception { ... } ... } {code} And there is also another bean org.jboss.as.quickstarts.login.ManagedBeanUserManager: {code:title=org.jboss.as.quickstarts.login.ManagedBeanUserManager|borderStyle=solid} ... @Named("userManager") @RequestScoped public class ManagedBeanUserManager implements UserManager { @SuppressWarnings("unchecked") @Produces @Named @RequestScoped public List<User> getUsers() throws Exception { ... } ... } {code} This code works in Weld even if EJBUserManager.getUsers() is not annotated @Alternative. But regarding the spec such a method has an ambiguous EL name "users": {quote} 5.3.1. Ambiguous EL names An ambiguous EL name exists in an EL expression when an EL name resolves to multiple beans. When an ambiguous EL name exists, the container attempts to resolve the ambiguity. If any of the beans are alternatives, the container eliminates all beans that are not alternatives, *except for producer methods and fields of beans that are alternatives*. If there is exactly one bean remaining, the container will select this bean, and the ambiguous EL name is called resolvable. {quote} There is a comment from Pete Muir: {quote} This looks to me like a bug in Weld (one that crept in from a pre-final spec revision) - that it checks if the declaring bean class is an alternative, and if it is, makes the producer an alternative. Can you file a WELD issue for this? I'll update the quickstart to explicitly make the producer an alternative. Pete {quote} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

5
8
0 / 0

[JBoss JIRA] Created: (WELD-458) Interceptor for lifecycle callback with binding type @Target({TYPE, METHOD}) not detected as definition error

by Ondrej Skutka (JIRA)

Interceptor for lifecycle callback with binding type @Target({TYPE, METHOD}) not detected as definition error ------------------------------------------------------------------------------------------------------------- Key: WELD-458 URL: https://jira.jboss.org/jira/browse/WELD-458 Project: Weld Issue Type: Bug Components: Interceptors and Decorators Affects Versions: 1.0.1.Final Reporter: Ondrej Skutka Spec says: An interceptor for lifecycle callbacks may only declare interceptor binding types that are defined as @Target(TYPE). If an interceptor for lifecycle callbacks declares an interceptor binding type that is defined @Target({TYPE, METHOD}), the con- tainer automatically detects the problem and treats it as a definition error. org.jboss.jsr299.tck.tests.interceptors.definition.broken.interceptorForLifecycleTargetMethod.InterceptorForLifecycleTargetMethodTest In the TCK trunk -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

6
14
0 / 0

[JBoss JIRA] Created: (WELD-935) Do not deploy shaded jars like weld-servlet (as a bad replacement for weld-servlet-core) because they break dependency conflict resolution and introduce classpath issues

by Geoffrey De Smet (JIRA)

Do not deploy shaded jars like weld-servlet (as a bad replacement for weld-servlet-core) because they break dependency conflict resolution and introduce classpath issues ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Key: WELD-935 URL: https://issues.jboss.org/browse/WELD-935 Project: Weld Issue Type: Bug Affects Versions: 1.1.1.Final Reporter: Geoffrey De Smet Shading = repackaging a dependency class inside your own jar (instead of depending on the jar of that class). I've just spend quite some time trying to find such a classpath issue, which manifested it self as "NoSuchMethodError on slf4j LocationAwareLogger.log(...)" It turns out the weld-servlet jar was shading some of the slf4j classes. Shading is evil. Here's why: - It breaks maven/gradle/buildr/ivy dependency conflict resolution. If guvnor uses slf4j 1.6 and weld-servlet; and weld-servlet shades slf4J 1.5; maven will not detect a slf4j version conflict and will therefor have no chance to put only 1 version of slf4J in the classpath. As a result, there's no telling which slf4J version will be used (the first in the classpath, but that is very unstable) - It distorts ANT's classpath: putting the weld-servlet jar (with slf4J 1.5) in your classpath can effectively turn the explicit slf4j-1.6.0.jar in your classpath into dead code or combine it with binary incompatibly slf4j extensions such as xstream-for-slf4j-1.6.0.jar (fictive example). - Because the slf4j classes are actually in the weld-servlet jar, they cause bloat: the user might have already downloaded the real slf4j jar. - Most importantly, because the (Red Hat and other) guys who create RPM's out of our jars say so. See slide 13 of this Fosdem presentation: http://sochotni.fedorapeople.org/fosdem2011-sochotnicky.pdf (video : http://ia600608.us.archive.org/16/items/fosdem_2011_free_java_guide_to_pa...) Summary: shading will cause grief for your users. Why subject your users to grief? In this case, don't give them a good and a bad choice, only give them a good choice. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

3
4
0 / 0

[JBoss JIRA] Created: (WELD-769) Intercepting a method in a bean where another method is final causes a VerifyError

by Adam Warski (JIRA)

Intercepting a method in a bean where another method is final causes a VerifyError ---------------------------------------------------------------------------------- Key: WELD-769 URL: https://jira.jboss.org/browse/WELD-769 Project: Weld Issue Type: Bug Components: Proxies Affects Versions: 1.1.0.Beta2 Reporter: Adam Warski Used to work fine until AS6 CR1 (tested in M2 and M4). Stack trace: org.jboss.arquillian.impl.event.FiredEventException: java.lang.RuntimeException: Could not inject members at org.jboss.arquillian.impl.event.MapEventManager.fire(MapEventManager.java:68) at org.jboss.arquillian.impl.context.AbstractEventContext.fire(AbstractEventContext.java:115) at org.jboss.arquillian.impl.EventTestRunnerAdaptor.before(EventTestRunnerAdaptor.java:97) at org.jboss.arquillian.testng.Arquillian.arquillianBeforeTest(Arquillian.java:89) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.testng.internal.MethodHelper.invokeMethod(MethodHelper.java:644) at org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:443) at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:160) at org.testng.internal.Invoker.invokeMethod(Invoker.java:494) at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:700) at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1002) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:137) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:121) at org.testng.TestRunner.runWorkers(TestRunner.java:908) at org.testng.TestRunner.privateRun(TestRunner.java:617) at org.testng.TestRunner.run(TestRunner.java:498) at org.testng.SuiteRunner.runTest(SuiteRunner.java:329) at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:324) at org.testng.SuiteRunner.privateRun(SuiteRunner.java:296) at org.testng.SuiteRunner.run(SuiteRunner.java:201) at org.testng.TestNG.createAndRunSuiteRunners(TestNG.java:915) at org.testng.TestNG.runSuitesLocally(TestNG.java:879) at org.testng.TestNG.run(TestNG.java:787) at org.testng.remote.RemoteTestNG.run(RemoteTestNG.java:75) at org.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:92) Caused by: java.lang.RuntimeException: Could not inject members at org.jboss.arquillian.testenricher.cdi.CDIInjectionEnricher.injectClass(CDIInjectionEnricher.java:103) at org.jboss.arquillian.testenricher.cdi.CDIInjectionEnricher.enrich(CDIInjectionEnricher.java:52) at org.jboss.arquillian.impl.handler.TestCaseEnricher.callback(TestCaseEnricher.java:42) at org.jboss.arquillian.impl.handler.TestCaseEnricher.callback(TestCaseEnricher.java:32) at org.jboss.arquillian.impl.event.MapEventManager.fire(MapEventManager.java:63) ... 27 more Caused by: org.jboss.weld.exceptions.DeploymentException: by java.lang.VerifyError: class pl.softwaremill.weldbugs.bug2.org$jboss$weld$bean-1ed4ae51-6ceb-40b2-899a-ed6d1f90409e$jar-ManagedBean-class_pl$softwaremill$weldbugs$bug2$TestBean2_$$_WeldProxy overrides final method someMethod.()V at org.jboss.weld.bean.ManagedBean.applyInterceptors(ManagedBean.java:569) at org.jboss.weld.bean.ManagedBean$ManagedBeanInjectionTarget.produce(ManagedBean.java:250) at org.jboss.weld.bean.ManagedBean.create(ManagedBean.java:332) at org.jboss.weld.context.unbound.DependentContextImpl.get(DependentContextImpl.java:59) at org.jboss.weld.manager.BeanManagerImpl.getReference(BeanManagerImpl.java:669) at org.jboss.weld.manager.BeanManagerImpl.getReference(BeanManagerImpl.java:743) at org.jboss.weld.injection.FieldInjectionPoint.inject(FieldInjectionPoint.java:137) at org.jboss.weld.util.Beans.injectBoundFields(Beans.java:869) at org.jboss.weld.util.Beans.injectFieldsAndInitializers(Beans.java:881) at org.jboss.weld.manager.SimpleInjectionTarget$1.proceed(SimpleInjectionTarget.java:122) at org.jboss.weld.injection.InjectionContextImpl.run(InjectionContextImpl.java:54) at org.jboss.weld.manager.SimpleInjectionTarget.inject(SimpleInjectionTarget.java:116) at org.jboss.arquillian.testenricher.cdi.CDIInjectionEnricher.injectNonContextualInstance(CDIInjectionEnricher.java:113) at org.jboss.arquillian.testenricher.cdi.CDIInjectionEnricher.injectClass(CDIInjectionEnricher.java:93) ... 31 more Caused by: org.jboss.weld.exceptions.WeldException: by java.lang.VerifyError: class pl.softwaremill.weldbugs.bug2.org$jboss$weld$bean-1ed4ae51-6ceb-40b2-899a-ed6d1f90409e$jar-ManagedBean-class_pl$softwaremill$weldbugs$bug2$TestBean2_$$_WeldProxy overrides final method someMethod.()V at org.jboss.weld.bean.proxy.ProxyFactory.getProxyClass(ProxyFactory.java:268) at org.jboss.weld.bean.proxy.ProxyFactory.create(ProxyFactory.java:198) at org.jboss.weld.bean.ManagedBean.applyInterceptors(ManagedBean.java:564) ... 44 more Caused by: javassist.CannotCompileException: by java.lang.VerifyError: class pl.softwaremill.weldbugs.bug2.org$jboss$weld$bean-1ed4ae51-6ceb-40b2-899a-ed6d1f90409e$jar-ManagedBean-class_pl$softwaremill$weldbugs$bug2$TestBean2_$$_WeldProxy overrides final method someMethod.()V at org.jboss.weld.util.bytecode.ClassFileUtils.toClass(ClassFileUtils.java:117) at org.jboss.weld.bean.proxy.ProxyFactory.createProxyClass(ProxyFactory.java:376) at org.jboss.weld.bean.proxy.ProxyFactory.getProxyClass(ProxyFactory.java:264) ... 46 more Caused by: java.lang.VerifyError: class pl.softwaremill.weldbugs.bug2.org$jboss$weld$bean-1ed4ae51-6ceb-40b2-899a-ed6d1f90409e$jar-ManagedBean-class_pl$softwaremill$weldbugs$bug2$TestBean2_$$_WeldProxy overrides final method someMethod.()V at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClassCond(ClassLoader.java:632) at java.lang.ClassLoader.defineClass(ClassLoader.java:616) at java.lang.ClassLoader.defineClass(ClassLoader.java:466) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.jboss.weld.util.bytecode.ClassFileUtils.toClass2(ClassFileUtils.java:143) at org.jboss.weld.util.bytecode.ClassFileUtils.toClass(ClassFileUtils.java:109) ... 48 more -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

5
11
0 / 0

[JBoss JIRA] Created: (WELD-920) Memory leak through the creational context of an @AppScoped bean when injecting Instance<>

by Adam Warski (JIRA)

Memory leak through the creational context of an @AppScoped bean when injecting Instance<> ------------------------------------------------------------------------------------------ Key: WELD-920 URL: https://issues.jboss.org/browse/WELD-920 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.1.1.Final, 1.1.0.CR3 Reporter: Adam Warski Given a simple dependent-scoped bean: public class InstanceBean {}, and an application-scoped bean (see below) to which an instance of the dependent-scoped bean is injected, each time the get() method is called on the instance, even though it's not used, a reference to it stays in the creational context of the application scoped bean (http://screencast.com/t/XqjQ1GB7Wv3). That way after several requests, where each one calls the method, more and more memory is leaked (http://screencast.com/t/s1VBx49i). Attached is a simple web application demonstrating this. To reproduce, deploy to AS6, click the "leak" button several times, and analyze the heap dump e.g. in JProfiler. @ApplicationScoped @Named("test") public class AppScopedBean { private Instance<InstanceBean> instanceBeanInstance; @Inject public AppScopedBean(Instance<InstanceBean> instanceBeanInstance) { this.instanceBeanInstance = instanceBeanInstance; } public AppScopedBean() { } public void leakOneInstance() { System.out.println("Leaked!"); instanceBeanInstance.get(); } } -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

5
17
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

weld-issues August 2011