Separating things also means that the eventual fix PR probably isn't going
to have the test. So it can either get merged without the test (bad) or the
people doing merging are misusing their time coordinating combined testing
of two PRs.
On Tue, Apr 17, 2018 at 8:11 PM, Stuart Douglas <stuart.w.douglas(a)gmail.com>
Historically we have been ok with pull requests being submitted that add
tests for things that are not yet complete.
In practice this has been kinda problematic for reviewers, as these pull
requests can hang around for a long time, and this ends up wasting a lot of
reviewer time as we have to continually check the status of the PR. You
basically end up with multiple reviewers continually polling the issue to
check if it is ready, instead of a single person just submitting it when it
I think that there is no real benefit to having the tests as a seperate PR
that gets opened before the fix. Instead I propose that tests that do not
pass yet are linked/co-ordinated under the relevant JIRA, and when the fix
is submitted the tests can be submitted as part of the same PR.
Does anyone have any objections to this?
wildfly-dev mailing list
Manager, Senior Principal Software Engineer