Re: [wildfly-dev] New Year's Eve bug broke the build

I have to agree with David on this one. It’s fine to use actual dates and timezones. It’s bad to have the time the test as ran be an input into the test. On Jan 2, 2014, at 1:04 PM, Eduardo Martins <emartins(a)redhat.com&gt; wrote: > IMO it’s good to use actual dates and timezones, this way we may get bugs that only show with specific dates ;-) > > Anyway, the PR is merged, it should not be an issue anymore. > > —E > > On 02 Jan 2014, at 19:02, David M. Lloyd <david.lloyd(a)redhat.com&gt; wrote: > >> We should not be relying on the current date/calendar to change the >> outcome of any test. We should be using some type of "pre-cooked" clock >> which is set to specific test dates for these tests in particular. >> >> On 12/31/2013 09:46 AM, Cheng Fang wrote: >>> Feel free to tackle it. >>> >>> Cheng >>> >>> On 12/31/13, 10:14 AM, Eduardo Martins wrote: >>>> Will you work on it? If not please let me know and I will take over. >>>> >>>> —E >>>> >>>> On 31 Dec 2013, at 15:02, Cheng Fang <cfang(a)redhat.com&gt; wrote: >>>> >>>>> Looks similar to https://issues.jboss.org/browse/JBCTS-1253 (ejb3 timer >>>>> failures at end of month) on a yearly scale. >>>>> >>>>> Cheng >>>>> >>>>> On 12/31/13, 9:34 AM, Eduardo Martins wrote: >>>>>> Yet this already shown up yesterday, so not sure it’s due to new year, is anyone looking at it please reply, otherwise I will have a look at it. >>>>>> >>>>>> —E >>>>>> >>>>>> On 31 Dec 2013, at 14:30, Eduardo Martins <emartins(a)redhat.com&gt; wrote: >>>>>> >>>>>>> Same at my end. >>>>>>> >>>>>>> —E >>>>>>> >>>>>>> >>>>>>> On 31 Dec 2013, at 02:17, ssilvert(a)redhat.com wrote: >>>>>>> >>>>>>>> https://github.com/wildfly/wildfly/pull/5653 >>>>>>>> >>>>>>>> I'm not sure if this is a bug in the test or a bug in >>>>>>>> org.jboss.as.ejb3.timerservice.schedule.CalendarBasedTimeout. But I'm >>>>>>>> pretty sure that the build will be working again in a few hours. >>>>>>>> >>>>>>>> Happy New Year! >>>>>>>> _______________________________________________ >>>>>>>> wildfly-dev mailing list >>>>>>>> wildfly-dev(a)lists.jboss.org >>>>>>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev >>>>>>> _______________________________________________ >>>>>>> wildfly-dev mailing list >>>>>>> wildfly-dev(a)lists.jboss.org >>>>>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev >>>>>> _______________________________________________ >>>>>> wildfly-dev mailing list >>>>>> wildfly-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev >>>>> _______________________________________________ >>>>> wildfly-dev mailing list >>>>> wildfly-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev >>> >>> _______________________________________________ >>> wildfly-dev mailing list >>> wildfly-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/wildfly-dev >>> >> >> >> -- >> - DML >> _______________________________________________ >> wildfly-dev mailing list >> wildfly-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/wildfly-dev > > > _______________________________________________ > wildfly-dev mailing list > wildfly-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/wildfly-dev -- Jason T. Greene WildFly Lead / JBoss EAP Platform Architect JBoss, a division of Red Hat _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev