Re: [wildfly-dev] Calling attention to two security bugs in WildFly

Hi, On Thu, May 7, 2015 at 9:55 PM, Stefan Guilhen <sguilhen(a)redhat.com&gt; wrote: 876 indeed seemed wrong in PicketBox, I'm not sure what I was thinking back then. As I think the problem wasn't even JASPIC specific, I filed a new issue in Undertow which Stuart then moved to WildFly, where it's now at: https://issues.jboss.org/browse/WFLY-4602 I think it finally has found the right place ;) Yes I know, although it's maybe extra confusing that when the EJB is not protected (doesn't use the implicit interceptor for @RolesAllowed), but does use the security machinery manually (via the ejb context), then the authenticated identity that was established in the web layer is available to the EJB bean. Indeed, in those cases the web layer has an authentication mechanism defined (e.g. Servlet's FORM) that always delegates to what we call an "identity store" in the security EG (which is roughly a JAAS login module). EJB doesn't have the authentication mechanism concept, and only uses the "identity store". Effectively the problem is still there though, as you have to make sure as a developer that the web and ejb layers use the same domain/module, plus you don't really want to re-authenticate for every call to every secured EJB all the time. JBoss works around this problem by using an authentication cache. So effectively you could perhaps say that with the proprietary JAAS based domains the identity does propagate, via the cache. I think it rarely happens that the JAAS module is indeed called following a call from a Servlet to an EJB as it almost always hits the cache (before JASPIC I used the JBoss specific JAAS modules for a long time). This solution that Anil had back then is still something that's worth investigating today. A JASPIC module is indeed not required to delegate to an "identity store", but it would be great if there was a standard mechanism to configure that it should do that and a means for the container to see that this configuration is in place. There's the JASPIC bridge profile that somewhat says something about this, but I'm not sure that this would work here. Another thing to consider is that in modern Java EE programming EJB beans are often just local and very simple beans that are even put directly in the war. Mentally there is no "web layer" or "ejb layer" in the sense as there once was when remote EJBs and separate EJB modules where more the norm. Well, it sounds like a very obvious and straightforward solution. Just wondering, but did you ever check how some other other servers do this? As far as I know almost all of them automatically propagate the context from a Servlet to an EJB bean (at least GlassFish, WebLogic and Geronimo do this for sure). Kind regards, Arjan Tijms