Just a random idea. Can we block merging pull requests if they contain a TODO comment that don't reference a Jira issue? The views in GitHub are easy to see if a TODO is involved so quite simple to double check - and if no Jira is justified maybe the TODO isn't either. Regards, Darran Lofthouse. _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev

I'm just thinking out laud - perhaps it would be better to add some rules to checkstyle plugin? This way all commits would have to obey this kind of coding standards. Of course there are some drawbacks... we'd need to fix all violations in existing code base. But this also may be considered as a something good :)

Best regards Sebastian 2014-07-30 22:03 GMT+02:00 Anil Saldhana <Anil.Saldhana(a)redhat.com <mailto:Anil.Saldhana@redhat.com>>: Darran - very good suggestion. Also, don't merge if there is no javadoc on public methods and classes. :-) On 07/30/2014 02:46 PM, Darran Lofthouse wrote: > Just a random idea. > > Can we block merging pull requests if they contain a TODO comment that > don't reference a Jira issue? > > The views in GitHub are easy to see if a TODO is involved so quite > simple to double check - and if no Jira is justified maybe the TODO > isn't either. > > Regards, > Darran Lofthouse. > _______________________________________________ > wildfly-dev mailing list > wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/wildfly-dev _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/wildfly-dev -- Sebastian Łaskawiec _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev