Re: [forge-dev] [JBoss JIRA] Closed: (SEAMFORGE-64) add-repository should offer a built-in list of known repositories

Well, technically speaking, using toString() sounds like it would make the enums type insensitive. And that would lead to its own problems, no? It sounds like the solution would be to provide lowercased enum constants in this case (should we decide to "step down" the casing ;)

Thoughts? On Wed, Mar 16, 2011 at 7:07 AM, Max Rydahl Andersen <max.andersen(a)redhat.com&gt; wrote: On Mar 16, 2011, at 06:20, Lincoln Baxter, III wrote: > > Enums have a to string method one use to make them look less ancient. > > I actually find the uppercase printout makes them stand out as option values more than they do as plain text You do autocomplete - the options are what is there...no matter if its lowercase or uppercase. > , but also, using the toString() name might make it more difficult to convert back to the object. if the tostring is just the lowercased version its not going to be hard ;) > > Btw. Aren't enums static and thus bad for something like expandable lists ? > > Most of the lists you're seeing aren't expandable :) Because they are enums ? :P List of known repositories sounds like something you would like to expand on and not have limited to specific list.... same with many options IMO. > But what in specific are your concerns with this? I may have missed something important. 1) It looks UGLY 2) I have to type capital letters to get the matching options - unless seam forge becomes case insensitive but then you have problems with file matching on most OS's 3) it looks like Seam Forge is SHOUTING at me /max http://about.me/maxandersen -- Lincoln Baxter, III http://ocpsoft.com http://scrumshark.com "Keep it Simple"