Hey guys,
I have uploaded my changes. One commit to the forge/core and another
one to the forge/undo-plugin:
forge-git-tools is now using jgit-2.0. I added a bunch of trivial
methods, the idea is to have one place responsible for the execution
of the git commands. Furthermore, I plan to remove 'throws' from
method declarations in the future and replace them with try-catch
blocks in order to minimize the number of methods outside of
forge-git-utils with dependencies on jgit.
All the tests pass but I am still unable to install and test the plugin locally.
There is one git-related issue. If I remove git-add-all routine in
tests (e.g. UndoFacetTest.java:170-172), I get an IOException during
execution of "stashApply()" method in the updateHistoryBranch(). I
don't know what's causing it now, because undo routine should also
work on repositories containing uncommitted files as well.
Cheers,
Jevgeni
On Thu, Jun 28, 2012 at 10:41 PM, Lincoln Baxter, III
<lincolnbaxter(a)gmail.com> wrote:
Yes, please upload it :) You don't need to worry, we aren't
mean, and you
write really nice code.
Also... it won't be in the repository until we add it there, but more people
will see it and be able to review.
I'm not exactly sure what the problem is, so I'd like to try it myself!
Thanks!
~Lincoln
On Thu, Jun 28, 2012 at 2:18 PM, Jevgeni Zelenkov
<jevgeni.zelenkov(a)gmail.com> wrote:
>
> Ryan and Lincoln,
>
> Thanks for your feedback. I tried a number of different package
> combinations, including 'org.jboss.undo.forge.UndoFacet' but I still
> get the same error.
>
> Lincoln, the plugin is pretty much untested so I don't feel
> comfortable uploading potentially broken plugin (even as an
> intermediate commit). If you really think it's OK, I'll do it. Also, I
> will have to upload my changes to forge-git-tools.
>
> Cheers,
> Jevgeni
>
>
> On Thu, Jun 28, 2012 at 6:22 PM, Ryan Bradley <rbradley(a)redhat.com> wrote:
> > Jevgeni,
> >
> > I'm not sure if this is the same problem that you have, but a while ago
> > I had some problems regarding facets being loaded.
> >
> > I assume that your UndoFacet (interface and implementation) are in the
> > same project that you are executing 'forge source plugin' on, if they
> > aren't, then they should be (or you will need to run 'mvn clean
install'
> > to add those JARs to your local Maven repo).
> >
> > As well, I had problems using the group ID 'org.jboss.forge'. Any
> > dependencies in my plugin with this group ID were assumed to be part of
> > the core, and Forge would mark these as scope provided and cause some
> > problems.
> >
> > Once again, I don't think these problems should occur if UndoFacet and
> > its implementation are in the same project as UndoPlugin, but just an
> > idea of something to look for.
> >
> > Cheers,
> > Ryan
> >
> > On 06/28/2012 12:01 PM, Jevgeni Zelenkov wrote:
> >> Hi guys,
> >>
> >> I am trying to test the undo plugin on a working forge instance but I
> >> am getting a strange error.
> >>
> >> As described here:
> >>
> >>
https://docs.jboss.org/author/display/FORGE/Make+your+Plugin+available+to...
> >> I have added the undo-plugin using 'forge source-plugin' command.
It
> >> was added successfully, I can even see undo-plugin commands when I
> >> call 'list-commands'.
> >>
> >> But when I execute 'undo setup' command (should simply install the
> >> plugin), I get the following exception:
> >>
> >> The requested Facet of type [org.jboss.forge.undo.UndoFacet] could not
> >> be loaded.
> >>
> >> UndoFacet class is located in the same package as the UndoPlugin class
> >> (org.jboss.forge.undo). I also tried moving both classes into
> >> "org.jboss.forge" but that didn't help either.
> >>
> >> Does anybody have any ideas what could it be?
> >>
> >> Best Regards,
> >> Jevgeni
> >> _______________________________________________
> >> forge-dev mailing list
> >> forge-dev(a)lists.jboss.org
> >>
https://lists.jboss.org/mailman/listinfo/forge-dev
> > _______________________________________________
> > forge-dev mailing list
> > forge-dev(a)lists.jboss.org
> >
https://lists.jboss.org/mailman/listinfo/forge-dev
>
>
> On Thu, Jun 28, 2012 at 6:08 PM, Lincoln Baxter, III
> <lincolnbaxter(a)gmail.com> wrote:
> > Hey Jevgeni,
> >
> > I'm not sure how you have your plugin project set up (I can't find your
> > repository, could you move it to here?
> >
https://github.com/forge/plugin-undo), but you can't use
> > "org.jboss.forge"
> > as a package name.
> >
> > You should use something like, "org.jboss.undo.forge" (I think that
> > should
> > work.) We can work out a better package name later, but for right now,
> > it
> > doesn't really matter.
> >
> > That might resolve your problem :) Let me know!
> > ~Lincoln
> >
> > On Thu, Jun 28, 2012 at 12:01 PM, Jevgeni Zelenkov
> > <jevgeni.zelenkov(a)gmail.com> wrote:
> >>
> >> Hi guys,
> >>
> >> I am trying to test the undo plugin on a working forge instance but I
> >> am getting a strange error.
> >>
> >> As described here:
> >>
> >>
> >>
https://docs.jboss.org/author/display/FORGE/Make+your+Plugin+available+to...
> >> I have added the undo-plugin using 'forge source-plugin' command.
It
> >> was added successfully, I can even see undo-plugin commands when I
> >> call 'list-commands'.
> >>
> >> But when I execute 'undo setup' command (should simply install the
> >> plugin), I get the following exception:
> >>
> >> The requested Facet of type [org.jboss.forge.undo.UndoFacet] could not
> >> be loaded.
> >>
> >> UndoFacet class is located in the same package as the UndoPlugin class
> >> (org.jboss.forge.undo). I also tried moving both classes into
> >> "org.jboss.forge" but that didn't help either.
> >>
> >> Does anybody have any ideas what could it be?
> >>
> >> Best Regards,
> >> Jevgeni
> >> _______________________________________________
> >> forge-dev mailing list
> >> forge-dev(a)lists.jboss.org
> >>
https://lists.jboss.org/mailman/listinfo/forge-dev
> >
> >
> >
> >
> > --
> > Lincoln Baxter, III
> >
http://ocpsoft.org
> > "Simpler is better."
> >
> > _______________________________________________
> > forge-dev mailing list
> > forge-dev(a)lists.jboss.org
> >
https://lists.jboss.org/mailman/listinfo/forge-dev
> >
>
> _______________________________________________
> forge-dev mailing list
> forge-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/forge-dev
--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
_______________________________________________
forge-dev mailing list
forge-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/forge-dev