10:07 p.m.
Take a look at Prometheus's HTTPServer class:
https://github.com/prometheus/client_java/blob/master/simpleclient_httpse...
This Prometheus HTTPServer class is what jmx exporter uses for its metrics endpoint -
see:
https://github.com/prometheus/jmx_exporter/blob/master/jmx_prometheus_jav...
https://github.com/prometheus/jmx_exporter/blob/master/jmx_prometheus_htt...
Since it uses com.sun.net.httpserver classes under the covers, I'll assume this rules
out support for, say, IBM's JVM (does IBM's JRE implement these?). I think this is
available on OpenJDK but didn't check to make 100% sure.
3:26 a.m.
That package is indeed problematic. And may be even more so in the future
on JDK9+ with the module system, where modules like this may be totally
encapsulated away.
On Fri, Oct 27, 2017 at 5:07 AM, John Mazzitelli <mazz(a)redhat.com> wrote:
--
Reg. Adresse: Red Hat GmbH, Technopark II, Haus C,
Werner-von-Siemens-Ring 14, D-85630 Grasbrunn
Handelsregister: Amtsgericht München HRB 153243
Geschäftsführer: Charles Cachera, Michael Cunningham, Michael O'Neill, Eric
Shander
9:30 a.m.
I think the com.sun.* classes will work with OpenJDK (at least the JMX
exporter works fine when using OpenJDK)
As to whether it will work with other JVMs is another question. Is this
part of the code we are forking anyways? I assume since we need to make
other modifications here to support https, we might as well update this
section as well.
On Fri, Oct 27, 2017 at 4:26 AM, Heiko Rupp <hrupp(a)redhat.com> wrote:
9:56 a.m.
We are using it in our forked class here:
https://github.com/jmazzitelli/hawkular-agent/blob/remove-h-metrics/hawku...
Unfortunately, the way they coded up this class, it can't be subclasses and
overridden. We'd have to write our own and integrate the jmx exporter stuff ourselves.
Means we'll be writing a bit more code, but, yeah, once we start implementing the
https stuff, we can do it all at once.
9:46 a.m.
On 10/27/2017 09:56 AM, John Mazzitelli wrote:
I checked that the com.sun httpserver classes are available in both
openjdk and in the IBM JDK. These classes are also exported in a JDK 9
module [1]. So IMO it's probably ok for us to use the prometheus
webserver class as is.
[1]https://docs.oracle.com/javase/9/docs/api/jdk.httpserver-summary.html
8:18 a.m.
On 27 Oct 2017, at 16:30, Matthew Wringe wrote:
It is not only about other JDK vendors, but also about
the Jigsaw module system, where those internal classes
may not be visible by default anymore.
In Java9 one can still add a flag "--behave-like-java8",
but that may go away in the future.
2688
days inactive
2708
days old
6 comments
5 participants
participants (5)
-
Alissa Bonas -
Heiko Rupp -
John Mazzitelli -
Matthew Wringe -
Paul Gier