[JBoss JIRA] (JBIDE-21151) Button file system in OpenShift Application wizard causes an error
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21151?page=com.atlassian.jira.plugi... ]
Fred Bricon resolved JBIDE-21151.
---------------------------------
Fix Version/s: 4.3.1.Beta1
4.4.0.Alpha1
Assignee: Fred Bricon
Resolution: Done
Fixed in master 4.3.x
> Button file system in OpenShift Application wizard causes an error
> ------------------------------------------------------------------
>
> Key: JBIDE-21151
> URL: https://issues.jboss.org/browse/JBIDE-21151
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Assignee: Fred Bricon
> Priority: Blocker
> Labels: openshift_v3
> Fix For: 4.3.1.Beta1, 4.4.0.Alpha1
>
>
> In New OpenShift Application wizard on the first wizard page where selection of a template is, there is a button "File system..." which is supposed to open a file browser dialog, but nothing happens after click on it and following error with stacktrace is present in error log:
> {code}
> Unhandled event loop exception
> java.lang.NullPointerException
> at org.eclipse.core.internal.variables.StringSubstitutionEngine.substitute(StringSubstitutionEngine.java:137)
> at org.eclipse.core.internal.variables.StringSubstitutionEngine.performStringSubstitution(StringSubstitutionEngine.java:87)
> at org.eclipse.core.internal.variables.StringVariableManager.performStringSubstitution(StringVariableManager.java:592)
> at org.eclipse.core.internal.variables.StringVariableManager.performStringSubstitution(StringVariableManager.java:358)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage.substituteVariables(TemplateListPage.java:956)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage.isFile(TemplateListPage.java:545)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage.access$2(TemplateListPage.java:544)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage$14.createFileDialog(TemplateListPage.java:710)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage$14.widgetSelected(TemplateListPage.java:702)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
> at org.eclipse.jface.window.Window.open(Window.java:803)
> at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:279)
> at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:270)
> at org.jboss.tools.openshift.internal.ui.handler.NewApplicationHandler.execute(NewApplicationHandler.java:37)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.GeneratedMethodAccessor75.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:252)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:234)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
> at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:493)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:486)
> at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:799)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.handleWidgetSelection(HandledContributionItem.java:675)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.access$7(HandledContributionItem.java:659)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem$4.handleEvent(HandledContributionItem.java:592)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21153) Use extension in OpenShiftCoreUIIntegation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21153?page=com.atlassian.jira.plugi... ]
Andre Dietisheim closed JBIDE-21153.
------------------------------------
nothing for QE to verify
> Use extension in OpenShiftCoreUIIntegation
> ------------------------------------------
>
> Key: JBIDE-21153
> URL: https://issues.jboss.org/browse/JBIDE-21153
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3
> Fix For: 4.3.1.Beta1, 4.4.x
>
>
> the Connection class resides in the openshift core plugin. It happens that connections need to pop up dialogs in order to ex. let the user confirm ssl signatures or provide a token/credentials. To allow class to do this we have the OpenShiftCoreUIntegration currently, which is initialized by the activator in org.jboss.tools.openshift.ui by injecting the dialogs into OpenShiftCoreUIIntegration. This works fine as long as some UI is started before the connection gets activated. When creating a server adapter this doesnt work any more. The openshift server adapter resides in org.jboss.tools.openshift.core only, there's no openshift UI involved. The connection is therefore not able to prompt the user for a new token etc.
> We therefore have to change the current injection based approach (ui injects dialogs into core) by a extension point that the core is querying as soon as it requires some UI.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21153) Use extension in OpenShiftCoreUIIntegation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21153?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-21153:
-------------------------------------
Fix Version/s: 4.4.x
> Use extension in OpenShiftCoreUIIntegation
> ------------------------------------------
>
> Key: JBIDE-21153
> URL: https://issues.jboss.org/browse/JBIDE-21153
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3
> Fix For: 4.3.1.Beta1, 4.4.x
>
>
> the Connection class resides in the openshift core plugin. It happens that connections need to pop up dialogs in order to ex. let the user confirm ssl signatures or provide a token/credentials. To allow class to do this we have the OpenShiftCoreUIntegration currently, which is initialized by the activator in org.jboss.tools.openshift.ui by injecting the dialogs into OpenShiftCoreUIIntegration. This works fine as long as some UI is started before the connection gets activated. When creating a server adapter this doesnt work any more. The openshift server adapter resides in org.jboss.tools.openshift.core only, there's no openshift UI involved. The connection is therefore not able to prompt the user for a new token etc.
> We therefore have to change the current injection based approach (ui injects dialogs into core) by a extension point that the core is querying as soon as it requires some UI.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21153) Use extension in OpenShiftCoreUIIntegation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21153?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21153:
------------------------------------------
merged and pushed to upstream/jbosstools-4.3.x and upstream/master
> Use extension in OpenShiftCoreUIIntegation
> ------------------------------------------
>
> Key: JBIDE-21153
> URL: https://issues.jboss.org/browse/JBIDE-21153
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3
> Fix For: 4.3.1.Beta1, 4.4.x
>
>
> the Connection class resides in the openshift core plugin. It happens that connections need to pop up dialogs in order to ex. let the user confirm ssl signatures or provide a token/credentials. To allow class to do this we have the OpenShiftCoreUIntegration currently, which is initialized by the activator in org.jboss.tools.openshift.ui by injecting the dialogs into OpenShiftCoreUIIntegration. This works fine as long as some UI is started before the connection gets activated. When creating a server adapter this doesnt work any more. The openshift server adapter resides in org.jboss.tools.openshift.core only, there's no openshift UI involved. The connection is therefore not able to prompt the user for a new token etc.
> We therefore have to change the current injection based approach (ui injects dialogs into core) by a extension point that the core is querying as soon as it requires some UI.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21114) Dont stop watch client on disconnect
by Jeff Cantrill (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21114?page=com.atlassian.jira.plugi... ]
Jeff Cantrill commented on JBIDE-21114:
---------------------------------------
[~mlabuda] I believe the only obvious way to validate is to enable trace logging and review the log cycles to confirm there is no 'stop' message. Otherwise it will be behind the scenes from a user. Essentially, reviewing how to properly use the jetty websocket client I learned there should be only 1 per JVM and all of this will be transparent to the consumer.
> Dont stop watch client on disconnect
> ------------------------------------
>
> Key: JBIDE-21114
> URL: https://issues.jboss.org/browse/JBIDE-21114
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Jeff Cantrill
> Assignee: Jeff Cantrill
> Fix For: 4.3.1.Beta1
>
>
> Should just reconnect on error and leave watchclient running
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21153) Use extension in OpenShiftCoreUIIntegation
by Andre Dietisheim (JIRA)
Andre Dietisheim created JBIDE-21153:
----------------------------------------
Summary: Use extension in OpenShiftCoreUIIntegation
Key: JBIDE-21153
URL: https://issues.jboss.org/browse/JBIDE-21153
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: openshift
Affects Versions: 4.3.1.Beta1
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.3.1.Beta1
the Connection class resides in the openshift core plugin. It happens that connections need to pop up dialogs in order to ex. let the user confirm ssl signatures or provide a token/credentials. To allow class to do this we have the OpenShiftCoreUIntegration currently, which is initialized by the activator in org.jboss.tools.openshift.ui by injecting the dialogs into OpenShiftCoreUIIntegration. This works fine as long as some UI is started before the connection gets activated. When creating a server adapter this doesnt work any more. The openshift server adapter resides in org.jboss.tools.openshift.core only, there's no openshift UI involved. The connection is therefore not able to prompt the user for a new token etc.
We therefore have to change the current injection based approach (ui injects dialogs into core) by a extension point that the core is querying as soon as it requires some UI.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21153) Use extension in OpenShiftCoreUIIntegation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21153?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-21153:
-------------------------------------
Labels: openshift_v3 (was: )
> Use extension in OpenShiftCoreUIIntegation
> ------------------------------------------
>
> Key: JBIDE-21153
> URL: https://issues.jboss.org/browse/JBIDE-21153
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3
> Fix For: 4.3.1.Beta1
>
>
> the Connection class resides in the openshift core plugin. It happens that connections need to pop up dialogs in order to ex. let the user confirm ssl signatures or provide a token/credentials. To allow class to do this we have the OpenShiftCoreUIntegration currently, which is initialized by the activator in org.jboss.tools.openshift.ui by injecting the dialogs into OpenShiftCoreUIIntegration. This works fine as long as some UI is started before the connection gets activated. When creating a server adapter this doesnt work any more. The openshift server adapter resides in org.jboss.tools.openshift.core only, there's no openshift UI involved. The connection is therefore not able to prompt the user for a new token etc.
> We therefore have to change the current injection based approach (ui injects dialogs into core) by a extension point that the core is querying as soon as it requires some UI.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months