[JBoss JIRA] (JBIDE-21153) Use extension in OpenShiftCoreUIIntegation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21153?page=com.atlassian.jira.plugi... ]
Andre Dietisheim closed JBIDE-21153.
------------------------------------
nothing for QE to verify
> Use extension in OpenShiftCoreUIIntegation
> ------------------------------------------
>
> Key: JBIDE-21153
> URL: https://issues.jboss.org/browse/JBIDE-21153
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3
> Fix For: 4.3.1.Beta1, 4.4.x
>
>
> the Connection class resides in the openshift core plugin. It happens that connections need to pop up dialogs in order to ex. let the user confirm ssl signatures or provide a token/credentials. To allow class to do this we have the OpenShiftCoreUIntegration currently, which is initialized by the activator in org.jboss.tools.openshift.ui by injecting the dialogs into OpenShiftCoreUIIntegration. This works fine as long as some UI is started before the connection gets activated. When creating a server adapter this doesnt work any more. The openshift server adapter resides in org.jboss.tools.openshift.core only, there's no openshift UI involved. The connection is therefore not able to prompt the user for a new token etc.
> We therefore have to change the current injection based approach (ui injects dialogs into core) by a extension point that the core is querying as soon as it requires some UI.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21153) Use extension in OpenShiftCoreUIIntegation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21153?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-21153:
-------------------------------------
Fix Version/s: 4.4.x
> Use extension in OpenShiftCoreUIIntegation
> ------------------------------------------
>
> Key: JBIDE-21153
> URL: https://issues.jboss.org/browse/JBIDE-21153
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3
> Fix For: 4.3.1.Beta1, 4.4.x
>
>
> the Connection class resides in the openshift core plugin. It happens that connections need to pop up dialogs in order to ex. let the user confirm ssl signatures or provide a token/credentials. To allow class to do this we have the OpenShiftCoreUIntegration currently, which is initialized by the activator in org.jboss.tools.openshift.ui by injecting the dialogs into OpenShiftCoreUIIntegration. This works fine as long as some UI is started before the connection gets activated. When creating a server adapter this doesnt work any more. The openshift server adapter resides in org.jboss.tools.openshift.core only, there's no openshift UI involved. The connection is therefore not able to prompt the user for a new token etc.
> We therefore have to change the current injection based approach (ui injects dialogs into core) by a extension point that the core is querying as soon as it requires some UI.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21153) Use extension in OpenShiftCoreUIIntegation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21153?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21153:
------------------------------------------
merged and pushed to upstream/jbosstools-4.3.x and upstream/master
> Use extension in OpenShiftCoreUIIntegation
> ------------------------------------------
>
> Key: JBIDE-21153
> URL: https://issues.jboss.org/browse/JBIDE-21153
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3
> Fix For: 4.3.1.Beta1, 4.4.x
>
>
> the Connection class resides in the openshift core plugin. It happens that connections need to pop up dialogs in order to ex. let the user confirm ssl signatures or provide a token/credentials. To allow class to do this we have the OpenShiftCoreUIntegration currently, which is initialized by the activator in org.jboss.tools.openshift.ui by injecting the dialogs into OpenShiftCoreUIIntegration. This works fine as long as some UI is started before the connection gets activated. When creating a server adapter this doesnt work any more. The openshift server adapter resides in org.jboss.tools.openshift.core only, there's no openshift UI involved. The connection is therefore not able to prompt the user for a new token etc.
> We therefore have to change the current injection based approach (ui injects dialogs into core) by a extension point that the core is querying as soon as it requires some UI.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21114) Dont stop watch client on disconnect
by Jeff Cantrill (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21114?page=com.atlassian.jira.plugi... ]
Jeff Cantrill commented on JBIDE-21114:
---------------------------------------
[~mlabuda] I believe the only obvious way to validate is to enable trace logging and review the log cycles to confirm there is no 'stop' message. Otherwise it will be behind the scenes from a user. Essentially, reviewing how to properly use the jetty websocket client I learned there should be only 1 per JVM and all of this will be transparent to the consumer.
> Dont stop watch client on disconnect
> ------------------------------------
>
> Key: JBIDE-21114
> URL: https://issues.jboss.org/browse/JBIDE-21114
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Jeff Cantrill
> Assignee: Jeff Cantrill
> Fix For: 4.3.1.Beta1
>
>
> Should just reconnect on error and leave watchclient running
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21153) Use extension in OpenShiftCoreUIIntegation
by Andre Dietisheim (JIRA)
Andre Dietisheim created JBIDE-21153:
----------------------------------------
Summary: Use extension in OpenShiftCoreUIIntegation
Key: JBIDE-21153
URL: https://issues.jboss.org/browse/JBIDE-21153
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: openshift
Affects Versions: 4.3.1.Beta1
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.3.1.Beta1
the Connection class resides in the openshift core plugin. It happens that connections need to pop up dialogs in order to ex. let the user confirm ssl signatures or provide a token/credentials. To allow class to do this we have the OpenShiftCoreUIntegration currently, which is initialized by the activator in org.jboss.tools.openshift.ui by injecting the dialogs into OpenShiftCoreUIIntegration. This works fine as long as some UI is started before the connection gets activated. When creating a server adapter this doesnt work any more. The openshift server adapter resides in org.jboss.tools.openshift.core only, there's no openshift UI involved. The connection is therefore not able to prompt the user for a new token etc.
We therefore have to change the current injection based approach (ui injects dialogs into core) by a extension point that the core is querying as soon as it requires some UI.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21153) Use extension in OpenShiftCoreUIIntegation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21153?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-21153:
-------------------------------------
Labels: openshift_v3 (was: )
> Use extension in OpenShiftCoreUIIntegation
> ------------------------------------------
>
> Key: JBIDE-21153
> URL: https://issues.jboss.org/browse/JBIDE-21153
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3
> Fix For: 4.3.1.Beta1
>
>
> the Connection class resides in the openshift core plugin. It happens that connections need to pop up dialogs in order to ex. let the user confirm ssl signatures or provide a token/credentials. To allow class to do this we have the OpenShiftCoreUIntegration currently, which is initialized by the activator in org.jboss.tools.openshift.ui by injecting the dialogs into OpenShiftCoreUIIntegration. This works fine as long as some UI is started before the connection gets activated. When creating a server adapter this doesnt work any more. The openshift server adapter resides in org.jboss.tools.openshift.core only, there's no openshift UI involved. The connection is therefore not able to prompt the user for a new token etc.
> We therefore have to change the current injection based approach (ui injects dialogs into core) by a extension point that the core is querying as soon as it requires some UI.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21152) Cannot deploy mvn module of an existing git-based application to OpenShift 3 server
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21152?page=com.atlassian.jira.plugi... ]
Marián Labuda updated JBIDE-21152:
----------------------------------
Description:
If a git-based project it maven module and it has some parent (like eap quickstarts available at https://github.com/jboss-developer/jboss-eap-quickstarts) it is not possible to deploy such a project. There is an error in New OpenShift Application wizrad telling that a project is not git project, although it is. There was similar issue with OpenShift 2 and with deploying projects which did not have .git folder in itself but it was in parent. See following screenshot:
!application_wizard.png!
was:
If a git-based project it maven module and it has some parent (like eap quickstarts available at https://github.com/jboss-developer/jboss-eap-quickstarts) it is not possible to deploy such a project. There is an error in New OpenShift Application wizrad telling that a project is not git project, although it is. See following screenshot:
!application_wizard.png!
> Cannot deploy mvn module of an existing git-based application to OpenShift 3 server
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-21152
> URL: https://issues.jboss.org/browse/JBIDE-21152
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Priority: Critical
> Attachments: application_wizard.png
>
>
> If a git-based project it maven module and it has some parent (like eap quickstarts available at https://github.com/jboss-developer/jboss-eap-quickstarts) it is not possible to deploy such a project. There is an error in New OpenShift Application wizrad telling that a project is not git project, although it is. There was similar issue with OpenShift 2 and with deploying projects which did not have .git folder in itself but it was in parent. See following screenshot:
> !application_wizard.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21152) Cannot deploy mvn module of an existing git-based application to OpenShift 3 server
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21152?page=com.atlassian.jira.plugi... ]
Marián Labuda updated JBIDE-21152:
----------------------------------
Description:
If a git-based project it maven module and it has some parent (like eap quickstarts available at https://github.com/jboss-developer/jboss-eap-quickstarts) it is not possible to deploy such a project. There is an error in New OpenShift Application wizard telling that a project is not git project, although it is. There was similar issue with OpenShift 2 and with deploying projects which did not have .git folder in itself but it was in parent. See following screenshot:
!application_wizard.png!
was:
If a git-based project it maven module and it has some parent (like eap quickstarts available at https://github.com/jboss-developer/jboss-eap-quickstarts) it is not possible to deploy such a project. There is an error in New OpenShift Application wizrad telling that a project is not git project, although it is. There was similar issue with OpenShift 2 and with deploying projects which did not have .git folder in itself but it was in parent. See following screenshot:
!application_wizard.png!
> Cannot deploy mvn module of an existing git-based application to OpenShift 3 server
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-21152
> URL: https://issues.jboss.org/browse/JBIDE-21152
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Priority: Critical
> Attachments: application_wizard.png
>
>
> If a git-based project it maven module and it has some parent (like eap quickstarts available at https://github.com/jboss-developer/jboss-eap-quickstarts) it is not possible to deploy such a project. There is an error in New OpenShift Application wizard telling that a project is not git project, although it is. There was similar issue with OpenShift 2 and with deploying projects which did not have .git folder in itself but it was in parent. See following screenshot:
> !application_wizard.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month