[JBoss JIRA] (JBIDE-13671) Replace build timestamp in qualifier by last-mod-timestamp from git
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-13671:
------------------------------------
{quote}Then we have to go all the way and remove build label from version and stop changing versions for plugins/features all together.{quote}If you mean removing the BUILD_ALIAS = Alpha, Beta, CR, Final/GA, I'm not adverse to that idea. But we can still make THIS change and then work to convince people the ALIAS is no longer required. :D
Note also that AFAIK this doc is still in effect: https://developer.jboss.org/wiki/JBossProjectVersioning
> Replace build timestamp in qualifier by last-mod-timestamp from git
> -------------------------------------------------------------------
>
> Key: JBIDE-13671
> URL: https://issues.jboss.org/browse/JBIDE-13671
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Optional
> Fix For: 4.4.0.Alpha2
>
> Attachments: jbide13671-before-and-after.png
>
>
> This needs to be added to master parent pom:
> {code}
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-packaging-plugin</artifactId>
> <version>${tycho.version}</version>
> <dependencies>
> <dependency>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-buildtimestamp-jgit</artifactId>
> <version>${tycho-extras.version}</version>
> </dependency>
> </dependencies>
> <configuration>
> <strictBinIncludes>false</strictBinIncludes>
> <format>'v'yyyyMMdd-HHmm</format>
> <timestampProvider>jgit</timestampProvider>
> <jgit.ignore>
> </jgit.ignore>
> </configuration>
> </plugin>
> {code}
> Ref: http://pweclipse.blogspot.ch/2012_09_01_archive.html
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years
[JBoss JIRA] (JBIDE-13671) Replace build timestamp in qualifier by last-mod-timestamp from git
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-13671:
------------------------------------
{quote}How do we map timestamp back to SHA?
Is there SHA in manifest somewhere?{quote}
Yes. Open any plugin jar and look in its MANIFEST.MF file.
{code}
Eclipse-SourceReferences: scm:git:https://github.com/jbosstools/jbosst
ools-arquillian.git;path="plugins/org.jboss.tools.arquillian.ui";comm
itId=8d50f7310ae6b2d4960b39ad606738baa6c81dc6{code}
> Replace build timestamp in qualifier by last-mod-timestamp from git
> -------------------------------------------------------------------
>
> Key: JBIDE-13671
> URL: https://issues.jboss.org/browse/JBIDE-13671
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Optional
> Fix For: 4.4.0.Alpha2
>
> Attachments: jbide13671-before-and-after.png
>
>
> This needs to be added to master parent pom:
> {code}
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-packaging-plugin</artifactId>
> <version>${tycho.version}</version>
> <dependencies>
> <dependency>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-buildtimestamp-jgit</artifactId>
> <version>${tycho-extras.version}</version>
> </dependency>
> </dependencies>
> <configuration>
> <strictBinIncludes>false</strictBinIncludes>
> <format>'v'yyyyMMdd-HHmm</format>
> <timestampProvider>jgit</timestampProvider>
> <jgit.ignore>
> </jgit.ignore>
> </configuration>
> </plugin>
> {code}
> Ref: http://pweclipse.blogspot.ch/2012_09_01_archive.html
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years
[JBoss JIRA] (JBIDE-13671) Replace build timestamp in qualifier by last-mod-timestamp from git
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-13671:
------------------------------------
I'd be OK dropping the Alpha/Beta/CR/Final/GA thing too, but that's a harder one to sell. In that case if nothing changes between an Alpha and a Beta build, the install delta would be that much smaller, rather than requiring users to install everything all over again simply because we decided identical commit in Github should now be called "Beta" instead of "Alpha".
The problem with the "w" prefix is that once you've done a `mvn install` to get those bits into your local ~/,m2 so they're available for a downstream build to use (eg., API change in Base, build Base, then build Server to verify) you can't easily remove them from your ~/.m2 cache, and newer builds from remote will be seen as older because the "w" will always beat the "v". So... it's more manual cleanup required (and more downloading the internet). Our current workflow using "v" for both local and remote is better -- it will work for the exact usecase you describe: "install nightly build and then update it [from] local build to test your fixes."
The major benefit here is that as we start releasing more frequently (eg., weekly integration builds for QE & downstream consumption by DP installer), the changes between each build will be literally smaller, rather than just looking smaller, Auditing will be simpler because we won't have to check plugins' contents for changes - we can trust that the timestamp shows when the plugin was ACTUALLY last changed in Github.
So yes, it's worth it. We've been trying to make this change for 3 years. We tested it for Locus and it works great there. No reason not to roll it out to the rest of the team.
> Replace build timestamp in qualifier by last-mod-timestamp from git
> -------------------------------------------------------------------
>
> Key: JBIDE-13671
> URL: https://issues.jboss.org/browse/JBIDE-13671
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Optional
> Fix For: 4.4.0.Alpha2
>
> Attachments: jbide13671-before-and-after.png
>
>
> This needs to be added to master parent pom:
> {code}
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-packaging-plugin</artifactId>
> <version>${tycho.version}</version>
> <dependencies>
> <dependency>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-buildtimestamp-jgit</artifactId>
> <version>${tycho-extras.version}</version>
> </dependency>
> </dependencies>
> <configuration>
> <strictBinIncludes>false</strictBinIncludes>
> <format>'v'yyyyMMdd-HHmm</format>
> <timestampProvider>jgit</timestampProvider>
> <jgit.ignore>
> </jgit.ignore>
> </configuration>
> </plugin>
> {code}
> Ref: http://pweclipse.blogspot.ch/2012_09_01_archive.html
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years
[JBoss JIRA] (JBIDE-13671) Replace build timestamp in qualifier by last-mod-timestamp from git
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-13671:
---------------------------------------
{quote}The whole point here is that it no longer matters in which build the bits are built because we know they're coming from the same SHA in github. So we could add that suffix back onto the update site version qualifier if we want but I'm not sure we need it.{qote}
Then we have to go all the way and remove build label from version and stop changing versions for plugins/features all together.
How do we map timestamp back to SHA?
Is there SHA in manifest somewhere?
> Replace build timestamp in qualifier by last-mod-timestamp from git
> -------------------------------------------------------------------
>
> Key: JBIDE-13671
> URL: https://issues.jboss.org/browse/JBIDE-13671
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Optional
> Fix For: 4.4.0.Alpha2
>
> Attachments: jbide13671-before-and-after.png
>
>
> This needs to be added to master parent pom:
> {code}
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-packaging-plugin</artifactId>
> <version>${tycho.version}</version>
> <dependencies>
> <dependency>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-buildtimestamp-jgit</artifactId>
> <version>${tycho-extras.version}</version>
> </dependency>
> </dependencies>
> <configuration>
> <strictBinIncludes>false</strictBinIncludes>
> <format>'v'yyyyMMdd-HHmm</format>
> <timestampProvider>jgit</timestampProvider>
> <jgit.ignore>
> </jgit.ignore>
> </configuration>
> </plugin>
> {code}
> Ref: http://pweclipse.blogspot.ch/2012_09_01_archive.html
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years
[JBoss JIRA] (JBIDE-13671) Replace build timestamp in qualifier by last-mod-timestamp from git
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugi... ]
Denis Golovin edited comment on JBIDE-13671 at 4/29/16 2:52 PM:
----------------------------------------------------------------
{quote}The whole point here is that it no longer matters in which build the bits are built because we know they're coming from the same SHA in github. So we could add that suffix back onto the update site version qualifier if we want but I'm not sure we need it.{quote}
Then we have to go all the way and remove build label from version and stop changing versions for plugins/features all together.
How do we map timestamp back to SHA?
Is there SHA in manifest somewhere?
was (Author: dgolovin):
{quote}The whole point here is that it no longer matters in which build the bits are built because we know they're coming from the same SHA in github. So we could add that suffix back onto the update site version qualifier if we want but I'm not sure we need it.{qote}
Then we have to go all the way and remove build label from version and stop changing versions for plugins/features all together.
How do we map timestamp back to SHA?
Is there SHA in manifest somewhere?
> Replace build timestamp in qualifier by last-mod-timestamp from git
> -------------------------------------------------------------------
>
> Key: JBIDE-13671
> URL: https://issues.jboss.org/browse/JBIDE-13671
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Optional
> Fix For: 4.4.0.Alpha2
>
> Attachments: jbide13671-before-and-after.png
>
>
> This needs to be added to master parent pom:
> {code}
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-packaging-plugin</artifactId>
> <version>${tycho.version}</version>
> <dependencies>
> <dependency>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-buildtimestamp-jgit</artifactId>
> <version>${tycho-extras.version}</version>
> </dependency>
> </dependencies>
> <configuration>
> <strictBinIncludes>false</strictBinIncludes>
> <format>'v'yyyyMMdd-HHmm</format>
> <timestampProvider>jgit</timestampProvider>
> <jgit.ignore>
> </jgit.ignore>
> </configuration>
> </plugin>
> {code}
> Ref: http://pweclipse.blogspot.ch/2012_09_01_archive.html
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years
[JBoss JIRA] (JBIDE-13671) Replace build timestamp in qualifier by last-mod-timestamp from git
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-13671:
---------------------------------------
I see only one benefit for nightly builds if nothing changed then it has exactly the same version. That would lead for less to download when updating to latest nightly.
This doesn't work for milestone releases, because of changes in version label Alpha/Beta/CR/GA.
Even if some bits features/plugins have the same names between nightly updates they all still going to be uploaded to download.jboss.org nightly update.
What are other pros for this change?
Does it worth to push at all considering we are all used to current template for qualifier?
The only change with benefits is 'v' suffix for CI vs. 'w' for local builds, so you can install nightly build and then update it form local build to test your fixes.
> Replace build timestamp in qualifier by last-mod-timestamp from git
> -------------------------------------------------------------------
>
> Key: JBIDE-13671
> URL: https://issues.jboss.org/browse/JBIDE-13671
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Optional
> Fix For: 4.4.0.Alpha2
>
> Attachments: jbide13671-before-and-after.png
>
>
> This needs to be added to master parent pom:
> {code}
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-packaging-plugin</artifactId>
> <version>${tycho.version}</version>
> <dependencies>
> <dependency>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-buildtimestamp-jgit</artifactId>
> <version>${tycho-extras.version}</version>
> </dependency>
> </dependencies>
> <configuration>
> <strictBinIncludes>false</strictBinIncludes>
> <format>'v'yyyyMMdd-HHmm</format>
> <timestampProvider>jgit</timestampProvider>
> <jgit.ignore>
> </jgit.ignore>
> </configuration>
> </plugin>
> {code}
> Ref: http://pweclipse.blogspot.ch/2012_09_01_archive.html
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years
[JBoss JIRA] (ERT-175) Add xml validator option to ignore "Referenced file contains errors" error [EBZ#491313]
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/ERT-175?page=com.atlassian.jira.plugin.sy... ]
Victor Rubezhny reassigned ERT-175:
-----------------------------------
Assignee: Rob Stryker (was: Victor Rubezhny)
> Add xml validator option to ignore "Referenced file contains errors" error [EBZ#491313]
> ---------------------------------------------------------------------------------------
>
> Key: ERT-175
> URL: https://issues.jboss.org/browse/ERT-175
> Project: Eclipse Release Train
> Issue Type: Task
> Components: WTP Source Editing
> Reporter: Friendly Jira Robot
> Assignee: Rob Stryker
> Priority: Trivial
> Labels: 3.8_M7, bzira, wst.xml
> Fix For: Neon (4.6) M7
>
>
> The biggest problems we have for our customers is when the customer's xml file is fine, but validating against an imperfect schema upstream ends up with an error like this:
> "Referenced file contains errors (file:/home/rob/apps/eclipse/builds/tp/4.60.x_20160308/../../../../../code/jbtools/github/jbosstools-server/as/plugins/org.jboss.tools.as.catalog/schema/xsd/ourBundledSchema.xsd). For
> more information, right click on the message in the Problems View and select "Show Details..."
> It'd be great if we had an xml validator option to allow this to be an error, a warning, or even ignored.
> Since this is our most common error for users, we consider it a pretty high priority request. We'd be willing to do some of the work if you could point us to where such a thing could be implemented easily (or even not easily... at least a starting-off point).
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years