1:45 a.m.
Rob Stryker created JBIDE-12419:
-----------------------------------
Summary: archives core should not have references to NLS class in src/main
Key: JBIDE-12419
URL: https://issues.jboss.org/browse/JBIDE-12419
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Archives
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.3.2, 3.4.0.M1
The old use case to run project archives from cmd line requires a strict set of jars.
References to NLS class are not allowed. Problem can be seen in build unit test
SimpleAntTest
Error Message
The ant task did not successfully complete. BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
Stacktrace
junit.framework.AssertionFailedError: The ant task did not successfully complete.
BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:07 a.m.
[
https://issues.jboss.org/browse/JBIDE-12419?page=com.atlassian.jira.plugi...
]
Rob Stryker commented on JBIDE-12419:
-------------------------------------
Oddly enough, teh commits that add NLS to the classes was wrong, but it was wrong over 3
years ago (https://source.jboss.org/changelog/JBossTools?cs=14646).
The unit test does the following when creating the launch path:
String equinoxJar =
FileLocator.getBundleFile(Platform.getBundle("org.eclipse.equinox.common")).getAbsolutePath();
map.put(ECLIPSE_LOC, eclipseHome);
map.put(EQUINOX_JAR, equinoxJar);
map.put(PROJECT_NAME, "SimpleAntTest");
map.put(ARCHIVES_HOME, RUNTIME_WORKBENCH ? PLUGIN_LOCATION : eclipseHome);
map.put(PROJECT_DIR, projectLoc.toOSString());
This indicates that org.eclipse.equinox.common is added ot the build path, as well as the
archives plugins, and the example project itself. The NLS class lives in
org.eclipse.osgi.util. A search against earlier versions of eclipse does not show the NLS
class moving at all, so theoretically, this test should have failed for the past 3 years.
Very strange.
archives core should not have references to NLS class in src/main
-----------------------------------------------------------------
Key: JBIDE-12419
URL: https://issues.jboss.org/browse/JBIDE-12419
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Archives
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.3.2, 3.4.0.M1
The old use case to run project archives from cmd line requires a strict set of jars.
References to NLS class are not allowed. Problem can be seen in build unit test
SimpleAntTest
Error Message
The ant task did not successfully complete. BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
Stacktrace
junit.framework.AssertionFailedError: The ant task did not successfully complete.
BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:31 a.m.
[
https://issues.jboss.org/browse/JBIDE-12419?page=com.atlassian.jira.plugi...
]
Rob Stryker resolved JBIDE-12419.
---------------------------------
Resolution: Done
The upstream hudson job is no longer failing with these errors.
archives core should not have references to NLS class in src/main
-----------------------------------------------------------------
Key: JBIDE-12419
URL: https://issues.jboss.org/browse/JBIDE-12419
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Archives
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.3.2, 3.4.0.M1
The old use case to run project archives from cmd line requires a strict set of jars.
References to NLS class are not allowed. Problem can be seen in build unit test
SimpleAntTest
Error Message
The ant task did not successfully complete. BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
Stacktrace
junit.framework.AssertionFailedError: The ant task did not successfully complete.
BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:42 a.m.
[
https://issues.jboss.org/browse/JBIDE-12419?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič commented on JBIDE-12419:
-------------------------------------------
Rob, could you verify and close this issue? Thanks
archives core should not have references to NLS class in src/main
-----------------------------------------------------------------
Key: JBIDE-12419
URL: https://issues.jboss.org/browse/JBIDE-12419
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Archives
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.3.2, 4.0.0.Alpha1
The old use case to run project archives from cmd line requires a strict set of jars.
References to NLS class are not allowed. Problem can be seen in build unit test
SimpleAntTest
Error Message
The ant task did not successfully complete. BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
Stacktrace
junit.framework.AssertionFailedError: The ant task did not successfully complete.
BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:56 a.m.
[
https://issues.jboss.org/browse/JBIDE-12419?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič commented on JBIDE-12419:
-------------------------------------------
I meant verify it on 4.0.0 Alpha1. We should not close it until verification on build
3.3.2 :)
archives core should not have references to NLS class in src/main
-----------------------------------------------------------------
Key: JBIDE-12419
URL: https://issues.jboss.org/browse/JBIDE-12419
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Archives
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.3.2, 4.0.0.Alpha1
The old use case to run project archives from cmd line requires a strict set of jars.
References to NLS class are not allowed. Problem can be seen in build unit test
SimpleAntTest
Error Message
The ant task did not successfully complete. BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
Stacktrace
junit.framework.AssertionFailedError: The ant task did not successfully complete.
BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:43 p.m.
[
https://issues.jboss.org/browse/JBIDE-12419?page=com.atlassian.jira.plugi...
]
Rob Stryker commented on JBIDE-12419:
-------------------------------------
step 1) checkout source tree
step 2) cd trunk/archives/plugins/org.jboss.ide.eclipse.archives.core/src/main
step 3) grep -R "NLS" * | grep "osgi"
Only 1 result, and the line is commented so is not active. This means all references to
NLS were removed. That's all I've got for replication at hte moment as I really
don't remember how to fully run project archives outside of eclipse ;)
archives core should not have references to NLS class in src/main
-----------------------------------------------------------------
Key: JBIDE-12419
URL: https://issues.jboss.org/browse/JBIDE-12419
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Archives
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.3.2, 4.0.0.Alpha1
The old use case to run project archives from cmd line requires a strict set of jars.
References to NLS class are not allowed. Problem can be seen in build unit test
SimpleAntTest
Error Message
The ant task did not successfully complete. BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
Stacktrace
junit.framework.AssertionFailedError: The ant task did not successfully complete.
BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:08 a.m.
[
https://issues.jboss.org/browse/JBIDE-12419?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič commented on JBIDE-12419:
-------------------------------------------
Verified in 4.0.0 Beta1. Jira will be closed, once verified on 3.3.2 as well
archives core should not have references to NLS class in src/main
-----------------------------------------------------------------
Key: JBIDE-12419
URL: https://issues.jboss.org/browse/JBIDE-12419
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Archives
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.3.2, 4.0.0.Alpha1
The old use case to run project archives from cmd line requires a strict set of jars.
References to NLS class are not allowed. Problem can be seen in build unit test
SimpleAntTest
Error Message
The ant task did not successfully complete. BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
Stacktrace
junit.framework.AssertionFailedError: The ant task did not successfully complete.
BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:50 a.m.
[
https://issues.jboss.org/browse/JBIDE-12419?page=com.atlassian.jira.plugi...
]
Vlado Pakan updated JBIDE-12419:
--------------------------------
Fix Version/s: (was: 3.3.2)
archives core should not have references to NLS class in src/main
-----------------------------------------------------------------
Key: JBIDE-12419
URL: https://issues.jboss.org/browse/JBIDE-12419
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Archives
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.Alpha1
The old use case to run project archives from cmd line requires a strict set of jars.
References to NLS class are not allowed. Problem can be seen in build unit test
SimpleAntTest
Error Message
The ant task did not successfully complete. BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
Stacktrace
junit.framework.AssertionFailedError: The ant task did not successfully complete.
BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:50 a.m.
[
https://issues.jboss.org/browse/JBIDE-12419?page=com.atlassian.jira.plugi...
]
Vlado Pakan closed JBIDE-12419.
-------------------------------
archives core should not have references to NLS class in src/main
-----------------------------------------------------------------
Key: JBIDE-12419
URL: https://issues.jboss.org/browse/JBIDE-12419
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Archives
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.Alpha1
The old use case to run project archives from cmd line requires a strict set of jars.
References to NLS class are not allowed. Problem can be seen in build unit test
SimpleAntTest
Error Message
The ant task did not successfully complete. BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
Stacktrace
junit.framework.AssertionFailedError: The ant task did not successfully complete.
BUILD FAILED
/mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25:
java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4188
days inactive
4297
days old
jbosstools-issues@lists.jboss.org
8 comments
3 participants
participants (3)
-
Jaroslav Jankovič (JIRA) -
Rob Stryker (JIRA)
-
Vlado Pakan (JIRA)