[JBoss JIRA] (MODCLUSTER-518) Support JDK 9
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-518?page=com.atlassian.jira.pl... ]
Radoslav Husar commented on MODCLUSTER-518:
-------------------------------------------
Currently fails with
{noformat}
[ERROR] java.lang.NoClassDefFoundError: javax/annotation/Generated
at org.jboss.logging.processor.generator.model.ClassModel.generateModel(ClassModel.java:122)
at org.jboss.logging.processor.generator.model.ImplementationClassModel.generateModel(ImplementationClassModel.java:81)
at org.jboss.logging.processor.generator.model.MessageLoggerImplementor.generateModel(MessageLoggerImplementor.java:92)
at org.jboss.logging.processor.generator.model.ClassModel.create(ClassModel.java:104)
at org.jboss.logging.processor.apt.ImplementationClassGenerator.processTypeElement(ImplementationClassGenerator.java:63)
at org.jboss.logging.processor.apt.LoggingToolsProcessor.process(LoggingToolsProcessor.java:145)
at com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(jdk.compiler@9-ea/JavacProcessingEnvironment.java:961)
at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(jdk.compiler@9-ea/JavacProcessingEnvironment.java:877)
at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$2100(jdk.compiler@9-ea/JavacProcessingEnvironment.java:107)
at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(jdk.compiler@9-ea/JavacProcessingEnvironment.java:1184)
at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(jdk.compiler@9-ea/JavacProcessingEnvironment.java:1292)
at com.sun.tools.javac.main.JavaCompiler.processAnnotations(jdk.compiler@9-ea/JavaCompiler.java:1229)
at com.sun.tools.javac.main.JavaCompiler.compile(jdk.compiler@9-ea/JavaCompiler.java:903)
at com.sun.tools.javac.api.JavacTaskImpl$1.call(jdk.compiler@9-ea/JavacTaskImpl.java:104)
at com.sun.tools.javac.api.JavacTaskImpl$1.call(jdk.compiler@9-ea/JavacTaskImpl.java:100)
at com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(jdk.compiler@9-ea/JavacTaskImpl.java:135)
at com.sun.tools.javac.api.JavacTaskImpl.doCall(jdk.compiler@9-ea/JavacTaskImpl.java:100)
at com.sun.tools.javac.api.JavacTaskImpl.call(jdk.compiler@9-ea/JavacTaskImpl.java:94)
at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:125)
at org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:171)
at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:886)
at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:129)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:862)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:286)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:197)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@9-ea/Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@9-ea/NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:533)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: java.lang.ClassNotFoundException: javax.annotation.Generated
at java.net.URLClassLoader.findClass(java.base@9-ea/URLClassLoader.java:384)
at java.lang.ClassLoader.loadClass(java.base@9-ea/ClassLoader.java:486)
at java.lang.ClassLoader.loadClass(java.base@9-ea/ClassLoader.java:419)
... 44 more
{noformat}
which needs these 2 compiler args:
{noformat}
+ <compilerArgs>
+ <arg>-J-addmods</arg>
+ <arg>-Jjava.annotations.common</arg>
+ </compilerArgs>
{noformat}
> Support JDK 9
> -------------
>
> Key: MODCLUSTER-518
> URL: https://issues.jboss.org/browse/MODCLUSTER-518
> Project: mod_cluster
> Issue Type: Task
> Components: Core & Container Integration (Java)
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Labels: jdk9
> Fix For: 2.0.0.Alpha1
>
>
> JDK 9 Early Access Downloads available https://jdk9.java.net/download/
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
[JBoss JIRA] (MODCLUSTER-519) Keep Tomcat dependency versions on latest released versions
by Radoslav Husar (JIRA)
Radoslav Husar created MODCLUSTER-519:
-----------------------------------------
Summary: Keep Tomcat dependency versions on latest released versions
Key: MODCLUSTER-519
URL: https://issues.jboss.org/browse/MODCLUSTER-519
Project: mod_cluster
Issue Type: Task
Components: Core & Container Integration (Java)
Reporter: Radoslav Husar
Assignee: Radoslav Husar
Fix For: 2.0.0.Alpha1
We have discussed with [~pferraro] on call W24/2016 that we should keep all dependency versions on latest releases, this way we can detect regressions in tomcat code compatibility quickly.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
[JBoss JIRA] (MODCLUSTER-485) Move CI to Travis
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-485?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-485:
--------------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/modcluster/mod_cluster/pull/200
> Move CI to Travis
> -----------------
>
> Key: MODCLUSTER-485
> URL: https://issues.jboss.org/browse/MODCLUSTER-485
> Project: mod_cluster
> Issue Type: Task
> Components: Core & Container Integration (Java)
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Fix For: 2.0.0.Alpha1
>
>
> -I ran into this while adding support for Tomcat 9.-
> -What the CI should be testing, give the number of JDKs and different container versions that we support, we should build with respective jdks and versions:-
> -jdk6 + mvn verify -PTC6-
> -jdk7 + mvn verify -PTC7-
> -jdk7 + mvn verify -PAS7-
> -jdk8 + mvn verify -PTC8-
> -jdk7/8 + mvn verify-
> The situation has changed since original proposal fixing CI with proper dependencies for tomcat versions. Taking into account support for legacy containers has been dropped in master, so now we have desired combinations:
> * jdk7 + jdk8 and default profile (excludes Tomcat 9) -> 3 combos on travis
> * jdk 8 + Tomcat 9 profile -> 1 combo on travis
> See http://tomcat.apache.org/whichversion.html
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
[JBoss JIRA] (MODCLUSTER-485) Move CI to Travis
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-485?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-485:
--------------------------------------
Description:
-I ran into this while adding support for Tomcat 9.-
-What the CI should be testing, give the number of JDKs and different container versions that we support, we should build with respective jdks and versions:-
-jdk6 + mvn verify -PTC6-
-jdk7 + mvn verify -PTC7-
-jdk7 + mvn verify -PAS7-
-jdk8 + mvn verify -PTC8-
-jdk7/8 + mvn verify-
The situation has changed since original proposal fixing CI with proper dependencies for tomcat versions. Taking into account support for legacy containers has been dropped in master, so now we have desired combinations:
* jdk7 + jdk8 and default profile (excludes Tomcat 9) -> 3 combos on travis
* jdk 8 + Tomcat 9 profile -> 1 combo on travis
See http://tomcat.apache.org/whichversion.html
was:
-I ran into this while adding support for Tomcat 9.-
-What the CI should be testing, give the number of JDKs and different container versions that we support, we should build with respective jdks and versions:-
-jdk6 + mvn verify -PTC6-
-jdk7 + mvn verify -PTC7-
-jdk7 + mvn verify -PAS7-
-jdk8 + mvn verify -PTC8-
-jdk7/8 + mvn verify-
The situation has changed since, taking master into account support for legacy containers has been dropped so now we have:
* jdk7 + 8 and everything in default (excludes Tomcat 9) -> 3 combos on travis
* jdk 8 + Tomcat 9 -> 1 combo on travis
See http://tomcat.apache.org/whichversion.html
> Move CI to Travis
> -----------------
>
> Key: MODCLUSTER-485
> URL: https://issues.jboss.org/browse/MODCLUSTER-485
> Project: mod_cluster
> Issue Type: Task
> Components: Core & Container Integration (Java)
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Fix For: 2.0.0.Alpha1
>
>
> -I ran into this while adding support for Tomcat 9.-
> -What the CI should be testing, give the number of JDKs and different container versions that we support, we should build with respective jdks and versions:-
> -jdk6 + mvn verify -PTC6-
> -jdk7 + mvn verify -PTC7-
> -jdk7 + mvn verify -PAS7-
> -jdk8 + mvn verify -PTC8-
> -jdk7/8 + mvn verify-
> The situation has changed since original proposal fixing CI with proper dependencies for tomcat versions. Taking into account support for legacy containers has been dropped in master, so now we have desired combinations:
> * jdk7 + jdk8 and default profile (excludes Tomcat 9) -> 3 combos on travis
> * jdk 8 + Tomcat 9 profile -> 1 combo on travis
> See http://tomcat.apache.org/whichversion.html
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
[JBoss JIRA] (MODCLUSTER-307) Issues using mod_cluster with Tomcat 6 and Executor thread pools
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-307?page=com.atlassian.jira.pl... ]
Radoslav Husar commented on MODCLUSTER-307:
-------------------------------------------
Tried to reproduce on Tomcat 7 with current master and couldn't reproduce the issue anymore.
> Issues using mod_cluster with Tomcat 6 and Executor thread pools
> ----------------------------------------------------------------
>
> Key: MODCLUSTER-307
> URL: https://issues.jboss.org/browse/MODCLUSTER-307
> Project: mod_cluster
> Issue Type: Bug
> Affects Versions: 1.2.1.Final
> Environment: -Tomcat 6
> -mod_cluster 1.2
> Reporter: Aaron Ogburn
> Priority: Minor
>
> mod_cluster cannot properly determine connector pool statistics from Tomcat 6 when using an Executor thread pool. It fails with the following exception:
> ERROR ContainerBackgroundProcessor[StandardEngine[Catalina]] org.apache.catalina.core.ContainerBase - Exception invoking periodic operation:
> java.lang.IllegalStateException
> at org.jboss.modcluster.container.catalina.CatalinaEngine.getProxyConnector(CatalinaEngine.java:153)
> at org.jboss.modcluster.ModClusterService.connectionEstablished(ModClusterService.java:306)
> at org.jboss.modcluster.mcmp.impl.DefaultMCMPHandler.status(DefaultMCMPHandler.java:372)
> at org.jboss.modcluster.mcmp.impl.DefaultMCMPHandler.status(DefaultMCMPHandler.java:347)
> at org.jboss.modcluster.ModClusterService.status(ModClusterService.java:460)
> at org.jboss.modcluster.container.catalina.CatalinaEventHandlerAdapter.lifecycleEvent(CatalinaEventHandlerAdapter.java:239)
> at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:142)
> at org.apache.catalina.core.ContainerBase.backgroundProcess(ContainerBase.java:1385)
> at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1649)
> at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.run(ContainerBase.java:1638)
> at java.lang.Thread.run(Thread.java:619)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months