[
https://issues.jboss.org/browse/MODCLUSTER-349?page=com.atlassian.jira.pl...
]
Michal Babacek commented on MODCLUSTER-349:
-------------------------------------------
@ [~jfclere] Hmm...yes, MAXMESSSIZE can't be configured, but I'm not using that
directive in my test either:
[
mod_cluster.conf|https://gist.github.com/Karm/343bfd9b2ccc921bd458#file-m...].
{quote}
The patch just corrects the fact that messages where cut before their end in some cases.
{quote}
IMHO, it does not do that - the 500aliases message was cut off, because
{code}
#define MAXMESSSIZE 8192
{code}
is not enough.
In favour of this rule: [Pull Request Or
STFU|https://www.dropbox.com/s/n58q8nk1qi3ijrh/pull-request-or-stfu.png], I suggest this
patch: [
https://github.com/modcluster/mod_cluster/pull/44]
I tested it on RHEL6 x86_64 and it passed the test described in my [previous
comment|https://issues.jboss.org/browse/MODCLUSTER-349?focusedCommentId=1...]
with 500 aliases. I haven't tried any regression/compatibility test though...
What do you think about it? Could it have any nasty side effects?
BTW: I did {{maxbufsiz = maxbufsiz + (...}}, whereas in 1.2.x branch, there is:
{{maxbufsiz = bufsiz + (}} on [line
2589|https://github.com/modcluster/mod_cluster/blob/1.2.x/native/mod_mana...],
but {{bufsiz}}, at this point, is 0, right? Hmm... THX for comments.
mod_manager truncates ENABLE-APP messages
-----------------------------------------
Key: MODCLUSTER-349
URL:
https://issues.jboss.org/browse/MODCLUSTER-349
Project: mod_cluster
Issue Type: Bug
Affects Versions: MOD_CLUSTER_1_0_10_GA_CP04, 1.2.4.Final
Environment: Windows Server 2008
JBoss EAP 5.1.0
EWS 1.0.1
Reporter: Gregory Lardiere
Assignee: Jean-Frederic Clere
Fix For: 1.2.5.Final
Attachments: ModCluster349.java, mod_cluster.patch
With lots of aliases, ENABLE-APP messages can be big enough to span several IP packets.
Sometimes, mod_manager will read only the first packet.
The message is therefore incomplete and mod_cluster configuration ends up corrupted :
some aliases are missing and the context-root is replaced by "/".
This is caused by a wrong usage of ap_get_brigade() : it's called only once whereas
it should be called until there's nothing left to read (see the attached patch).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira