[
https://issues.jboss.org/browse/MODCLUSTER-621?page=com.atlassian.jira.pl...
]
Jean-Frederic Clere commented on MODCLUSTER-621:
------------------------------------------------
Yes good catch the code is obviously brokenI don't think a CONFIG message would cause
a problem but ENABLE-APP for a webapp with multi alias might fail...
maxbufsize doesn't include JVMROUTESZ
-------------------------------------
Key: MODCLUSTER-621
URL:
https://issues.jboss.org/browse/MODCLUSTER-621
Project: mod_cluster
Issue Type: Bug
Components: Native (httpd modules)
Reporter: Robert Bost
Assignee: Jean-Frederic Clere
https://github.com/modcluster/mod_proxy_cluster/blob/master/native/mod_ma...
{code}
if (mconf->maxmesssize)
maxbufsiz = mconf->maxmesssize;
else {
/* we calculate it */
maxbufsiz = 9 + JVMROUTESZ;
maxbufsiz = bufsiz + (mconf->maxhost * HOSTALIASZ) + 7;
maxbufsiz = bufsiz + (mconf->maxcontext * CONTEXTSZ) + 8;
}
if (maxbufsiz< MAXMESSSIZE)
maxbufsiz = MAXMESSSIZE;
buff = apr_pcalloc(r->pool, maxbufsiz);
{code}
It looks like {{maxbufsize}} will never include the {{9+JVMROUTESZ}} since it overwritten
with new value in following line. Is this a problem?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)