On Wed, 24 Jul 2019 at 04:45, Alec Henninger <ahenning(a)redhat.com> wrote:
Hi all,
I wrote a bug report for UNDERTOW-1573:
https://issues.jboss.org/browse/UNDERTOW-1573
I'm happy to contribute a fix, however I'm not an expert in Undertow so
wanted to run by the dev list first.
A few things come to mind:
- Why are request attributes cleared at all? Can we keep them and let them
be GC'd later?
- If they do need to be cleared, could the clearing itself be done via an
exchange completion listener (assuming we can add it late and be sure it
will run after the access log completion listener)?
I don't really think they need to be cleared, and this was done so long ago
I can't remember the reason for this. I think it is likely ok to just
delete that line.
Stuart
Thanks!
Alec
--
ALEC HENNINGER
HE/HIM/HIS
SR. SOFTWARE APPLICATIONS ENGINEER
Raleigh, NC
mobile: 570-856-2428
irc: alec
<
https://red.ht/sig>
_______________________________________________
undertow-dev mailing list
undertow-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/undertow-dev