Hi, So this is a minor issue, but it annoys me so I thought I would see what other people think about it. In the test suite I have noticed that some new code is being added under the org.wildfly package, even though all the existing code is still under org.jboss.as <http://org.jboss.as>;. I don't think this is a good idea, as it means there is two potential places to look for something, with no real reason why something is in a particular package other than the date it was added. I propose that we move all the org.wildfly code into org.jboss.as <http://org.jboss.as> to keep everything consistent (moving everything to org.wildfly would also be an option, but it has implications for backporting and has the potential to create a lot more work). Does anyone have any objections to this? If not I will prepare some PR's. Stuart _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev

I mean for maven modules in the Wildfly code base that were using the org.jboss.as <http://org.jboss.as> package, and are now using a mix of the two. Stuart On Mon, Apr 3, 2017 at 7:18 PM, Darran Lofthouse <darran.lofthouse(a)jboss.com <mailto:darran.lofthouse@jboss.com>> wrote: Is this just for code added to existing testsuite projects or new projects as well? If the latter may be better to coordinate a suitable time with Kabir a change like this could be applied. Regards, Darran Lofthouse. On 03/04/17 02:45, Stuart Douglas wrote: Hi, So this is a minor issue, but it annoys me so I thought I would see what other people think about it. In the test suite I have noticed that some new code is being added under the org.wildfly package, even though all the existing code is still under org.jboss.as <http://org.jboss.as> <http://org.jboss.as>;. I don't think this is a good idea, as it means there is two potential places to look for something, with no real reason why something is in a particular package other than the date it was added. I propose that we move all the org.wildfly code into org.jboss.as <http://org.jboss.as> <http://org.jboss.as> to keep everything consistent (moving everything to org.wildfly would also be an option, but it has implications for backporting and has the potential to create a lot more work). Does anyone have any objections to this? If not I will prepare some PR's. Stuart _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/wildfly-dev <https://lists.jboss.org/mailman/listinfo/wildfly-dev> _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev

From: "Stuart Douglas" <stuart.w.douglas(a)gmail.com&gt; To: wildfly-dev(a)lists.jboss.org Sent: Monday, April 3, 2017 3:45:59 AM Subject: [wildfly-dev] Mixing org.jboss.as and org.wildfly packages Hi, So this is a minor issue, but it annoys me so I thought I would see what other people think about it. In the test suite I have noticed that some new code is being added under the org.wildfly package, even though all the existing code is still under org.jboss.as . I don't think this is a good idea, as it means there is two potential places to look for something, with no real reason why something is in a particular package other than the date it was added. I propose that we move all the org.wildfly code into org.jboss.as to keep everything consistent (moving everything to org.wildfly would also be an option, but it has implications for backporting and has the potential to create a lot more work). Does anyone have any objections to this? If not I will prepare some PR's. Stuart _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev

If you are specifically talking about the testsuite/elytron module, I believe we can leave those under org.wildfly.test.integration.elytron. Stuart's gripe, as I read it, is mixing of the two packages within a module. > On 6 Apr 2017, at 07:56, Josef Cacek <jcacek(a)redhat.com&gt; wrote: > > I think, Tomaz should share his view (CC-ing) > > During our discussion related to Elytron testing, his preference was to use org.wildfly package names. > > -- Josef > > ----- Original Message ----- >> From: "Stuart Douglas" <stuart.w.douglas(a)gmail.com&gt; >> To: wildfly-dev(a)lists.jboss.org >> Sent: Monday, April 3, 2017 3:45:59 AM >> Subject: [wildfly-dev] Mixing org.jboss.as and org.wildfly packages >> >> Hi, >> >> So this is a minor issue, but it annoys me so I thought I would see what >> other people think about it. In the test suite I have noticed that some new >> code is being added under the org.wildfly package, even though all the >> existing code is still under org.jboss.as . >> >> I don't think this is a good idea, as it means there is two potential places >> to look for something, with no real reason why something is in a particular >> package other than the date it was added. >> >> I propose that we move all the org.wildfly code into org.jboss.as to keep >> everything consistent (moving everything to org.wildfly would also be an >> option, but it has implications for backporting and has the potential to >> create a lot more work). >> >> Does anyone have any objections to this? If not I will prepare some PR's. >> >> Stuart >> >> _______________________________________________ >> wildfly-dev mailing list >> wildfly-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/wildfly-dev > _______________________________________________ > wildfly-dev mailing list > wildfly-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/wildfly-dev _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev

Well I am all for using new packages and don't mind mixing them. I consider org.jboss.as.testsuite.* packages as legacy and ridden with problems as they usually contain most problematic testsuite code that should need deeper look into, I know that is not 100% accurate but still holds up to a point.

Said all that, I do agree that if same test functionality already exists in either parent package it should stay there, or if new stuff is added and author wants to add it to new package, it should also result in migrating all other classes into same package.

-- tomaz On Thu, Apr 6, 2017 at 11:12 PM, Stuart Douglas < stuart.w.douglas(a)gmail.com&gt; wrote: > Yes, I am only talking about existing test suite modules that are already > using the org.jboss.as package. > > For example in integration/basic we now have > 'org.wildfly.test.integration.ejb' and 'org.jboss.as.test.integration.ejb', > which are logically the same package, but now you have two different places > to look for ejb tests. > > Stuart > > On Thu, Apr 6, 2017 at 8:06 PM, Kabir Khan <kabir.khan(a)jboss.com&gt; wrote: > >> If you are specifically talking about the testsuite/elytron module, I >> believe we can leave those under org.wildfly.test.integration.elytron. >> Stuart's gripe, as I read it, is mixing of the two packages within a module. >> > On 6 Apr 2017, at 07:56, Josef Cacek <jcacek(a)redhat.com&gt; wrote: >> > >> > I think, Tomaz should share his view (CC-ing) >> > >> > During our discussion related to Elytron testing, his preference was >> to use org.wildfly package names. >> > >> > -- Josef >> > >> > ----- Original Message ----- >> >> From: "Stuart Douglas" <stuart.w.douglas(a)gmail.com&gt; >> >> To: wildfly-dev(a)lists.jboss.org >> >> Sent: Monday, April 3, 2017 3:45:59 AM >> >> Subject: [wildfly-dev] Mixing org.jboss.as and org.wildfly packages >> >> >> >> Hi, >> >> >> >> So this is a minor issue, but it annoys me so I thought I would see >> what >> >> other people think about it. In the test suite I have noticed that >> some new >> >> code is being added under the org.wildfly package, even though all the >> >> existing code is still under org.jboss.as . >> >> >> >> I don't think this is a good idea, as it means there is two potential >> places >> >> to look for something, with no real reason why something is in a >> particular >> >> package other than the date it was added. >> >> >> >> I propose that we move all the org.wildfly code into org.jboss.as to >> keep >> >> everything consistent (moving everything to org.wildfly would also be >> an >> >> option, but it has implications for backporting and has the potential >> to >> >> create a lot more work). >> >> >> >> Does anyone have any objections to this? If not I will prepare some >> PR's. >> >> >> >> Stuart >> >> >> >> _______________________________________________ >> >> wildfly-dev mailing list >> >> wildfly-dev(a)lists.jboss.org >> >> https://lists.jboss.org/mailman/listinfo/wildfly-dev >> > _______________________________________________ >> > wildfly-dev mailing list >> > wildfly-dev(a)lists.jboss.org >> > https://lists.jboss.org/mailman/listinfo/wildfly-dev >> >> >> _______________________________________________ >> wildfly-dev mailing list >> wildfly-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/wildfly-dev >> > > > _______________________________________________ > wildfly-dev mailing list > wildfly-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/wildfly-dev >