[JBoss JIRA] Closed: (CDI-76) JavaDocs regarding adding scopes are weak
by Pete Muir (JIRA)
[ https://issues.jboss.org/browse/CDI-76?page=com.atlassian.jira.plugin.sys... ]
Pete Muir closed CDI-76.
------------------------
Assignee: Pete Muir
Fix Version/s: 1.1 (Confirmed)
(was: 1.1 (Proposed))
Resolution: Done
> JavaDocs regarding adding scopes are weak
> -----------------------------------------
>
> Key: CDI-76
> URL: https://issues.jboss.org/browse/CDI-76
> Project: CDI Specification Issues
> Issue Type: Clarification
> Components: Javadoc and API, Portable Extensions
> Affects Versions: 1.0
> Reporter: Lincoln Baxter III
> Assignee: Pete Muir
> Fix For: 1.1 (Confirmed)
>
>
> JavaDocs for adding scopes via the eventing API are a bit weak.
> public void addScope(@Observes final BeforeBeanDiscovery event)
> {
> event.addScope(ProjectScoped.class, true, false);
> }
> Currently it is not clear that using this method is only required when not using the @NormalScoped annotation, and that it will in fact override the annotation if present. Additional docs should probably be placed on both sides of this relationship, to that affect.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] Commented: (CDI-44) Clarify that interceptors must be implemented using subclassing, and clarify the behaviour of self-invocation
by Pete Muir (JIRA)
[ https://issues.jboss.org/browse/CDI-44?page=com.atlassian.jira.plugin.sys... ]
Pete Muir commented on CDI-44:
------------------------------
I don't think we should actually put down how they are impl'd but describe required effects.
> Clarify that interceptors must be implemented using subclassing, and clarify the behaviour of self-invocation
> -------------------------------------------------------------------------------------------------------------
>
> Key: CDI-44
> URL: https://issues.jboss.org/browse/CDI-44
> Project: CDI Specification Issues
> Issue Type: Clarification
> Components: Interceptors
> Affects Versions: 1.0
> Reporter: Stuart Douglas
> Fix For: 1.1 (Proposed)
>
>
> When implementing interception using proxying the behaour of self invocation is quite well defined, if a method is invoked on the proxy it is intercepted, if it is invoked on the actual bean (usually through self-invocation) it is not.
> When implementing interception though sub classing this is much less well definied, and the only way to track if an invocation is intercepted or not is through a thread local flag. At the moment in weld this is reset when a call is made on a client proxy, so if we have an intercepted bean A and a SessionScoped bean B and A invokes B when invokes A the second call to A is intercepted. If however B is pseudo scoped, then the second invocation is not intercepted. The correct behaviour here should be specified by the specification.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] Assigned: (CDI-44) Clarify that interceptors must be implemented using subclassing, and clarify the behaviour of self-invocation
by Pete Muir (JIRA)
[ https://issues.jboss.org/browse/CDI-44?page=com.atlassian.jira.plugin.sys... ]
Pete Muir reassigned CDI-44:
----------------------------
Assignee: Marius Bogoevici
> Clarify that interceptors must be implemented using subclassing, and clarify the behaviour of self-invocation
> -------------------------------------------------------------------------------------------------------------
>
> Key: CDI-44
> URL: https://issues.jboss.org/browse/CDI-44
> Project: CDI Specification Issues
> Issue Type: Clarification
> Components: Interceptors
> Affects Versions: 1.0
> Reporter: Stuart Douglas
> Assignee: Marius Bogoevici
> Fix For: 1.1 (Proposed)
>
>
> When implementing interception using proxying the behaour of self invocation is quite well defined, if a method is invoked on the proxy it is intercepted, if it is invoked on the actual bean (usually through self-invocation) it is not.
> When implementing interception though sub classing this is much less well definied, and the only way to track if an invocation is intercepted or not is through a thread local flag. At the moment in weld this is reset when a call is made on a client proxy, so if we have an intercepted bean A and a SessionScoped bean B and A invokes B when invokes A the second call to A is intercepted. If however B is pseudo scoped, then the second invocation is not intercepted. The correct behaviour here should be specified by the specification.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years