Re: [forge-dev] [core] FORGE-874: Proxy settings not used for maven web project (#314)

Hi Max, I don't think so. That feature should be present in the JBT Forge Eclipse plugin. Koen, thoughts ? On 05/02/2013 06:49 AM, Max Rydahl Andersen wrote: > on a sidenote - does Forge when running in eclipse use eclipse proxy settings ? > > /max > > On Tue, Apr 30, 2013 at 08:42:09AM -0400, George Gastaldi wrote: >> +1, there's a package named "observers" in the shell project (https://github.com/forge/core/tree/master/shell/src/main/java/org/jboss/f...) >> >> Just add this observer there. >> >> Em 30/04/2013, às 09:32, "Lincoln Baxter, III" <lincolnbaxter(a)gmail.com&gt; escreveu: >> >>> Thoughts? >>> >>> --- >>> Lincoln Baxter's Droid >>> http://ocpsoft.org >>> "Keep it Simple" >>> >>> ---------- Forwarded message ---------- >>> From: "Lincoln Baxter, III" <lincolnbaxter(a)gmail.com&gt; >>> Date: Apr 30, 2013 8:31 AM >>> Subject: Re: [core] FORGE-874: Proxy settings not used for maven web project (#314) >>> To: "forge/core" <reply+i-13796837-9f0837d6c9164cfde977b60d4c0f19df2d4d9f6b-362329(a)reply.github.com&gt; >>> Cc: "forge/core" <core(a)noreply.github.com&gt; >>> >>> Now that I see what you did to fix this, I think this makes sense to do earlier in the forge life cycle. I don't see why it should be tied either to projects or to plugins, do you? >>> >>> This should probably go into an @Observes PostStartup event method. Somewhere in the core. >>> >>> Wdyt? >>> >>> --- >>> Lincoln Baxter's Droid >>> http://ocpsoft.org >>> "Keep it Simple" >>> >>> On Apr 30, 2013 4:33 AM, "Yann Albou" <notifications(a)github.com&gt; wrote: >>>> You can merge this Pull Request by running >>>> >>>> git pull https://github.com/myannou/forge-core FORGE-874 >>>> Or view, comment on, or merge it at: >>>> >>>> https://github.com/forge/core/pull/314 >>>> >>>> Commit Summary >>>> >>>> FORGE-874: Proxy settings not used for maven web project >>>> File Changes >>>> >>>> M shell/src/main/java/org/jboss/forge/shell/plugins/builtin/ForgePlugin.java (21) >>>> M shell/src/main/java/org/jboss/forge/shell/project/ProjectInitializer.java (26) >>>> Patch Links: >>>> >>>> https://github.com/forge/core/pull/314.patch >>>> https://github.com/forge/core/pull/314.diff >>> _______________________________________________ >>> forge-dev mailing list >>> forge-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/forge-dev >> _______________________________________________ >> forge-dev mailing list >> forge-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/forge-dev > _______________________________________________ > forge-dev mailing list > forge-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/forge-dev -- George Gastaldi | Senior Software Engineer JBoss Forge Team Red Hat _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev