[ https://issues.jboss.org/browse/SEAMFORGE-162?page=com.atlassian.jira.plu... ] Lincoln Baxter III commented on SEAMFORGE-162: ---------------------------------------------- Hi. Thanks for working on this! Could you please send a pull request and link that URL? The link you have provided is just a link to your source tree. Thanks, Lincoln -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFORGE-162?page=com.atlassian.jira.plu... ] Lincoln Baxter III commented on SEAMFORGE-162: ---------------------------------------------- To send a pull request, navigate to https://github.com/includeeasy/core/tree/SEAMFORGE-162 and click the "send pull request" button. Then fill out the subject and description and click send. The encoding may pose a problem. If possible, could you change this to UTF-8 and re-submit? Also, if you could make the following refactoring to the findRange() method: From: {code}public <T> List<T> findRange(Class<T> type,int[] range) {code} To: {code}public <T> List<T> findAll(Class<T> type,int firstResult, int maxResults){code} I think that API will be a little easier to understand, and a little less user-error prone. Thanks! This is good stuff. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFORGE-162?page=com.atlassian.jira.plu... ] Lincoln Baxter III closed SEAMFORGE-162. ---------------------------------------- Assignee: Lincoln Baxter III Done! Thanks for this enhancement! If you have not already, could you please sign this contributors agreement and make sure you have an account on jboss.org? That way I will be able to give you credit for completed issues. https://cla.jboss.org/ Thanks, ~Lincoln -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFORGE-162?page=com.atlassian.jira.plu... ] Lincoln Baxter III commented on SEAMFORGE-162: ---------------------------------------------- Ok. I'll try to find you again, thanks. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira