That actually sounds perfect. As close to the standards we can get, the
better. JLine is great, but it's very qwerky and I really don't like a lot
of their APIs. It seems like a bit of a hack-job IMO. Very clever, but in
great need of refactoring and API breakage.
I'll try to find some time to review this in the near future.
~Lincoln
On Fri, May 11, 2012 at 6:19 PM, "Ståle W. Pedersen"
<spederse(a)redhat.com>wrote:
hi, im not sure what feature you're thinking of, but if its
regarding
jline, it require a proprietary file format to read key bindings.
atm keybindings in jreadline is hard coded to whats default in gnu
readline. the plan with jreadline is to support custom key binding
similar to whats described in gnu readline.
ståle
On 05/11/2012 05:44 PM, Julien Viet wrote:
>
> On May 11, 2012, at 5:07 PM, Ståle W. Pedersen wrote:
>
>> hi, sorry for the late reply, i had some trouble with my vpn.
>> currently jreadline can be found here:
https://github.com/stalep/jreadline
>> ive uploaded it to maven repo via nexus.
>>
>> the pull to integrate it with jboss-cli:
>>
https://github.com/stalep/jboss-as/commit/104912002dfc879a2fc8338e317f88d...
>>
>> regarding
https://issues.jboss.org/browse/FORGE-553 i just tested in
jreadline now and i can type chars like: ã,â,ä,Õ,Ö,õ + ive tested with
norwegian chars like å,ø,æ.
>> - let me know if any of you have tested it with these chars and have
different result.
>>
>> regarding the key benefits ill say it has a better key handling, vi(!!)
and emacs mode, undo, redo, easy to configure with different settings,
partial completes (similar to bash), ++
>> - no more files thats read to enable key bindings (in the future ill
support changing key bindings by inputrc).
>
> can you explain what feature it is because I'm not able to understand
fully what you mean
>
>>
>> some of the issues that's found in jline/jline2 with multiple line
breaks is working in jreadline.
>> - im not saying jreadline is without bugs, but if/when you find any or
have any feature requests ill try to respond quickly.
>>
>> regards, ståle
>> ps: just to be clear, i started jreadline because i was tired of seeing
many pull requests to jline/jline2 being ignored for a long time. so one
weekend i sat down and started this...
>>
>>
>> On 05/10/2012 06:14 PM, Julien Viet wrote:
>>> is it available on maven central ?
>>>
>>> On May 10, 2012, at 5:54 PM, Lincoln Baxter wrote:
>>>
>>>> Copying the forge Dev list and Julien, since he may also be
interested.
>>>>
>>>> ----- Original Message -----
>>>> From: "Lincoln Baxter"<lbaxter(a)redhat.com>
>>>> To: "Ståle W. Pedersen"<spederse(a)redhat.com>
>>>> Cc: "Mike Brock"<cbrock(a)redhat.com>, "Alexey
Loubyansky"<
alexey.loubyansky(a)redhat.com>
>>>> Sent: Thursday, May 10, 2012 11:26:46 AM
>>>> Subject: Re: jreadline
>>>>
>>>> Awesome! I'd love to start trying to integrate this instead of
jline.
What are some key benefits that you can think of?
>>>>
>>>> Where can I get the code and get started playing around?
>>>>
>>>> ~Lincoln
>>>>
>>>> ----- Original Message -----
>>>> From: "Ståle W. Pedersen"<spederse(a)redhat.com>
>>>> To: "Lincoln Baxter"<lbaxter(a)redhat.com>
>>>> Cc: "Mike Brock"<cbrock(a)redhat.com>, "Alexey
Loubyansky"<
alexey.loubyansky(a)redhat.com>
>>>> Sent: Thursday, May 10, 2012 8:15:26 AM
>>>> Subject: Re: jreadline
>>>>
>>>> hi, not sure if you follow the jboss-as7-dev list so i just wanted to
>>>> inform you that we're in the process of switching to jreadline for
>>>> jboss-cli.
>>>>
>>>> im not sure if you think it would be a good fit for forge too? i know
>>>> that you've almost "forked" jline into forge and done some
extensions
to
>>>> it.
>>>> - for jreadline i took the code mike wrote for console input to more
>>>> easily support different keystrokes etc.
>>>>
>>>> ill happily make extensions/changes to jreadline if you have any
requests.
>>>>
>>>> regards, ståle
>>>>
>>>> On 11/30/2011 05:08 PM, Lincoln Baxter wrote:
>>>>> Hey Ståle,
>>>>>
>>>>> This is interesting timing, because Mike Brock actually just forked
JLine because we could no longer achieve what we needed to within the
constraints of their framework (again, not responding to pull requests or
releasing new versions.)
>>>>>
>>>>> I'm certainly interested in this! What kinds of bugs have you
fixed?
>>>>>
>>>>> However, mike has made some significant enhancements (such as full
double-buffering) that you might be interested in as well, and I would
definitely like to see convergence in this space within JBoss. Perhaps it
is worth creating a new module for the "JBoss Shell" fork? We were already
planning on doing this as part of Forge 2.0, but we could accelerate if
needed.
>>>>>
>>>>> I'd propose that Forge itself is the right project to
"own" this
combined sub-project, because it is a fully-blown shell implementation, as
that is of of its primary functions. This way it would also get lots of
attention from the community in a top-level project.
>>>>>
>>>>> Mike, would you be interested in that? This would mean a much
quicker realization of our shell/forge conceptual split. I think it could
be done relatively easily with your help.
>>>>>
>>>>> What do you think? We should include Aleksei in this thread if you
feel it would be appropriate.
>>>>>
>>>>> ~Lincoln
>>>>>
>>>>> ----- Original Message -----
>>>>> From: "Ståle W. Pedersen"<spederse(a)redhat.com>
>>>>> To: lbaxter(a)redhat.com
>>>>> Sent: Monday, November 28, 2011 2:18:48 PM
>>>>> Subject: jreadline
>>>>>
>>>>> hi, ive been working on a little "evening" project for
some time
called
>>>>> jreadline (
https://github.com/stalep/jreadline). it started as an
>>>>> attempt to add vi bindings to jline, but they never applied any of
the
>>>>> patches i sent them so i eventually started my own little project.
>>>>>
>>>>> it is starting to be mature enough to consider it for actual use so
im
>>>>> wondering what kind of requirements you have for jline and if you
would
>>>>> consider using jreadline for forge?
>>>>> to be "compatible" with jline ive used similar api, but if
you have
any
>>>>> special requests im glad for any input.
>>>>>
>>>>> ive talked a bit with aleksey and he's considering using it for
jboss cli.
>>>>>
>>>>> ive tested jreadline on linux/osx and windows and some of the
"known"
>>>>> issues with jline/jline2 are not present in jreadline (although im
not
>>>>> saying it bug free :)
>>>>>
>>>>> ståle
>>>>
>>>>
>>>> --
>>>> JBoss Performance Team Lead
>>>> JBoss by Red Hat
>>>
>>
>> --
>> JBoss Performance Team Lead
>> JBoss by Red Hat
>
--
JBoss Performance Team Lead
JBoss by Red Hat
_______________________________________________
forge-dev mailing list
forge-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/forge-dev