[ https://issues.jboss.org/browse/SEAMFORGE-187?page=com.atlassian.jira.plu... ] Tim Pedone commented on SEAMFORGE-187: -------------------------------------- One issue with reusing the existing plugin is that some of the options don't apply to pom projects. In particular are the createMain and FinalName options. Also the topLevelPackage option should really be GroupId for a pom although I guess we could solve that with a little more info in the help text so it's obvious that "topLevelPackage" = "GroupId". On Mon, May 16, 2011 at 10:25 PM, Lincoln Baxter, III Hmmm, that is a good point. For now however, for simplicities sake, let's use the PackagingType enum to enable selection, and only use the '--createMain' command if the project is a JAR or WAR. For --finalName, I think we can leave that safely? For --topLevelPackage, I agree, let's just add a better description. In fact, there is another issue with this that involves java keywords, so we should probably address these at the same time: https://issues.jboss.org/browse/SEAMFORGE-167 We might actually want to add a check in the NewProjectPlugin that verifies if the groupId is a valid java package. If not, we can offer to keep the groupId but let the user specify a new, legal, java package name for the topLevelPackage. Thoughts? ~Lincoln I think that GroupId should be explicit. So maybe add GroupId as a required param and make topLevelPackage an option that defaults to GroupId and is only applicable for non-pom projects. So the user would be required to enter the project name and group id. If this is a pom project then we'd proceed to create it. If this is a non-pom (jar, war, ear, etc.) then if they did not enter topLevelPackage, we'd prompt for it with a default of the GroupId. By keeping them separate we can also use different validation rules so you could have a GroupId that uses java reserved words but then you'd have to specify a different topLevelPackage. On Tue, May 17, 2011 at 10:02 AM, Lincoln Baxter, III Yes, we are on the same page here as long as JAR projects are still the default. ~Lincoln -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFORGE-187?page=com.atlassian.jira.plu... ] Lincoln Baxter III closed SEAMFORGE-187. ---------------------------------------- Fix Version/s: 1.0.0.Alpha4 Resolution: Done -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira