1:55 p.m.
Dependency Resolution fails for non-jar artifacts
-------------------------------------------------
Key: SEAMFORGE-170
URL: https://issues.jboss.org/browse/SEAMFORGE-170
Project: Seam Forge
Issue Type: Bug
Components: Builtin Plugins
Affects Versions: 1.0.0.Alpha3
Reporter: Tim Pedone
RepositoryLookup methods that resolve artifacts fail for non-jar artifacts. The issue
seems to stem from the DependencyBuild.toId() method which returns the GAV coordinates for
the artifact but omits the packaging type so even if pom or some other package type is
passed in, it's stripped resulting in the Maven runtime defaulting to jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:45 a.m.
New subject: [JBoss JIRA] Assigned: (SEAMFORGE-170) Dependency Resolution fails for non-jar artifacts
[
https://issues.jboss.org/browse/SEAMFORGE-170?page=com.atlassian.jira.plu...
]
Lincoln Baxter III reassigned SEAMFORGE-170:
--------------------------------------------
Assignee: Lincoln Baxter III
Dependency Resolution fails for non-jar artifacts
-------------------------------------------------
Key: SEAMFORGE-170
URL: https://issues.jboss.org/browse/SEAMFORGE-170
Project: Seam Forge
Issue Type: Bug
Components: Builtin Plugins
Affects Versions: 1.0.0.Alpha3
Reporter: Tim Pedone
Assignee: Lincoln Baxter III
RepositoryLookup methods that resolve artifacts fail for non-jar artifacts. The issue
seems to stem from the DependencyBuild.toId() method which returns the GAV coordinates for
the artifact but omits the packaging type so even if pom or some other package type is
passed in, it's stripped resulting in the Maven runtime defaulting to jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:06 a.m.
New subject: [JBoss JIRA] Commented: (SEAMFORGE-170) Dependency Resolution fails for non-jar artifacts
[
https://issues.jboss.org/browse/SEAMFORGE-170?page=com.atlassian.jira.plu...
]
Lincoln Baxter III commented on SEAMFORGE-170:
----------------------------------------------
Do you have a recommendation on how to handle the issue where Depenency Coordinates have
overlapping syntax?
groupId:artifactId:version
groupId:artifactId:classifier
groupId:artifactId:classifier:version
... etc.
Dependency Resolution fails for non-jar artifacts
-------------------------------------------------
Key: SEAMFORGE-170
URL: https://issues.jboss.org/browse/SEAMFORGE-170
Project: Seam Forge
Issue Type: Bug
Components: Builtin Plugins
Affects Versions: 1.0.0.Alpha3
Reporter: Tim Pedone
Assignee: Lincoln Baxter III
RepositoryLookup methods that resolve artifacts fail for non-jar artifacts. The issue
seems to stem from the DependencyBuild.toId() method which returns the GAV coordinates for
the artifact but omits the packaging type so even if pom or some other package type is
passed in, it's stripped resulting in the Maven runtime defaulting to jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:08 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (SEAMFORGE-170) Dependency Resolution fails for non-jar artifacts
[
https://issues.jboss.org/browse/SEAMFORGE-170?page=com.atlassian.jira.plu...
]
Lincoln Baxter III edited comment on SEAMFORGE-170 at 5/23/11 4:06 PM:
-----------------------------------------------------------------------
Do you have a recommendation on how to handle the issue where Depenency Coordinates have
overlapping syntax?
groupId:artifactId:version
groupId:artifactId:classifier
groupId:artifactId:classifier:version
groupId:artifactId:classifier:scope
groupId:artifactId:classifier:scope:version
... etc.
was (Author: lincolnthree):
Do you have a recommendation on how to handle the issue where Depenency Coordinates
have overlapping syntax?
groupId:artifactId:version
groupId:artifactId:classifier
groupId:artifactId:classifier:version
... etc.
Dependency Resolution fails for non-jar artifacts
-------------------------------------------------
Key: SEAMFORGE-170
URL: https://issues.jboss.org/browse/SEAMFORGE-170
Project: Seam Forge
Issue Type: Bug
Components: Builtin Plugins
Affects Versions: 1.0.0.Alpha3
Reporter: Tim Pedone
Assignee: Lincoln Baxter III
RepositoryLookup methods that resolve artifacts fail for non-jar artifacts. The issue
seems to stem from the DependencyBuild.toId() method which returns the GAV coordinates for
the artifact but omits the packaging type so even if pom or some other package type is
passed in, it's stripped resulting in the Maven runtime defaulting to jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:08 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (SEAMFORGE-170) Dependency Resolution fails for non-jar artifacts
[
https://issues.jboss.org/browse/SEAMFORGE-170?page=com.atlassian.jira.plu...
]
Lincoln Baxter III edited comment on SEAMFORGE-170 at 5/23/11 4:06 PM:
-----------------------------------------------------------------------
Do you have a recommendation on how to handle the parsing issue where Depenency
Coordinates have overlapping syntax? We might have to do some icky stuff to get that
working (but I agree it does need to be done.)
groupId:artifactId:version
groupId:artifactId:classifier
groupId:artifactId:classifier:version
groupId:artifactId:classifier:scope
groupId:artifactId:classifier:scope:version
... etc.
was (Author: lincolnthree):
Do you have a recommendation on how to handle the issue where Depenency Coordinates
have overlapping syntax?
groupId:artifactId:version
groupId:artifactId:classifier
groupId:artifactId:classifier:version
groupId:artifactId:classifier:scope
groupId:artifactId:classifier:scope:version
... etc.
Dependency Resolution fails for non-jar artifacts
-------------------------------------------------
Key: SEAMFORGE-170
URL: https://issues.jboss.org/browse/SEAMFORGE-170
Project: Seam Forge
Issue Type: Bug
Components: Builtin Plugins
Affects Versions: 1.0.0.Alpha3
Reporter: Tim Pedone
Assignee: Lincoln Baxter III
RepositoryLookup methods that resolve artifacts fail for non-jar artifacts. The issue
seems to stem from the DependencyBuild.toId() method which returns the GAV coordinates for
the artifact but omits the packaging type so even if pom or some other package type is
passed in, it's stripped resulting in the Maven runtime defaulting to jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:57 a.m.
New subject: [JBoss JIRA] Commented: (SEAMFORGE-170) Dependency Resolution fails for non-jar artifacts
[
https://issues.jboss.org/browse/SEAMFORGE-170?page=com.atlassian.jira.plu...
]
Tim Pedone commented on SEAMFORGE-170:
--------------------------------------
If this notation is used solely within the Seam Forge code, then why not always require
all fields:
groupId:artifactId:classifier:scope:version. If some fields are not used or are defaults,
then keep the pattern the same but leave out the values. So if classifier is not used it
would be:
groupId:artifactId::scope:version
If you only have GAV then:
groupId:artifactId:::version
Another possibility would be to pass a pattern into the toId() methods so the caller can
dictate what pattern they want. Sort of like a printf() statement but with custom
placeholders for GroupId, ArtifactId, etc. For example (toId("%g:%a:%s:%v")
would return groupId:artifactId:Scope:Version)
Another option would be to have two different methods; one that prints the coordinates as
used by code to retrieve an artifact (GAV + classifier + extention) and other for
dependency management (GAV + scope + classifier + type).
Of course we could use combinations of those as well.
Dependency Resolution fails for non-jar artifacts
-------------------------------------------------
Key: SEAMFORGE-170
URL: https://issues.jboss.org/browse/SEAMFORGE-170
Project: Seam Forge
Issue Type: Bug
Components: Builtin Plugins
Affects Versions: 1.0.0.Alpha3
Reporter: Tim Pedone
Assignee: Lincoln Baxter III
RepositoryLookup methods that resolve artifacts fail for non-jar artifacts. The issue
seems to stem from the DependencyBuild.toId() method which returns the GAV coordinates for
the artifact but omits the packaging type so even if pom or some other package type is
passed in, it's stripped resulting in the Maven runtime defaulting to jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:30 p.m.
New subject: [JBoss JIRA] Commented: (SEAMFORGE-170) Dependency Resolution fails for non-jar artifacts
[
https://issues.jboss.org/browse/SEAMFORGE-170?page=com.atlassian.jira.plu...
]
Tim Pedone commented on SEAMFORGE-170:
--------------------------------------
I did some further digging and I think I have a better idea on how to handle this. I
think the issue stems from the fact that Artifacts and Dependencies are not exactly the
same thing. An Artifact has coordinates of the format:
<groupId>:<artifactId>[:<extension>[:<classifier>]]:<version>
Whereas a Dependency has:
<groupId>:<artifactId>[:<extension>[:<classifier>]]:<version>
+ scope + isOptional
The Artifact pattern above is what the Aether DefaultArtifact Constructor uses. We should
adopt that pattern for Artifacts. The Aether Dependency class does not have a constructor
that takes a string; it takes an Artifact and a scope string and isOptional flag. It does
have a toString() method that prints out the format:
<groupId>:<artifactId>[:<extension>[:<classifier>]]:<version>(scope?)
where the ? represents isOptional = true and absence of the ? means isOptional = false.
Since an Artifact is a subset of a Dependency, we can have Dependency.toCoordinates()
return the Artifact pattern and have a different method return the longer Dependency
pattern.
Dependency Resolution fails for non-jar artifacts
-------------------------------------------------
Key: SEAMFORGE-170
URL: https://issues.jboss.org/browse/SEAMFORGE-170
Project: Seam Forge
Issue Type: Bug
Components: Builtin Plugins
Affects Versions: 1.0.0.Alpha3
Reporter: Tim Pedone
Assignee: Lincoln Baxter III
RepositoryLookup methods that resolve artifacts fail for non-jar artifacts. The issue
seems to stem from the DependencyBuild.toId() method which returns the GAV coordinates for
the artifact but omits the packaging type so even if pom or some other package type is
passed in, it's stripped resulting in the Maven runtime defaulting to jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:49 a.m.
New subject: [JBoss JIRA] Commented: (SEAMFORGE-170) Dependency Resolution fails for non-jar artifacts
[
https://issues.jboss.org/browse/SEAMFORGE-170?page=com.atlassian.jira.plu...
]
Lincoln Baxter III commented on SEAMFORGE-170:
----------------------------------------------
I think that before we look at fixing the input issue, the short-term (and probably still
necessary anyway) fix for this is to have Dependency.toCoordinates() return the
fully-qualified groupId:artifactId::classifier:version, with :: representing an omitted
segment.
Dependency Resolution fails for non-jar artifacts
-------------------------------------------------
Key: SEAMFORGE-170
URL: https://issues.jboss.org/browse/SEAMFORGE-170
Project: Seam Forge
Issue Type: Bug
Components: Builtin Plugins
Affects Versions: 1.0.0.Alpha3
Reporter: Tim Pedone
Assignee: Lincoln Baxter III
RepositoryLookup methods that resolve artifacts fail for non-jar artifacts. The issue
seems to stem from the DependencyBuild.toId() method which returns the GAV coordinates for
the artifact but omits the packaging type so even if pom or some other package type is
passed in, it's stripped resulting in the Maven runtime defaulting to jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:51 a.m.
New subject: [JBoss JIRA] Commented: (SEAMFORGE-170) Dependency Resolution fails for non-jar artifacts
[
https://issues.jboss.org/browse/SEAMFORGE-170?page=com.atlassian.jira.plu...
]
Lincoln Baxter III commented on SEAMFORGE-170:
----------------------------------------------
groupId:artifactId:packaging:classifier:version:optional is the maven standard according
to: http://maven.apache.org/pom.html
Dependency Resolution fails for non-jar artifacts
-------------------------------------------------
Key: SEAMFORGE-170
URL: https://issues.jboss.org/browse/SEAMFORGE-170
Project: Seam Forge
Issue Type: Bug
Components: Builtin Plugins
Affects Versions: 1.0.0.Alpha3
Reporter: Tim Pedone
Assignee: Lincoln Baxter III
RepositoryLookup methods that resolve artifacts fail for non-jar artifacts. The issue
seems to stem from the DependencyBuild.toId() method which returns the GAV coordinates for
the artifact but omits the packaging type so even if pom or some other package type is
passed in, it's stripped resulting in the Maven runtime defaulting to jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:57 a.m.
New subject: [JBoss JIRA] Closed: (SEAMFORGE-170) Dependency Resolution fails for non-jar artifacts
[
https://issues.jboss.org/browse/SEAMFORGE-170?page=com.atlassian.jira.plu...
]
Lincoln Baxter III closed SEAMFORGE-170.
----------------------------------------
Fix Version/s: 1.0.0.Alpha4
Resolution: Done
This has been fixed. For now I am requiring that we specify the fully-qualified
coordinates, using :: to denote an omitted property. In the future we may provide an
alternate shorthand syntax, but that's the deal for now.
Dependency Resolution fails for non-jar artifacts
-------------------------------------------------
Key: SEAMFORGE-170
URL: https://issues.jboss.org/browse/SEAMFORGE-170
Project: Seam Forge
Issue Type: Bug
Components: Builtin Plugins
Affects Versions: 1.0.0.Alpha3
Reporter: Tim Pedone
Assignee: Lincoln Baxter III
Fix For: 1.0.0.Alpha4
RepositoryLookup methods that resolve artifacts fail for non-jar artifacts. The issue
seems to stem from the DependencyBuild.toId() method which returns the GAV coordinates for
the artifact but omits the packaging type so even if pom or some other package type is
passed in, it's stripped resulting in the Maven runtime defaulting to jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4731
days inactive
4741
days old
9 comments
2 participants
participants (2)
-
Lincoln Baxter III (JIRA) -
Tim Pedone (JIRA)