Re: [Hawkular-dev] Metric id and url restrictions

On 18/09/15 11:32 AM, John Mazzitelli wrote: Yeah, and the cAdvisor metrics from Heapster also contain slashes, which is where I am seeing the problem right now with OpenShift proxies. Outside of the proxy, then everything works fine with having encoded slashes in the URL, which is why I don't see the issue with my own testing. But it looks like for the UI they may need to use the proxy. Its not just the OpenShift proxies that have this problem, its a common issue with some types proxies and servers as well. I don't know if it really matter here how wildfly does things. Your client should be able to encode the metricid in one format when going into hawkular and then decode when they get things back from hawkular. I don't know what should be the right solution there: 1) we could enforce what is allowed in a metric id field. This means we break backwards compatibility with what we currently have, but it also means that we can open up the door to things like restricting some metrics to some internal only things (see https://issues.jboss.org/browse/HWKMETRICS-208). 2) we keep our current endpoint as is, but add a new endpoint which can do queries via a post (essentially this is just an escape route to get around the issue when dealing with systems like this). So to do the equivalence of: GET http://localhost:8080/hawkular/metrics/gauges/foo%2fbar/data?start=10&... You could do also do something like: POST http://localhost:8080/hawkular/metrics/gauges/data { "metric-id": foo/bar, "start": 10, "end": 110, "buckets":2 } 3) Band-aid solution to fix the immediate problem: update the heapster sink to encode metric ids in a format which does not include the '/' anywhere in it. This doesn't really solve the problem, but it would at least get us past the problem until we come up with a better, more permanent solution. Any thoughts?