Choosing a particular reviewer, naming him in the PR and optionally
pinging him on IRC speeds up the process considerably. Asking everybody
on the list does not necessarily make somebody feel assigned. -- P
On 2016-02-10 18:21, Juraci Paixão Kröhling wrote:
On 10.02.2016 18:14, John Mazzitelli wrote:
> Once a PR is created and we ask for peer-review and merge, how long should be given
to that process before we go ahead and merge the PR?
In theory, one should never merge its own PRs, and PRs should be merged
only after a "looks good to me" :) In some cases, you do have to chase
people, though. And in some cases, you do have to merge your own PRs.
- Juca.
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev