3:47 p.m.
Hi,
I'll be on PTO whole next week, so I am sending the status what is done and what
still needs to be done here:
Inventory 0.3.0 changed the way it deals with escaped characters, we use the @Encoded
annotation in resteasy for path params. This is because of the fact one can pass a path to
the resources that contains slashes as a resource separators, but the resourceIds can have
also slashes in their ids.
This works quite ok, but if the resourceId contains a slash at the end, it doesn't
work.
example:
/inventory/test/resources/parent%2res/child%2fres (ok)
/inventory/test/resources/parent%2f (not - ok) the last slash is lost, even though
it's part of the id
To make it short, agent can't work with the latest inventory and I prepared 2
scenarios:
1) just fix the escaping and forget about all the new features introduced in
inventory/agent:
to make this work just merge https://github.com/hawkular/hawkular-agent/pull/38/ into
agent, release a new version of agent
+ merge the https://github.com/hawkular/hawkular/tree/dev/inventory-0.3.0.Final into
hawkular master with the new version of agent (currently there is agent@snapshot)
2) on the agent side repo merge the
https://github.com/hawkular/hawkular-agent/tree/mazz/hwkagent-5-resourcec... which
contains the logic for inserting the resource configs grabbed from DMR into inventory, has
support for the resource hierarchy, fixes the thing from 1) and moves the resource types
and metric types in the inventory topology under the feed (this is questionable, because
UI has certain issues with it like "give me all the Wildflies" must be
translated into "give me all the feeds and for each feed ask for all the WF
resources" - it's done here http://git.io/vsRXr, but still).
next step for this scenario to work is to merge the PR on the ui-services
http://git.io/vs8Jj and do the appropriate changes in the hawkular/hawkuar ui, I started
this here http://git.io/vsRXr all in all UI works, I saw just some errors when going to
the details page for the urls, but it's definitely fixable within next week, oh and it
depends on my own ui-services version, so once the my PR is merged into ui-services, this
(http://git.io/vs04A) can go away
I vote for 2) of course :]
Just a comment to the resource hierarchy:
currently, the agent considers all the resources equal (flat structure) and the hierarchy
is captured by the prefixes, like "~/", "~/foo",
"~/foo~bar", etc.
The change in the
https://github.com/hawkular/hawkular-agent/tree/mazz/hwkagent-5-resourcec... branch
preserves the ids, but adds the real structure among them on the inventory level.
2lkrejci: this is bad wrt resource hierarchy rest api
https://github.com/angular/angular.js/issues/1388 (but they say it should be possible
somehow using http://git.io/vs02W)
sorry for lack of the structure, it was more a brain dump.
jk