6:51 a.m.
I found two bugs in the Hawkular Go Client and I need assistance:
1. https://github.com/hawkular/hawkular-client-go/issues/10
2. https://github.com/hawkular/hawkular-client-go/issues/12
The first one I have a PR written that appears to fix it (link to PR in the issue). I
would need someone to peer review it and merge it if it is OK. Frankly, I don't see
how it ever worked - but I suspect that Hawkular Metrics changed the REST API recently in
this area and that's why it wasn't seen before.
The second one I do not have a PR, but in the issue I mention a quick and dirty fix, but I
don't think it is the proper way to fix it. I need someone to look at that issue and
recommend a proper fix. Just need a way or a GoLang API that encodes a string for a URL
*path* (not for a URL query string, which is happening here) due to the different ways
spaces are encoded. I'd do it myself, but it's really late, and I have to get up
early to hopefully meet up with a turkey that is "dying" to make it on my dinner
table. Bu Wa Ha... BU WA HAHAHAHAHAHA! :)
That is all.
--John Mazz
11:08 a.m.
Hi,
I replied to both of your issues. Short story here:
1. The old behavior should work, as we promised so in the
HWKMETRICS-385. If it does not, then there's a bug in the
Hawkular-Metrics, not in the client. We can change this method signature
in new versions, but that old API must work (and the tests against
HWKMETRICS work also, so I couldn't replicate your bug yet)
2. There's no proper fix for this Golang bug. There's only workarounds
and the one you suggested is the one that's used in almost every Golang
application that can have whitespace in the URLs. Golang's net/url
package is just .. crap and can't follow many standards.
- Micke
On 10/29/2016 07:51 AM, John Mazzitelli wrote:
I found two bugs in the Hawkular Go Client and I need assistance:
1. https://github.com/hawkular/hawkular-client-go/issues/10
2. https://github.com/hawkular/hawkular-client-go/issues/12
The first one I have a PR written that appears to fix it (link to PR in the issue). I
would need someone to peer review it and merge it if it is OK. Frankly, I don't see
how it ever worked - but I suspect that Hawkular Metrics changed the REST API recently in
this area and that's why it wasn't seen before.
The second one I do not have a PR, but in the issue I mention a quick and dirty fix, but
I don't think it is the proper way to fix it. I need someone to look at that issue and
recommend a proper fix. Just need a way or a GoLang API that encodes a string for a URL
*path* (not for a URL query string, which is happening here) due to the different ways
spaces are encoded. I'd do it myself, but it's really late, and I have to get up
early to hopefully meet up with a turkey that is "dying" to make it on my dinner
table. Bu Wa Ha... BU WA HAHAHAHAHAHA! :)
That is all.
--John Mazz
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
1:22 p.m.
1. The old behavior should work, as we promised so in the
HWKMETRICS-385. If it does not, then there's a bug in the
Hawkular-Metrics, not in the client. We can change this method signature
in new versions, but that old API must work (and the tests against
HWKMETRICS work also, so I couldn't replicate your bug yet)
OK. I noticed the tests in client worked for both. I couldn't understand why. Now I
know :) Didn't know about that JIRA.
I'll try to replicate my problem and see what's going on - I was definitely
getting an error code from H-Metrics until I ran with my PR code.
2. There's no proper fix for this Golang bug. There's only
workarounds
and the one you suggested is the one that's used in almost every Golang
application that can have whitespace in the URLs. Golang's net/url
package is just .. crap and can't follow many standards.
That is --- unfortunate. I'd implement my stupid fix but, what happens if there is a
literal "+" in the string? Bah... "just don't use spaces in tag
names" seems extreme though.
3:34 a.m.
> 1. The old behavior should work, as we promised so in the
> HWKMETRICS-385. If it does not, then there's a bug in the
> Hawkular-Metrics, not in the client. We can change this method signature
> in new versions, but that old API must work (and the tests against
> HWKMETRICS work also, so I couldn't replicate your bug yet)
OK. I noticed the tests in client worked for both. I couldn't understand why.
Now I know :) Didn't know about that JIRA.
I'll try to replicate my problem and see what's going on - I was definitely
getting an error code from H-Metrics until I ran with my PR code.
I replicated the problem. It is a bug in the hawkular Go client - see:
https://github.com/hawkular/hawkular-client-go/issues/10
Short story - if tags have spaces in their values, Go client builds a bad DELETE URL and
the delete fails with a 400
I submitted a second PR - but I don't know if that would be backward compatible
either. So there are two PRs that fix this problem, but I don't know if either one is
good enough. But somehow we need to fix this, or else we cannot support tags with spaces
in their values (this is different than the issue where spaces are in their NAMES).
> 2. There's no proper fix for this Golang bug. There's
only workarounds
> and the one you suggested is the one that's used in almost every Golang
> application that can have whitespace in the URLs. Golang's net/url
> package is just .. crap and can't follow many standards.
That is --- unfortunate. I'd implement my stupid fix but, what happens if
there is a literal "+" in the string? Bah... "just don't use spaces in
tag
names" seems extreme though.
Just to be clear, this is different than the above because here we are talking about
spaces in the tag NAMES.
So, as of right now, the Go client cannot support tag names OR values with spaces in them.
That's going to be a limitation we need to document, unless we fix these two issues.
I'll leave that up to Micke how best to solve these - because this involves backward
compatibility issues with older Hawkular Metrics servers and he'd know best what to do
there. I have two PRs for the first one, and a suggested fix documented in the github
issue for the second - but I don't know if any are good enough to push to master.
3:41 a.m.
Just to be clear, this is different than the above because here we
are
talking about spaces in the tag NAMES.
So, as of right now, the Go client cannot support tag names OR values with
spaces in them. That's going to be a limitation we need to document, unless
we fix these two issues.
Sorry - I misspoke. It is more than spaces in tag names, the problem is when spaces are in
METRIC IDs. I suspect spaces in tag names will also fail, but for sure, spaces in METRIC
IDs cause the failure.
2734
days inactive
2736
days old
4 comments
2 participants
participants (2)
-
John Mazzitelli -
Michael Burman