On 20 Aug 2014, at 13:59, Jeff Cantrill wrote:
Max,
Reference
https://github.com/jcantrill/jbosstools-openshift/commits/jbide_17919_sna...
for how I used it to resolve the issue. In regards to the importance,
I don't really have a context to the schedule or priority. I suspect,
however, the request could wait as the issue I resolved was identified
as low priority; I pulled it from the queue in order to get my feet
wet with the source code.
The alternative would be to split the change into test and code and
push the tests in a later commit. This is not ideal IMO but it would
eliminate the dependency in the short term.
Please check the new PR suggested on
https://issues.jboss.org/browse/JBIDE-18053 after Mickael, Nick and I
reviewed it today and found that at least in theory we should be able to
just include powermock and not add any of the duplicate dependencies
that your initial PR suggested. Avoiding the concern of
changing/duplicating dependencies.
/max
----- Original Message -----
From: "Max Rydahl Andersen" <manderse(a)redhat.com>
To: "Mickael Istria" <mistria(a)redhat.com>
Cc: "jbosstools-dev jbosstools-dev" <jbosstools-dev(a)lists.jboss.org>
Sent: Wednesday, August 20, 2014 3:20:18 AM
Subject: Re: [jbosstools-dev] Proposed change to JBT target platform
4.40.0.CR1-SNAPSHOT: PowerMock
On 20 Aug 2014, at 9:11, Mickael Istria wrote:
> On 08/20/2014 09:09 AM, Max Rydahl Andersen wrote:
>> we are in CR phase - why are adding powermock at this time ?
> I let you discuss with Jeff Cantrill about how much goodness it
> provides and conclude whether we include it or not (so whether we
> also
> include Jeff's patches or not).
I definitely can see its goodness - but I we have issues like
https://issues.jboss.org/browse/JBIDE-14315 with Mockito that makes
changing its version and change where it and this powermock comes from
problematic.
/max
http://about.me/maxandersen
_______________________________________________
jbosstools-dev mailing list
jbosstools-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev
/max
http://about.me/maxandersen