JBIDE-20311 was not fixed. openshift was built before foundation thus it was not picking up the reverted api change. Details in jira - it was a "fun" one to figure out. Thanks mlabuda :) Nick - possible to do a respin and reaggregate ? mini-retrospective: if we actually ran tests on the aggregated build AND the tests tested the fix we made we would have caught this. /max http://about.me/maxandersen _______________________________________________ jbosstools-dev mailing list jbosstools-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosstools-dev

On 24 Jul 2015, at 17:06, Nick Boldt wrote: > Even better would be if people would say "I fixed something in Base > which will impact the downstream build of Openshift, so please ensure > they're built in the correct order." > Or better still, "I reverted that commit in Base and then kicked the > job, waited 10 mins, and kicked an Openshift build too." > What test would have caught this? Some sort of timestamp sequencing > algorithm? Why can't we just communicate changes verbally instead of > just assuming "build magic will happen" ? The jiras talks in details about it being api breakage in foundation that affects openshift - thus it was verbally communicated; but yes it was not explicit enough and that is why we really can't keep relying on verbal communication to catch these things. Build magic is what one would expect to just solve this. But we don't have that so.. The only test that could have caught this is that openshift had a test for testing the browser open worked. we then ran those tests on the combined install instead of just during openshift component build. Then the component build would have passed (Which it did) but the integration test would have failed (which it did not - because we don't run them that way) /max > > On 07/24/2015 04:35 AM, Max Rydahl Andersen wrote: >> >> JBIDE-20311 was not fixed. >> >> openshift was built before foundation thus it was not picking up the >> reverted api change. >> >> Details in jira - it was a "fun" one to figure out. Thanks mlabuda :) >> >> Nick - possible to do a respin and reaggregate ? >> >> mini-retrospective: >> if we actually ran tests on the aggregated build AND the tests tested >> the fix we made we would have caught this. >> >> /max >> http://about.me/maxandersen >> _______________________________________________ >> jbosstools-dev mailing list >> jbosstools-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jbosstools-dev >> > > -- > Nick Boldt :: JBoss by Red Hat > Productization Lead :: JBoss Tools & Dev Studio > http://nick.divbyzero.com /max http://about.me/maxandersen