Re: [jbosstools-dev] Proposed change to JBoss Tools' parent pom -- better support for SWTBot UI testing on OSX Jenkins slave

As there were no objections, I committed this change yesterday and kicked the parent pom respin today. https://issues.jboss.org/browse/JBIDE-11666 Just need QE to close the issue when they're happy w/ it. Cheers, N On 05/09/2012 01:01 AM, Max Rydahl Andersen wrote: > > On May 4, 2012, at 19:04 , Nick Boldt wrote: > >> Currently, the parent pom [1] includes a profile which is enabled >> automagically on OSX when java.vendor.url=http://www.apple.com. >> This >> simply sets the following systemProperties property: >> >> -d32 -Dosgi.arch=x86 -XstartOnFirstThread >> >> However, this appears to be ignored/overwritten by Surefire when >> running >> tests. > > Correction: This property are overwritten by some pom's and > therefore what is in the parent gets > ignored. (nothing specific to surefire actually)) > >> So, it's been proposed [2] that we instead use a new property, >> platformSystemProperties, which is null on windows/linux but takes >> this >> value on OSX: >> >> -d32 -Dosgi.arch=x86 -XstartOnFirstThread > > Makes sense and shouldn't harm afaics since its just the same > approach as before > but just separating out these settings. > > Once QE verified it works for them on Mac then it should be > possible to update. > >> Before I make this change and break any of our consumers by >> removing the >> old systemProperties value in favour of the new one, I wanted to >> know if >> this was a Very Bad Idea from anyone's point of view, or in fact a >> simple tweak that affects no one (but in fact makes life easier >> for QE). > > systemProperties is still there and used so don't think this will > actually break anyone - it will > behave the same as before (overriding the systemProperties if set). > > But of course now they do get to see both properties so there might > be a difference but > hopefully only to the better. > > ...and its not just making life easier for QE its good for all ;) > > /max -- Nick Boldt :: JBoss by Red Hat Productization Lead :: JBoss Tools & Dev Studio http://nick.divbyzero.com _______________________________________________ jbosstools-dev mailing list jbosstools-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosstools-dev