Re: [jbosstools-dev] Building the server component
We should use different approach, not right now, but at some point.
PR should be built on jenkins first without pushing to actual repo. Then
anyone who is reviewing PR would have additional info (build
success/failure, tests success/failure, coverage up/down, API changes)
to approve the PR or reject it.
It has pros:
1. No extra commits with comments: "Ohh, I forgot do add this and this"
, in case build is failed
2. Reviewer do-not need to build it locally to verify it works
cons:
1. More jenkins builds
2. Have no Idea how to deal with PR's related to each other for
different components
Denis
On 09/24/2013 12:33 PM, Nick Boldt wrote:
To avoid this conversation in future, I suggest a possible workflow
change:
1. push PR or commit
2. push the "build now" button for your component's Jenkins job
3. comment in the JIRA that the fix will be available in a specific
build, eg.,
"Spinning
https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-server_41/
>=120 to pick up the fix"
This benefits other devs who might be peer-reviewing your code,
project/program management who might be overseeing commits for that
branch, and QE because it's much easier to know when/where the fix will
appear. It also guarantees your fix will be picked up much faster than
in 6 hours when the job checks github for changes.
Everyone wins, and it only costs you a few dozen keystrokes.
WDYT?
On 09/24/2013 02:56 PM, Max Rydahl Andersen wrote:
> cool - I was just trying to figure out what status was and there was no
> followup/comment on the mail thread here.
>
> Thanks all for replying now :)
>
> /max
>
> On Tue, Sep 24, 2013 at 01:50:45PM -0400, Nick Boldt wrote:
>> Max:
>>
>> https://issues.jboss.org/browse/JBIDE-15503#comment-12807020
>>
>> N
>>
>> On 09/24/2013 11:37 AM, Rob Stryker wrote:
>>> Everything built locally so I committed it. Don't think we've seen
the
>>> jenkins results yet.
>>>
>>>
>>> On 09/24/2013 11:19 PM, Max Rydahl Andersen wrote:
>>>> Rob, was this ever resolved ? seems JBIDE-15503 was committed so
i'll
>>>> assume it is ?
>>>>
>>>> /max
>>>>
>>>> On Thu, Sep 19, 2013 at 03:46:05PM +0200, Snjezana Peco wrote:
>>>>> Hi,
>>>>>
>>>>> Building the server component fails because the required file
>>>>>
http://download.lab.bos.redhat.com/devel/candidates/JBEAP/JBEAP-6.1.0-ER4...
>>>>>
>>>>>
>>>>> doesn't exist anymore.
>>>>> I suppose we would need to replace it with
>>>>>
http://download.devel.redhat.com/released/JBEAP-6/6.1.0/jboss-eap-6.1.0.zip
>>>>>
>>>>>
>>>>> or
>>>>>
http://download.devel.redhat.com/released/JBEAP-6/6.1.1/jboss-eap-6.1.1.zip.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Snjeza
>>>>> _______________________________________________
>>>>> jbosstools-dev mailing list
>>>>> jbosstools-dev(a)lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>
>>> _______________________________________________
>>> jbosstools-dev mailing list
>>> jbosstools-dev(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>
>> --
>> Nick Boldt :: JBoss by Red Hat
>> Productization Lead :: JBoss Tools & Dev Studio
>> http://nick.divbyzero.com