On 06/25/2015 05:47 AM, Max Rydahl Andersen wrote:
> My PR to fix the issue creates a 71x service inside the
> org.jboss.ide.eclipse.as.management.wildfly8 to live along side the wf8
> service. Unfortunately, it seems strange now to have a plugin named
> org.jboss.ide.eclipse.as.management.as71 which holds a service with
> version=7.1.0.Beta1 which only works for AS 7.0.x =P Seems a bit
> odd, no?
eh - why would as71 not continue to work with AS 7.1, EAP etc. ?
I'm saying that in my PR, the jars in the as71 management plugin would
only work for as70, while the jars in the wf8 plugin will work for as71
through wf9. This is pretty confusing, since someone might expect the
jars in the as71 plugin are the one being used for as71, which won't be
the case.
Of course if a client were using the mgmt plugins properly, they'd have
an IServer already, and use the existing API (Extended properties, etc)
to get the management service. But if they're "hand-rolling" their own
solution by locating services with specific version strings, or
depending on specific plugins, this becomes more of an issue.
Ideally I'd like to rename the plugins to match better their
functionality. I'd also like to rename the constants to match what they
actually work for, so we don't have constants with strings including
"beta1" or other such nonesense... But in order to do this safely, I
need to know who our external users are of the IJBoss7ManagerService,
what constants they use, whether they depend on a given plugin name
directly (either in their manifests or features), or if they just depend
on my AS feature (and then I pull in all the management stuff).
Basically, I'd like to clean up the code, rename the things that make no
sense, and harmonize the situation ;)
Are you not just saying that you will start using management.as90 with
AS 7.1 and upwards
to make it behave better ?
seems to me like nothing changed/broken in this so not sure why you
think its broken
more than before where as71 was used for other versions than as7.1 ?
/max
http://about.me/maxandersen