Might be of interest ... https://community.jboss.org/en/teiiddesigner/dev/blog/2014/06/23/unit-tes...

>> Might be of interest ... >> >> https://community.jboss.org/en/teiiddesigner/dev/blog/2014/06/23/unit-tes... >> > > thats cool - even though I was hoping it was actually using > arquillian to test eclipse (i.e. as an > alternative to eclipse test runner). > > May I ask why the code we have in our server adapter testing base > code was not sufficient for > starting jboss servers and test against it ? > > /max > http://about.me/maxandersen Cos... I didn't know it was there ;-)

I may have misunderstood mistria as well that the current JBT testing started servers with WTP?

I didn't really want to introduce that element as well into the integration-testing. I wanted to confine it to: - Start JBoss Server with Teiid installed - Connect to Teiid using Teiid API from our Teiid client plugin - Deploy Teiid's own testing VDBs using our Teiid client plugin ... ...

On 06/27/2014 04:08 PM, Max Rydahl Andersen wrote: > >>>> Might be of interest ... >>>> >>>> https://community.jboss.org/en/teiiddesigner/dev/blog/2014/06/23/unit-tes... >>>> >>>> >>> >>> thats cool - even though I was hoping it was actually using >>> arquillian to test eclipse (i.e. as an >>> alternative to eclipse test runner). >>> >>> May I ask why the code we have in our server adapter testing base >>> code was not sufficient for >>> starting jboss servers and test against it ? >>> >>> /max >>> http://about.me/maxandersen >> >> Cos... I didn't know it was there ;-) > > there is this mailing list called jbosstools-dev where you can ask > how > we test our existing jboss server tooling :) > >> I may have misunderstood mistria as well that the current JBT >> testing >> started servers with WTP? > > They are. We could probably remove that but for now not had that need > since the plugins talking to the server > have already had the dependency on the server adapter/wtp anyway. > >> I >> didn't really want to introduce that element as well into the >> integration-testing. I wanted to >> confine it to: >> - Start JBoss Server with Teiid installed >> - Connect to Teiid using Teiid API from our Teiid client plugin >> - Deploy Teiid's own testing VDBs using our Teiid client plugin >> ... ... > > So that is reason enough for it. If you don't need/want to test your > server adapter as part of this > then yeah you don't have a need for it and its really cool to get > arquillian to do it. > > What worries me and what I couldn't immediately grok was why > ant/eclipserunner had to be involved in this ? > > This is because you need to actually invoke arquillian before the > eclipse run ? > > if it is then yeah - this is why I tease arquillian team to get an > eclipse friendly version of it > so all these hoops doesn't need to be jumped through. > > I tried following a few of your links but they 404's (like > https://github.com/Teiid-Designer/komodo/blob/master/tests/org.komodo.ecl...) > > would love to show Aslak the complexity required for this (which > seems > unnecessary) > > /max > http://about.me/maxandersen Ask for help when I can struggle on my own - are you mad!! ;-) One of those "I'll just try this quickly situations that turn into a crusade' is the best explanation. Anyway... Answering points above in sequence: Ant is responsible for downloading the maven dependencies and copying them to a libs folder as library dependencies for the test plugin.

Executing tests within Eclipse AND through maven is part-and-parcel of our development process. Run the tests in Eclipse once (or during) development and then run them through maven prior to push to github and letting jenkins build.

Otherwise, yes you are correct. Arquillian must be invoked prior to running the unit test so that the JBoss container is there waiting.

Links fixed but the komodo repository is a live firing range at the moment with lots of development going on so more than likely they might break again in the future. I'll try and keep and eye-out. Maybe I have got so used to using Eclipse auto-builders (using ant) to bring in extra libraries from some other source that I don't really see it as complex. Then again seeing wood for the trees is not necessarily my forte.

> > My main concern is that this is bringing in dependencies outside or > our target platform thus > less easy to contain/check for overlaps. Also - using mvn copy goal > seems to me to be the > better way rather than using ant auto builders? The ant auto builder [1] does hands-off maven by calling 'mvn process-sources'. This always executes the mvn copy-dependencies goal so bringing in the dependencies [2]. It has always been essential that any process happening while developing in Eclipse must also occur when building on the command line through maven. This is an example of that with the ant providing the plumbing between Eclipse and maven.

On 09/07/2014, at 14.38, phantomjinx <p.g.richardson(a)phantomjinx.co.uk&gt; wrote: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/04/2014 05:01 PM, Max Rydahl Andersen wrote: >>> >>> My main concern is that this is bringing in dependencies outside or our target platform >>> thus less easy to contain/check for overlaps. Also - using mvn copy goal seems to me to be >>> the better way rather than using ant auto builders? >> >> The ant auto builder [1] does hands-off maven by calling 'mvn process-sources'. This always >> executes the mvn copy-dependencies goal so bringing in the dependencies [2]. It has always >> been essential that any process happening while developing in Eclipse must also occur when >> building on the command line through maven. This is an example of that with the ant providing >> the plumbing between Eclipse and maven. > > ..isn't that what the tycho-m2 plugin does for you ? Well I am no expert in tycho so I may be wrong or not-up-to-date but no tycho cannot help. Tycho looks only looks for dependencies in pom files, which are osgi bundles. Normal maven jar libraries are ignored hence for those libraries to be available on the classpath to both eclipse's P2 and Tycho, they much be listed in the manifest file. I do this by specifying them as dependencies in the pom file and using copy-dependencies to get them into the lib directory of the plugin.

PGR - -- Paul Richardson * p.g.richardson(a)phantomjinx.co.uk * p.g.richardson(a)redhat.com * pgrichardson(a)linux.com "I know exactly who reads the papers ... * The Daily Mirror is read by people who think they run the country. * The Guardian is read by people who think they ought to run the country. * The Times is read by people who do actually run the country. * The Daily Mail is read by the wives of the people who run the country. * The Financial Times is read by the people who own the country. * The Morning Star is read by the people who think the country ought to be run by another country. * The Daily Telegraph is read by the people who think it is." Jim Hacker, Yes Minister

On 07/10/2014 09:06 AM, Max Rydahl Andersen wrote: > >> On 09/07/2014, at 14.38, phantomjinx >> <p.g.richardson(a)phantomjinx.co.uk&gt; wrote: >> > On 07/04/2014 05:01 PM, Max Rydahl Andersen wrote: >>>>>> >>>>>> My main concern is that this is bringing in dependencies outside >>>>>> or our target >>>>>> platform thus less easy to contain/check for overlaps. Also - >>>>>> using mvn copy goal >>>>>> seems to me to be the better way rather than using ant auto >>>>>> builders? >>>>> >>>>> The ant auto builder [1] does hands-off maven by calling 'mvn >>>>> process-sources'. This >>>>> always executes the mvn copy-dependencies goal so bringing in the >>>>> dependencies [2]. It >>>>> has always been essential that any process happening while >>>>> developing in Eclipse must >>>>> also occur when building on the command line through maven. This >>>>> is an example of that >>>>> with the ant providing the plumbing between Eclipse and maven. >>>> >>>> ..isn't that what the tycho-m2 plugin does for you ? > > Well I am no expert in tycho so I may be wrong or not-up-to-date but > no tycho cannot help. > > Tycho looks only looks for dependencies in pom files, which are osgi > bundles. Normal maven jar > libraries are ignored hence for those libraries to be available on > the classpath to both > eclipse's P2 and Tycho, they much be listed in the manifest file. I > do this by specifying them > as dependencies in the pom file and using copy-dependencies to get > them into the lib directory > of the plugin. > > >> Yes, we do this in other places too and tycho m2e integration makes >> it happen without needing >> the ant step. > >> /max Well eliminating the need for the ant build scripts would certainly simplify things. Can you point me to an example project as the tycho-m2e documentation on the net is a little scant.

Cheers PGR - -- Paul Richardson * p.g.richardson(a)phantomjinx.co.uk * p.g.richardson(a)redhat.com * pgrichardson(a)linux.com "I know exactly who reads the papers ... * The Daily Mirror is read by people who think they run the country. * The Guardian is read by people who think they ought to run the country. * The Times is read by people who do actually run the country. * The Daily Mail is read by the wives of the people who run the country. * The Financial Times is read by the people who own the country. * The Morning Star is read by the people who think the country ought to be run by another country. * The Daily Telegraph is read by the people who think it is." Jim Hacker, Yes Minister