[ https://issues.jboss.org/browse/JBIDE-10402?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-10402: ------------------------------------- Steps to Reproduce: # ASSERT: make sure you have no git repository in your <home>/git/<openshiftApplicationName> (ex. I use an Openshift application called as1. Since I checked that one out, I have a clone of it in /home/adietish/git/as1) # ASSERT: make sure you have a "Dynamic Web Project" in your workspace, that is not shared to any provider (no cvs, no svn, no git, etc.) # EXEC: launch the OpenShift application wizard # EXEC: on the last page, make sure you have "Create new application" unchecked # EXEC: choose your "dynamic web project" # EXEC: hit finish # ASSERT: got to <home>/git/<openshiftApplicationName> and create an empty file (ex. TEST) !clone-destination.png! do steps 3 - 6 again # ASSERT: got to <home>/git/<openshiftApplicationName> and check if your file (ex. TEST) is still there Result: It disappeared. The OpenShift wizard cloned the git repo of your application to the very same location and overwrote the repo that was already there. was: # ASSERT: make sure you have no git repository in your <home>/git/<openshiftApplicationName> (ex. I use an Openshift application called as1. Since I checked that one out, I have a clone of it in /home/adietish/git/as1) # ASSERT: make sure you have a "Dynamic Web Project" in your workspace, that is not shared to any provider (no cvs, no svn, no git, etc.) # EXEC: launch the OpenShift application wizard # EXEC: on the last page, make sure you have "Create new application" unchecked # EXEC: choose your "dynamic web project" # EXEC: hit finish # ASSERT: got to <home>/git/<openshiftApplicationName> and create an empty file (ex. TEST) do steps 3 - 6 again # ASSERT: got to <home>/git/<openshiftApplicationName> and check if your file (ex. TEST) is still there Result: It disappeared. The OpenShift wizard cloned the git repo of your application to the very same location and overwrote the repo that was already there. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10402?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10402: ------------------------------------------ patch for M5 attached. @Max: please review -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10402?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-10402: ------------------------------------- Attachment: clone-to-tmp.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10402?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-10402: ------------------------------------- Attachment: clone-to-tmp2.patch of course, your comopletely right. That patch was done while hurrying too much. I fixed the issues. @Max: please review the new patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10402?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10402: --------------------------------------------- looks good for M5. Future improvements: Prefix the random name with something meaningfull, i.e. jbosstools-<projectname>-<timestamp> so in case stuff does not get deleted users have a better idea what their tmp folder is filled with. Add output directory to the progress monitor but for M5 this looks fine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10402?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10402: ------------------------------------------ We are now cloning to a temporary folder and remove that one right afterwards. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira