[ https://issues.jboss.org/browse/JBIDE-11240?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11240: --------------------------------------------- Click OpenShift Wizard choose existing app otherwise default choices. Gets NPE when pressing finish. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11240?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-11240: ---------------------------------------- Description: Can't import existing app. EXECUTE: Start openshift wizard EXECUTE: Select existing app EXECUTE: Type in (do not use browse) you existing app name EXECUTE: Press Finish ASSERT: no errors but I get this: Getting this: java.lang.NullPointerException at org.jboss.tools.openshift.express.internal.ui.wizard.appimport.AbstractImportApplicationOperation.cloneRepository(AbstractImportApplicationOperation.java:86) at org.jboss.tools.openshift.express.internal.ui.wizard.appimport.ImportNewProject.execute(ImportNewProject.java:72) at org.jboss.tools.openshift.express.internal.ui.wizard.OpenShiftExpressApplicationWizardModel.importProject(OpenShiftExpressApplicationWizardModel.java:81) at org.jboss.tools.openshift.express.internal.ui.wizard.OpenShiftExpressApplicationWizard$ImportJob.runInWorkspace(OpenShiftExpressApplicationWizard.java:281) at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) If I use browse it fixes it, if I use new app it works, if I click back/next a few times it seem to also fix it self. So my guess is that the wizard is *not* taking the content of the existing app into account - only takes it account if pressed browse or next a few times was: Can't import existing app. Getting this: java.lang.NullPointerException at org.jboss.tools.openshift.express.internal.ui.wizard.appimport.AbstractImportApplicationOperation.cloneRepository(AbstractImportApplicationOperation.java:86) at org.jboss.tools.openshift.express.internal.ui.wizard.appimport.ImportNewProject.execute(ImportNewProject.java:72) at org.jboss.tools.openshift.express.internal.ui.wizard.OpenShiftExpressApplicationWizardModel.importProject(OpenShiftExpressApplicationWizardModel.java:81) at org.jboss.tools.openshift.express.internal.ui.wizard.OpenShiftExpressApplicationWizard$ImportJob.runInWorkspace(OpenShiftExpressApplicationWizard.java:281) at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) will try and see how to reproduce. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11240?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-11240: ------------------------------------- Description: Can't import existing app. EXECUTE: Start openshift wizard (from central or the new wizards, DONT use express console) EXECUTE: Check *existing app* EXECUTE: Type in (do NOT use browse) your existing app name EXECUTE: Press Finish ASSERT: no errors Result: Getting this: java.lang.NullPointerException at org.jboss.tools.openshift.express.internal.ui.wizard.appimport.AbstractImportApplicationOperation.cloneRepository(AbstractImportApplicationOperation.java:86) at org.jboss.tools.openshift.express.internal.ui.wizard.appimport.ImportNewProject.execute(ImportNewProject.java:72) at org.jboss.tools.openshift.express.internal.ui.wizard.OpenShiftExpressApplicationWizardModel.importProject(OpenShiftExpressApplicationWizardModel.java:81) at org.jboss.tools.openshift.express.internal.ui.wizard.OpenShiftExpressApplicationWizard$ImportJob.runInWorkspace(OpenShiftExpressApplicationWizard.java:281) at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) If I use browse it fixes it, if I use new app it works, if I click back/next a few times it seem to also fix it self. So my guess is that the wizard is *not* taking the content of the existing app into account - only takes it account if pressed browse or next a few times was: Can't import existing app. EXECUTE: Start openshift wizard (from central or the new wizards, DONT use express console) EXECUTE: Check *existing app* EXECUTE: Type in (do NOT use browse) your existing app name EXECUTE: Press Finish Result: Getting this: java.lang.NullPointerException at org.jboss.tools.openshift.express.internal.ui.wizard.appimport.AbstractImportApplicationOperation.cloneRepository(AbstractImportApplicationOperation.java:86) at org.jboss.tools.openshift.express.internal.ui.wizard.appimport.ImportNewProject.execute(ImportNewProject.java:72) at org.jboss.tools.openshift.express.internal.ui.wizard.OpenShiftExpressApplicationWizardModel.importProject(OpenShiftExpressApplicationWizardModel.java:81) at org.jboss.tools.openshift.express.internal.ui.wizard.OpenShiftExpressApplicationWizard$ImportJob.runInWorkspace(OpenShiftExpressApplicationWizard.java:281) at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) If I use browse it fixes it, if I use new app it works, if I click back/next a few times it seem to also fix it self. So my guess is that the wizard is *not* taking the content of the existing app into account - only takes it account if pressed browse or next a few times -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11240?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-11240: ------------------------------------- Attachment: set-existing-app-when-typing-existingappname-2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11240?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-11240: ------------------------------------------ verified by me and Xavier: works for both of us. @Max: please approve the patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11240?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-11240: ---------------------------------------- Assignee: Andre Dietisheim (was: Max Rydahl Andersen) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11240?page=com.atlassian.jira.plugi... ] Andre Dietisheim resolved JBIDE-11240. -------------------------------------- Resolution: Done committed to BRANCH (Beta2) and TRUNK -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11240?page=com.atlassian.jira.plugi... ] Xavier Coulon edited comment on JBIDE-11240 at 3/22/12 5:01 AM: ---------------------------------------------------------------- sorry, attached patch to wrong issue. Please ignore was (Author: xcoulon): Same patch, but removed all unnecessary formatting for better readability ;-) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira