[JBoss JIRA] (MODCLUSTER-653) mod_cluster DefaultMCMPHandler should handle "Connection: close" response header and close a connection
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-653?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-653:
--------------------------------------
Fix Version/s: 1.4.0.Final
2.0.0.Alpha1
1.3.10.Final
> mod_cluster DefaultMCMPHandler should handle "Connection: close" response header and close a connection
> -------------------------------------------------------------------------------------------------------
>
> Key: MODCLUSTER-653
> URL: https://issues.jboss.org/browse/MODCLUSTER-653
> Project: mod_cluster
> Issue Type: Bug
> Components: Core & Container Integration (Java)
> Affects Versions: 1.3.7.Final
> Reporter: Masafumi Miura
> Assignee: Radoslav Husar
> Fix For: 1.4.0.Final, 2.0.0.Alpha1, 1.3.10.Final
>
>
> mod_cluster {{DefaultMCMPHandler#sendRequest()}} does not close a connection when Apache httpd closes a connection and responds to MCMP STATUS request with "{{Connection: close}}" response header. (As {{KeepAlive Off}} is set by default, Apache httpd closes a connection and responds to MCMP STATUS request with "{{Connection: close}}".) Therefore, CLOSE_WAIT connection remains every MCMP STATUS command.
> This CLOSE_WAIT connection will be cleaned when trying to send the next MCMP STATUS request, so there's no functional impact. And this is not a critical issue as neither connection leak nor file descriptor leak happens. However, it's better that mod_cluster handles the "{{Connection: close}}" response header and close a connection.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 8 months
[JBoss JIRA] (MODCLUSTER-653) mod_cluster DefaultMCMPHandler should handle "Connection: close" response header and close a connection
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-653?page=com.atlassian.jira.pl... ]
Work on MODCLUSTER-653 started by Radoslav Husar.
-------------------------------------------------
> mod_cluster DefaultMCMPHandler should handle "Connection: close" response header and close a connection
> -------------------------------------------------------------------------------------------------------
>
> Key: MODCLUSTER-653
> URL: https://issues.jboss.org/browse/MODCLUSTER-653
> Project: mod_cluster
> Issue Type: Bug
> Components: Core & Container Integration (Java)
> Affects Versions: 1.3.7.Final
> Reporter: Masafumi Miura
> Assignee: Radoslav Husar
> Fix For: 1.4.0.Final, 2.0.0.Alpha1, 1.3.10.Final
>
>
> mod_cluster {{DefaultMCMPHandler#sendRequest()}} does not close a connection when Apache httpd closes a connection and responds to MCMP STATUS request with "{{Connection: close}}" response header. (As {{KeepAlive Off}} is set by default, Apache httpd closes a connection and responds to MCMP STATUS request with "{{Connection: close}}".) Therefore, CLOSE_WAIT connection remains every MCMP STATUS command.
> This CLOSE_WAIT connection will be cleaned when trying to send the next MCMP STATUS request, so there's no functional impact. And this is not a critical issue as neither connection leak nor file descriptor leak happens. However, it's better that mod_cluster handles the "{{Connection: close}}" response header and close a connection.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 8 months
[JBoss JIRA] (MODCLUSTER-643) Misleading JavaDoc for SPI Container Engine
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-643?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-643:
--------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 2.0.0.Alpha1
Resolution: Done
> Misleading JavaDoc for SPI Container Engine
> -------------------------------------------
>
> Key: MODCLUSTER-643
> URL: https://issues.jboss.org/browse/MODCLUSTER-643
> Project: mod_cluster
> Issue Type: Bug
> Components: Core & Container Integration (Java)
> Affects Versions: 1.3.8.Final, 1.4.0.Alpha1
> Reporter: Michal Herda
> Assignee: Radoslav Husar
> Priority: Trivial
> Fix For: 2.0.0.Alpha1
>
>
> https://github.com/modcluster/mod_cluster/blob/7e4dadf03df78f05bbf06af698...
> {code}
> /**
> * The connector to which this engine uses to communicate with its proxies.
> *
> * @return the connector used by mod_cluster
> */
> Connector getProxyConnector();
> /**
> * The connector to which this engine uses to communicate with its proxies.
> *
> * @return the connector used by mod_cluster
> */
> Iterable<Connector> getConnectors();
> {code}
> From what I see and understand from the code, the javadoc for getConnectors() does not reflect its actual purpose - it seems like a copypaste from getProxyConnector(). I am not competent enough to write a proper JavaDoc myself through - please support me with it.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 8 months