[
https://issues.jboss.org/browse/MODCLUSTER-528?page=com.atlassian.jira.pl...
]
Radoslav Husar commented on MODCLUSTER-528:
-------------------------------------------
The conclusion doesn't make any sense to me - which systems?
Which tomcats?
For instance Fedora 24 build system (i.e. ecosystem).
Why would we bring Tomcat 7 dependencies to Tomcat 8 game?
See below.
I should need only Tomcat 8 dependencies without patching *.java
files
That's a terrible approach. Building for RPM or whatever other system needs to follow
what maven is doing -- that's the build that is used and tested. introducing new code
in e.g. RPM building is a quiality risk.
drop Tomcat 6 from 1.3.x branch and from master, it is not needed
there
drop JBossWeb/AS7 from 1.3.x branch and from master, it is not needed there
Long time dropped from master.
move Catalina stuff around so as -PTC7 needs Tomcat 7 dependencies,
-PTC8 needs Tomcat 8 dependencies, -PTC85 needs Tomcat 8.5 dependencies etc.
This is setup in pre-master, never used and never worked. This is dropped in master
(commented out).
Doing this means unnecessary code duplication. The base module could then only contain
code that can be compiled with *every* Tomcat version we support. The approach that we
have been shipping for years is to compile base against single version and override code
that needs to be changed for newer tomcat version.
Re-think catalina/tomcat dependencies so as it is possible to build
without tomcat7 API
---------------------------------------------------------------------------------------
Key: MODCLUSTER-528
URL:
https://issues.jboss.org/browse/MODCLUSTER-528
Project: mod_cluster
Issue Type: Enhancement
Affects Versions: 1.3.3.Final
Reporter: Michal Karm Babacek
Assignee: Radoslav Husar
It is not possible (or I'm doing something wrong) to build mod_cluster Tomcat libs
with Tomcat 8-only API.
I hit this problem with RPM build on Fedora where I cannot download random stuff from
maven central and I need to specify dependencies beforehand.
h3. Description
* container/catalina contains calls to API that is deprecated in Tomcat 7 and missing in
Tomcat 8, so I have to apply this patch:
[
MODCLUSTER-528-CatalinaContext.java.patch|https://github.com/Karm/mod_clu...]
before build
* profiles and test dependencies and Servlet API dependencies needs hacks to build
without Tomcat 7 too: see other patches in
[
mod_cluster-fedora-packages/|https://github.com/Karm/mod_cluster-fedora-p...]
h3. Suggestion
* architecture dependencies so as it is possible to build mod_cluster with Tomcat 8 API
only (and Tomcat 7 API only)
* drop Tomcat 6 and JBossWeb from 1.3.x as they are not used in 1.3.x anyway (last use
of Tomcat 6 and JBossWeb is 1.2.x)
h3. Fedora 24 offers only Tomcat 8
...so does it even make sense to offer users Tomcat 7 libs RPM? At the moment, I have it
disabled. Note: Former mod_cluster RPM (1.2.6) hasn't been distributing any usable
tomcat integration; it has been AS7/JBossWeb one.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)