[
https://jira.jboss.org/jira/browse/MODCLUSTER-142?page=com.atlassian.jira...
]
Paul Ferraro commented on MODCLUSTER-142:
-----------------------------------------
True - my thinking was that it would be nice to tell which server a given request was
directed from the client - but, you're right, it's easy enough to look up server
address from the jvm route via a INFO/DUMP.
Use UUID for auto-generated jvmRoute
------------------------------------
Key: MODCLUSTER-142
URL:
https://jira.jboss.org/jira/browse/MODCLUSTER-142
Project: mod_cluster
Issue Type: Feature Request
Affects Versions: 1.1.0.CR1
Reporter: Paul Ferraro
Assignee: Paul Ferraro
Fix For: 1.1.0.CR2
Currently, auto-generated jvm-routes are of the form: bind-address:port:engine-name
This exposes internal addresses/ports and is not appropriate for production systems.
To fix that, we can use UUIDs.
e.g.
InetAddress connectorAddress;
int connectorPort;
String engineName;
int addressBytes = connectorAddress.getAddress().length;
int intBytes = Integer.SIZE / Byte.SIZE;
int charBytes = Character.SIZE / Byte.SIZE;
ByteBuffer buffer = ByteBuffer.allocate(addressBytes + intBytes + (engineName.length() *
charBytes));
buffer.put(connectorAddress.getAddress());
buffer.putInt(connectorPort);
buffer.asCharBuffer().put(engine);
String jvmRoute = UUID.nameUUIDFromBytes(buffer.array()).toString();
I can think of 2 disadvantages:
1. UUID jvm-routes will be, on average, longer than the current default, i.e. 36
characters as opposed to ~28. Not a significant difference there.
2. For development, exposing the address and port via the jvm route might be useful. To
satisfy this requirement, we can make the use of UUIDs configurable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira