[cdi-dev] [JBoss JIRA] (CDI-721) configureAnnotatedType vs setAnnotatedType restrition is unecessarily strict
[
https://issues.jboss.org/browse/CDI-721?page=com.atlassian.jira.plugin.sy...
]
Mark Struberg commented on CDI-721:
-----------------------------------
[~mkouba] your sample above is exactly as the following:
{code:java}
void observe(@Observes ProcessAnnotatedType<Foo> event) {
event.setAnnotatedType(newAT_1);
event.setAnnotatedType(newAT_2);
configurator.methods().forEach(m -> m.add(Whatever.Literal.INSTANCE));
}
{code}
Whether this makes sense or not is TOTALLY up to what happens between those 2
setAnnotatedType calls. Maybe the user wants to *intentionally* replace newAT_1 later? How
could you know?
It is *not* upon us to judge whether that code makes sense or not - it is purely a matter
of the business logic of that project!
configureAnnotatedType vs setAnnotatedType restrition is unecessarily
strict
----------------------------------------------------------------------------
Key: CDI-721
URL: https://issues.jboss.org/browse/CDI-721
Project: CDI Specification Issues
Issue Type: Bug
Components: Portable Extensions
Affects Versions: 2.0 .Final
Reporter: Mark Struberg
{noformat}
Any observer of this event is permitted to wrap and/or replace the AnnotatedType by
calling either setAnnotatedType() or configureAnnotatedType(). If both methods are called
within an observer notification an IllegalStateException is thrown.
{noformat}
This rule is way too strict without any real reason.
Any CDI container must support that both methods are being called on the same event
payload anyway. Because we did not forbid that observerMethod1 invokes setAnnotatedType
and observerMethod2 uses configureAnnoatedType. And that's good that way, otherwise
the pluggability would be lost.
We should delete this sentence without any substitution.
The same applies to similar configurator methods like configureBeanAttributes, etc.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)