December 2012 - cdi-dev - Jboss List Archives

by Mark Struberg

Hi folks! Since I will most probably not be able to attend tomorrows EG meeting I like to add a few tasks which you folks could please think about. 1.) Since the 1.a 'horizontal' isolation got voted for you folks need to come up with a detailed solution. There are basically 2 options: 1.a.a.) to live with getting different instances injected into InjectionPoint with the same type (depending in which classloader the InjectionPoint is). This will also need to get changed for many BeanManager methods most probably. And 1.a.b.) to disallow @Alternatives, @Specializes, Extension handling, etc for classes which 'narrow' beans already defined in parent ClassLoaders. 2.) My Question regarding Producer<T> and InjectionPoint<T>. See the description over there. Imo the only way atm is to clarify that setProducer and setInjectionPoint must only be used to create a wrapper which delegates to the instances resolved via getProducer() and getInjectionPoint() ("...otherwise non-portable behaviour results."). It's imo just not easily possible to really create an own Producer from scratch. Wdyt? 3.) Jens pinged me offline to take a look at the current @Transactional discussion, but for that we need @Nonbinding in the 'new' commons-annotation spec. Pete recently mentioned that there is new work done in commons-annotation (@Priority). LieGrue, strub

11 years, 4 months

3
4
0 / 0

Fwd: [jsr342-experts] @Priority

by Pete Muir

All, Please see the below message about the @Priority annotation. This is going to be very useful for CDI :-) Also, the Java EE spec leads, myself, and the EJB spec lead are proposing moving as much of the interceptors stuff from the CDI spec to the Interceptors spec. The only stuff that would remain in CDI would be how interceptors interact with stereotypes, and beans.xml. This will allow us to cleanly split the new, global enablement and ordering, more cleanly from the old approach IMO. I'll work with Marina on this over the next couple of weeks. Pete Begin forwarded message: > From: Pete Muir <pmuir(a)bleepbleep.org.uk> > Subject: [jsr342-experts] Re: @Priority > Date: 10 December 2012 10:41:34 GMT > To: jsr342-experts(a)javaee-spec.java.net > > Bill, as discussed I think we should sort out the priority ranges to be blocks of 1000 each - as multiple people pointed out to me, we aren't running out of integers any time soon! > > Also, as Emmanuel has proposed, it's worth discussing whether we should have an enum or group of statics on a class somewhere that define the values used by Java EE specs, so you can do Interceptors.Validation + 100 (or something like that) as your priority. > > Pete > > On 7 Dec 2012, at 17:48, Bill Shannon wrote: > >> Those of you tracking CDI 1.1 will notice that it has defined a new >> way to control the order in which interceptors are run. An interceptor >> can define a "priority" and interceptors are run in priority order. >> To support this use, and other similar cases, we'd like to define a >> @Priority annotation in the Common Annotations spec. Interceptors >> annotated with @Priority would be *enabled by default*, and run at >> the specified priority. The priority can be overridden in beans.xml. >> >> The common annotation definition would be something as simple as this: >> >> ----- >> package javax.annotation; >> >> import java.lang.annotation.*; >> import static java.lang.annotation.ElementType.*; >> import static java.lang.annotation.RetentionPolicy.*; >> >> /** >> * The Priority annotation can be applied to classes to indicate >> * in what order the classes should be used. The effect of using >> * the Priority annotation in any particular instance is defined >> * by other specifications that define the use of a specific class. >> * >> * For example, the Interceptors specification defines the use of >> * priorities on interceptors to control the order in which >> * interceptors are called. >> * >> * @since Common Annotations 1.2 >> */ >> @Target({TYPE}) >> @Retention(RUNTIME) >> @Inherited >> @Documented >> public @interface Priority { >> /** >> * The priority value. >> */ >> int value(); >> } >> ----- >> >> A key question for this group is... What should the name of this >> annotation be? >> >> We've been calling it @Priority, but other reasonable names are >> @Order, @Rank, @SortIndex, and probably a dozen others you can >> think of. >> >> >> In addition, the CDI spec defines various ranges of priorities that >> should be used for different purposes. We would define some constants >> for these ranges: >> >> ----- >> package javax.interceptor; >> >> import static java.lang.annotation.ElementType.TYPE; >> import static java.lang.annotation.RetentionPolicy.RUNTIME; >> >> import java.lang.annotation.Documented; >> import java.lang.annotation.Retention; >> import java.lang.annotation.Target; >> >> /** >> * Specifies that a class is an interceptor. >> * >> * <pre> >> * @Interceptor >> * public class ValidationInterceptor { ... } >> * </pre> >> * >> * This annotation is optional if the >> * {@link javax.interceptor.Interceptors Interceptors} annotation or >> * the EJB deployment descriptor are used to associate the >> * interceptor with the target class. It is required when an >> * {@linkplain javax.interceptor.InterceptorBinding interceptor binding} >> * is used. >> * >> * @see javax.interceptor.Interceptors >> * >> * @since Interceptors 1.1 >> */ >> @Retention(RUNTIME) >> @Target(TYPE) >> @Documented >> public @interface Interceptor >> { >> /** >> * Priorities that define the order in which interceptors are >> * invoked. These values should be used with the >> * {@link javax.annotations.Priority Priority} annotation. >> * Interceptors defined by platform specifications should be in the >> * range PLATFORM_BEFORE up until LIBRARY_BEFORE, or starting at >> * PLATFORM_AFTER. Interceptors defined by extension libraries >> * should be in the range LIBRARY_BEFORE up until APPLICATION, or >> * LIBRARY_AFTER up until PLATFORM_AFTER. Interceptors defined >> * by applications should be in the range APPLICATION up until >> * LIBRARY_AFTER. An interceptor that must be invoked before or >> * after another defined interceptor can choose any appropriate >> * value. >> * >> * For example, an extension library might define an interceptor >> * like this: >> * >> * <pre> >> * @Priority(Interceptor.Priority.LIBRARY_BEFORE+1) >> * @Interceptor >> * public class ValidationInterceptor { ... } >> * </pre> >> * >> * @since Interceptors 1.2 >> */ >> public static class Priority { >> private Priority() { } // don't allow instances >> >> /** >> * Start of range for early interceptors defined by >> * platform specifications. >> */ >> public static final int PLATFORM_BEFORE = 0; >> >> /** >> * Start of range for early interceptors defined by >> * extension libraries. >> */ >> public static final int LIBRARY_BEFORE = 100; >> >> /** >> * Start of range for interceptors defined by >> * applications. >> */ >> public static final int APPLICATION = 1000; >> >> /** >> * Start of range for late interceptors defined by >> * extension libraries. >> */ >> public static final int LIBRARY_AFTER = 2000; >> >> /** >> * Start of range for late interceptors defined by >> * platform specifications. >> */ >> public static final int PLATFORM_AFTER = 3000; >> } >> } >> ----- >> >> Interceptor.Priority could instead be a separate InterceptorPriority class. >> Or they could be defined directly on the Interceptor class as >> Interceptor.PRIORITY_PLATFORM_BEFORE, etc. Let me know if you think >> either would be better. Note that it can't be an enum because we want >> to allow arithmetic. Any comments to improve the javadocs are greatly >> appreciated. >> >> Comments? >

11 years, 4 months

1
0
0 / 0

[JBoss JIRA] (CDI-307) Use @Priority annotation introduced in common annotations for ordering interceptors, decorators and alternatives

by Mark Struberg (JIRA)

[ https://issues.jboss.org/browse/CDI-307?page=com.atlassian.jira.plugin.sy... ] Mark Struberg commented on CDI-307: ----------------------------------- I'd say we should use @Priority and make this overwriteable in beans.xml. Otherwise you have the problem that you cannot change this later on. > Use @Priority annotation introduced in common annotations for ordering interceptors, decorators and alternatives > ---------------------------------------------------------------------------------------------------------------- > > Key: CDI-307 > URL: https://issues.jboss.org/browse/CDI-307 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Pete Muir > Fix For: 1.1 (Proposed) > > > Common annotations is introducing a @Priority annotation for ordering, we should update our spec to use this, possibly replacing the beans.xml approach. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 4 months

1
0
0 / 0

[JBoss JIRA] (CDI-309) Consider using -1 as a priority to disable something rather than an explicit enabled flag

by Pete Muir (JIRA)

[ https://issues.jboss.org/browse/CDI-309?page=com.atlassian.jira.plugin.sy... ] Pete Muir updated CDI-309: -------------------------- Fix Version/s: 1.1 (Proposed) > Consider using -1 as a priority to disable something rather than an explicit enabled flag > ----------------------------------------------------------------------------------------- > > Key: CDI-309 > URL: https://issues.jboss.org/browse/CDI-309 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Pete Muir > Fix For: 1.1 (Proposed) > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 4 months

1
0
0 / 0

[JBoss JIRA] (CDI-310) Standardize priority range size to 1000 a piece

by Pete Muir (JIRA)

[ https://issues.jboss.org/browse/CDI-310?page=com.atlassian.jira.plugin.sy... ] Pete Muir updated CDI-310: -------------------------- Fix Version/s: 1.1 (Proposed) > Standardize priority range size to 1000 a piece > ----------------------------------------------- > > Key: CDI-310 > URL: https://issues.jboss.org/browse/CDI-310 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Pete Muir > Fix For: 1.1 (Proposed) > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 4 months

1
0
0 / 0

[JBoss JIRA] (CDI-307) Use @Priority annotation introduced in common annotations for ordering interceptors, decorators and alternatives

by Pete Muir (JIRA)

[ https://issues.jboss.org/browse/CDI-307?page=com.atlassian.jira.plugin.sy... ] Pete Muir updated CDI-307: -------------------------- Fix Version/s: 1.1 (Proposed) > Use @Priority annotation introduced in common annotations for ordering interceptors, decorators and alternatives > ---------------------------------------------------------------------------------------------------------------- > > Key: CDI-307 > URL: https://issues.jboss.org/browse/CDI-307 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Pete Muir > Fix For: 1.1 (Proposed) > > > Common annotations is introducing a @Priority annotation for ordering, we should update our spec to use this, possibly replacing the beans.xml approach. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 4 months

1
0
0 / 0

[JBoss JIRA] (CDI-308) Things with a container assigned priority should start at 1500, not 1000

by Pete Muir (JIRA)

[ https://issues.jboss.org/browse/CDI-308?page=com.atlassian.jira.plugin.sy... ] Pete Muir updated CDI-308: -------------------------- Fix Version/s: 1.1 (Proposed) > Things with a container assigned priority should start at 1500, not 1000 > ------------------------------------------------------------------------ > > Key: CDI-308 > URL: https://issues.jboss.org/browse/CDI-308 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Pete Muir > Fix For: 1.1 (Proposed) > > > This allows easy insertion before -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 4 months

1
0
0 / 0

[JBoss JIRA] (CDI-311) Move CDI interceptors chapter to interceptors spec

by Pete Muir (JIRA)

Pete Muir created CDI-311: ----------------------------- Summary: Move CDI interceptors chapter to interceptors spec Key: CDI-311 URL: https://issues.jboss.org/browse/CDI-311 Project: CDI Specification Issues Issue Type: Feature Request Affects Versions: 1.1.PRD Reporter: Pete Muir Fix For: 1.1 (Proposed) The Java EE spec leads have requested that we align by moving this chapter over to the interceptors spec as an optional way of using interceptors, that is required for CDI beans. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 4 months

1
0
0 / 0

[JBoss JIRA] (CDI-310) Standardize priority range size to 1000 a piece

by Pete Muir (JIRA)

Pete Muir created CDI-310: ----------------------------- Summary: Standardize priority range size to 1000 a piece Key: CDI-310 URL: https://issues.jboss.org/browse/CDI-310 Project: CDI Specification Issues Issue Type: Feature Request Reporter: Pete Muir -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 4 months

1
0
0 / 0

[JBoss JIRA] (CDI-309) Consider using -1 as a priority to disable something rather than an explicit enabled flag

by Pete Muir (JIRA)

Pete Muir created CDI-309: ----------------------------- Summary: Consider using -1 as a priority to disable something rather than an explicit enabled flag Key: CDI-309 URL: https://issues.jboss.org/browse/CDI-309 Project: CDI Specification Issues Issue Type: Feature Request Reporter: Pete Muir -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 4 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

cdi-dev December 2012