November 2015 - cdi-dev - Jboss List Archives

[JBoss JIRA] (CDI-568) Enhancing Java SE bootstrap API

by Antoine Sabot-Durand (JIRA)

Antoine Sabot-Durand created CDI-568: ---------------------------------------- Summary: Enhancing Java SE bootstrap API Key: CDI-568 URL: https://issues.jboss.org/browse/CDI-568 Project: CDI Specification Issues Issue Type: Feature Request Components: Java SE Integration Affects Versions: 2.0-EDR1 Reporter: Antoine Sabot-Durand As discussed during our Paris Face to Face meeting, we should work on enhancing the SE bootstrap API designed for EDR1. The current version has the following flaws: * Use existing classes was a bad idea (of mine). It prevents us to remove bootstrap classes in Java EE and force the impl to manage extra work if a user in EE try to use boostrap API. * While the parameter map is useful, I find it's not fitting the CDI strong typed philosophy, so it would be better to use it as fallback for implementation specific configuration. * Don't provide a nice way to programmatically configure the container behavior. That's why I'd like to update the proposed API and provide a more complete approach. Starting with the new [Weld SE api|https://github.com/weld/core/blob/master/environments/se/core/src/mai...] could be interesting -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-484) Provide forwarding implementations of SPI interfaces

by Martin Kouba (JIRA)

[ https://issues.jboss.org/browse/CDI-484?page=com.atlassian.jira.plugin.sy... ] Martin Kouba commented on CDI-484: ---------------------------------- I don't think it's the same. {{ForwardingImplementation}} is more like a decorator pattern - subclasses override one or more methods to modify the behavior. If you look at the example in the description - the annotated type from the event is decorated. And this annotated type could have been modified by any other extension (!) - this cannot be implemented by a builder read method. Therefore, I believe we should add these forwarding implementations. > Provide forwarding implementations of SPI interfaces > ---------------------------------------------------- > > Key: CDI-484 > URL: https://issues.jboss.org/browse/CDI-484 > Project: CDI Specification Issues > Issue Type: Feature Request > Components: Portable Extensions > Affects Versions: 1.2.Final > Reporter: Jozef Hartinger > Fix For: 2.0 (discussion) > > > The decorator design pattern is commonly used in CDI extensions to modify existing metadata by wrapping it with a wrapper implementation that overrides certain method. This can be done in the following callbacks: ProcessAnnotatedType, ProcessProducer, ProcessInjectionTarget, ProcessInjectionPoint and ProcessBeanAttributes. > In order to do this it is often very convenient to have a forwarding implementation available, e.g.: > {code:JAVA} > void wrap(@Observes ProcessAnnotatedType<Foo> event) { > final AnnotatedType<Foo> delegate = event.getAnnotatedType(); > event.setAnnotatedType(new ForwardingAnnotatedType<Foo>(delegate) { > @Override > public <A extends Annotation> A getAnnotation(Class<A> annotationType) { > return null; > } > @Override > public Set<Annotation> getAnnotations() { > return Collections.emptySet(); > } > @Override > public boolean isAnnotationPresent(Class<? extends Annotation> annotationType) { > return false; > } > } > {code} > We should consider providing these utility forwarding implementations as part of the CDI API. This is similar to e.g. Servlet specification doing this for their decorable APIs (http://tomcat.apache.org/tomcat-5.5-doc/servletapi/javax/servlet/http/Htt...) -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-558) Standardize the Meta-Data builders API (BeanBuilder, etc...)

by Martin Kouba (JIRA)

[ https://issues.jboss.org/browse/CDI-558?page=com.atlassian.jira.plugin.sy... ] Martin Kouba commented on CDI-558: ---------------------------------- bq. The question is how should we retrieve these builders For {{BeanBuilder}}, {{BeanAttributesBuilder}} and {{ObserverMethodBuilder}} I think it is a good idea to restrict the access to container lifecycle events (or [CDI SE builder|https://github.com/weld/core/blob/master/environments/se/core/src...] respectivelly). Maybe we should create a table and for each SPI add some description, purpose and/or use-case, possible implementation problems, etc. > Standardize the Meta-Data builders API (BeanBuilder, etc...) > ------------------------------------------------------------ > > Key: CDI-558 > URL: https://issues.jboss.org/browse/CDI-558 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Martin Kouba > Fix For: 2.0 (discussion) > > > The RI includes an experimental BeanBuilder API (see also http://weld.cdi-spec.org/news/2015/02/25/weld-300Alpha5/#_bean_builder_api for more information). The API is similar to the [API provided by DeltaSpike|http://deltaspike.apache.org/javadoc/1.2.1/org/apache/deltaspi...] but also includes some improvements (e.g. Java 8 lambdas may be used to simplify the process of registration). > * BeanBuilder Javadoc: http://docs.jboss.org/weld/javadoc/3.0/weld-api/org/jboss/weld/experiment... > * ExperimentalAfterBeanDiscovery Javadoc: http://docs.jboss.org/weld/javadoc/3.0/weld-api/org/jboss/weld/experiment... > * See also [the test extension for more examples of using this API|https://github.com/weld/core/blob/master/tests-arquillian/src/test/ja...] -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-484) Provide forwarding implementations of SPI interfaces

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-484?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand commented on CDI-484: ------------------------------------------ it's a sub use case of building metadata. > Provide forwarding implementations of SPI interfaces > ---------------------------------------------------- > > Key: CDI-484 > URL: https://issues.jboss.org/browse/CDI-484 > Project: CDI Specification Issues > Issue Type: Feature Request > Components: Portable Extensions > Affects Versions: 1.2.Final > Reporter: Jozef Hartinger > Fix For: 2.0 (discussion) > > > The decorator design pattern is commonly used in CDI extensions to modify existing metadata by wrapping it with a wrapper implementation that overrides certain method. This can be done in the following callbacks: ProcessAnnotatedType, ProcessProducer, ProcessInjectionTarget, ProcessInjectionPoint and ProcessBeanAttributes. > In order to do this it is often very convenient to have a forwarding implementation available, e.g.: > {code:JAVA} > void wrap(@Observes ProcessAnnotatedType<Foo> event) { > final AnnotatedType<Foo> delegate = event.getAnnotatedType(); > event.setAnnotatedType(new ForwardingAnnotatedType<Foo>(delegate) { > @Override > public <A extends Annotation> A getAnnotation(Class<A> annotationType) { > return null; > } > @Override > public Set<Annotation> getAnnotations() { > return Collections.emptySet(); > } > @Override > public boolean isAnnotationPresent(Class<? extends Annotation> annotationType) { > return false; > } > } > {code} > We should consider providing these utility forwarding implementations as part of the CDI API. This is similar to e.g. Servlet specification doing this for their decorable APIs (http://tomcat.apache.org/tomcat-5.5-doc/servletapi/javax/servlet/http/Htt...) -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-484) Provide forwarding implementations of SPI interfaces

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-484?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand commented on CDI-484: ------------------------------------------ I think we could merge with feature with CDI-558. Decorating an existing metadata could be done with a read() method taking the metadata type. > Provide forwarding implementations of SPI interfaces > ---------------------------------------------------- > > Key: CDI-484 > URL: https://issues.jboss.org/browse/CDI-484 > Project: CDI Specification Issues > Issue Type: Feature Request > Components: Portable Extensions > Affects Versions: 1.2.Final > Reporter: Jozef Hartinger > Fix For: 2.0 (discussion) > > > The decorator design pattern is commonly used in CDI extensions to modify existing metadata by wrapping it with a wrapper implementation that overrides certain method. This can be done in the following callbacks: ProcessAnnotatedType, ProcessProducer, ProcessInjectionTarget, ProcessInjectionPoint and ProcessBeanAttributes. > In order to do this it is often very convenient to have a forwarding implementation available, e.g.: > {code:JAVA} > void wrap(@Observes ProcessAnnotatedType<Foo> event) { > final AnnotatedType<Foo> delegate = event.getAnnotatedType(); > event.setAnnotatedType(new ForwardingAnnotatedType<Foo>(delegate) { > @Override > public <A extends Annotation> A getAnnotation(Class<A> annotationType) { > return null; > } > @Override > public Set<Annotation> getAnnotations() { > return Collections.emptySet(); > } > @Override > public boolean isAnnotationPresent(Class<? extends Annotation> annotationType) { > return false; > } > } > {code} > We should consider providing these utility forwarding implementations as part of the CDI API. This is similar to e.g. Servlet specification doing this for their decorable APIs (http://tomcat.apache.org/tomcat-5.5-doc/servletapi/javax/servlet/http/Htt...) -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-558) Standardize the Meta-Data builders API (BeanBuilder, etc...)

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-558?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand commented on CDI-558: ------------------------------------------ We should do this for all SPI metadata in the spec. That would bring us: * {{AnnotatedTypeBuilder}} * {{BeanAttributesBuilder}} (Ancestor of BeanBuilder to be used in ProcessBeanAttributes) * {{InjectionPointBuilder}} * {{ObserverMethodBuilder}} Less sure about: * {{InjectionTargetBuilder}} (we already have a factory) * {{ProducerBuilder}} (Factory here as well) The question is how should we retrieve these builders. I don't think it's a good idea to restrict their access to lifecyle event since we could need them outside an extension. {{BeanManager}} seems the obvious place but there are already too much method in it. Perhaps it's time to create an interface for such service method, that the BeanManager would implement and that could be injected as well to provide access to these builders. WDYT ? > Standardize the Meta-Data builders API (BeanBuilder, etc...) > ------------------------------------------------------------ > > Key: CDI-558 > URL: https://issues.jboss.org/browse/CDI-558 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Martin Kouba > Fix For: 2.0 (discussion) > > > The RI includes an experimental BeanBuilder API (see also http://weld.cdi-spec.org/news/2015/02/25/weld-300Alpha5/#_bean_builder_api for more information). The API is similar to the [API provided by DeltaSpike|http://deltaspike.apache.org/javadoc/1.2.1/org/apache/deltaspi...] but also includes some improvements (e.g. Java 8 lambdas may be used to simplify the process of registration). > * BeanBuilder Javadoc: http://docs.jboss.org/weld/javadoc/3.0/weld-api/org/jboss/weld/experiment... > * ExperimentalAfterBeanDiscovery Javadoc: http://docs.jboss.org/weld/javadoc/3.0/weld-api/org/jboss/weld/experiment... > * See also [the test extension for more examples of using this API|https://github.com/weld/core/blob/master/tests-arquillian/src/test/ja...] -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-558) Standardize the Meta-Data builders API (BeanBuilder, etc...)

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-558?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand updated CDI-558: ------------------------------------- Fix Version/s: 2.0 (discussion) > Standardize the Meta-Data builders API (BeanBuilder, etc...) > ------------------------------------------------------------ > > Key: CDI-558 > URL: https://issues.jboss.org/browse/CDI-558 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Martin Kouba > Fix For: 2.0 (discussion) > > > The RI includes an experimental BeanBuilder API (see also http://weld.cdi-spec.org/news/2015/02/25/weld-300Alpha5/#_bean_builder_api for more information). The API is similar to the [API provided by DeltaSpike|http://deltaspike.apache.org/javadoc/1.2.1/org/apache/deltaspi...] but also includes some improvements (e.g. Java 8 lambdas may be used to simplify the process of registration). > * BeanBuilder Javadoc: http://docs.jboss.org/weld/javadoc/3.0/weld-api/org/jboss/weld/experiment... > * ExperimentalAfterBeanDiscovery Javadoc: http://docs.jboss.org/weld/javadoc/3.0/weld-api/org/jboss/weld/experiment... > * See also [the test extension for more examples of using this API|https://github.com/weld/core/blob/master/tests-arquillian/src/test/ja...] -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-558) Standardize the Meta-Data builders API (BeanBuilder, etc...)

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-558?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand updated CDI-558: ------------------------------------- Summary: Standardize the Meta-Data builders API (BeanBuilder, etc...) (was: Standardize the BeanBuilder API) > Standardize the Meta-Data builders API (BeanBuilder, etc...) > ------------------------------------------------------------ > > Key: CDI-558 > URL: https://issues.jboss.org/browse/CDI-558 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Martin Kouba > > The RI includes an experimental BeanBuilder API (see also http://weld.cdi-spec.org/news/2015/02/25/weld-300Alpha5/#_bean_builder_api for more information). The API is similar to the [API provided by DeltaSpike|http://deltaspike.apache.org/javadoc/1.2.1/org/apache/deltaspi...] but also includes some improvements (e.g. Java 8 lambdas may be used to simplify the process of registration). > * BeanBuilder Javadoc: http://docs.jboss.org/weld/javadoc/3.0/weld-api/org/jboss/weld/experiment... > * ExperimentalAfterBeanDiscovery Javadoc: http://docs.jboss.org/weld/javadoc/3.0/weld-api/org/jboss/weld/experiment... > * See also [the test extension for more examples of using this API|https://github.com/weld/core/blob/master/tests-arquillian/src/test/ja...] -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

cdi-dev November 2015